Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accessibility tests for dashboard panel ( OSS) #62055

Merged
merged 6 commits into from
Apr 1, 2020
Merged

accessibility tests for dashboard panel ( OSS) #62055

merged 6 commits into from
Apr 1, 2020

Conversation

rashmivkulkarni
Copy link
Contributor

Ref Meta issue: #51456
Sub issue: #60766

@rashmivkulkarni rashmivkulkarni added Feature:Dashboard Dashboard related features Project:Accessibility test_ui_functional Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 labels Mar 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

This test- loads sample data - Flights and navigates to Dashboard > Opens up the toggle button - inspects > dashboard panel inspector statistics, request, response from the fly out and also tests the dashboard full screen view. These panels are same for all the visualizations in a dashboard.
( OSS)

Updated with correct screenshots matching the test.

Screen Shot 2020-03-31 at 2 39 20 PM

Screen Shot 2020-03-31 at 2 39 24 PM

Screen Shot 2020-03-31 at 2 39 13 PM

Screen Shot 2020-03-31 at 2 39 05 PM

@bhavyarm bhavyarm mentioned this pull request Mar 31, 2020
Open
77 tasks
@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

myasonik
myasonik approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@bhavyarm What do you think of the file structure? We thought the dashboard tests file was getting a little long and unwieldy so we broke this out into its own file but you might have a better grasp of the tests than I do at this point 😄

@rashmivkulkarni
Copy link
Contributor Author

cc @LeeDr

@bhavyarm
Copy link
Contributor

bhavyarm commented Apr 1, 2020

@myasonik that works fine. The choice was upto @Rasroh yay

bhavyarm
bhavyarm requested changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rasroh view mode tests look great.
But the tests for edit mode are completely missing.
Screen Shot 2020-04-01 at 6 08 32 PM

@bhavyarm
Copy link
Contributor

bhavyarm commented Apr 1, 2020

alternative suggestion. Merge this PR in and then raise one more for edit mode. If you do - raise an issue and I will LGTM. Thank you!!

@rashmivkulkarni rashmivkulkarni merged commit 07be066 into elastic:master Apr 1, 2020
@rashmivkulkarni rashmivkulkarni mentioned this pull request Apr 1, 2020
Merged
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Apr 1, 2020
@rashmivkulkarni @elasticmachine
accessibility tests for dashboard panel ( OSS) (elastic#62055)
9f716f6 
* accessibility tests for dashboard panel

* added back the skipped test as it is still required to pass through the a11ySnapshot

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
rashmivkulkarni added a commit that referenced this pull request Apr 2, 2020
@rashmivkulkarni @elasticmachine
accessibility tests for dashboard panel ( OSS) (#62055) (#62244)
929bcaf 
* accessibility tests for dashboard panel

* added back the skipped test as it is still required to pass through the a11ySnapshot

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 2, 2020
@gmmorris
Merge branch 'master' into event-log/query-support
3cc9ed4 
* master:
  [HomeApp] Set breadcrumbs when coming back from add data dir (elastic#62186)
  [Lens] fix error for minInterval>computedInterval for XYChart (elastic#61931)
  ci: remove AppArch label from ProBot path-labeler (elastic#62211)
  [Uptime] Optimize get latest monitor API (elastic#61820)
  [Maps] Separate layer wizards for Clusters and heatmap (elastic#60870)
  Remove polling delay (elastic#62099)
  accessibility tests for dashboard panel ( OSS)  (elastic#62055)
  rename README.md to readme, avoiding issues with case change
  [SIEM] [Detection Engine] Fixes all rules sorting (elastic#62039)
  [SIEM] CASES Bugs BC2 (elastic#62170)
  Revert "Endpoint: Add ts-node dev dependency (elastic#61884)" (elastic#62197)
  Closes elastic#60173 by turning off client caching for the main service map API call (elastic#62111)
  [SIEM] Restores the _External alert count_ widget's subtitle (elastic#62094)
  [Maps] Update ems client dependency to 7.8.0 (elastic#62181)
  [Metrics Alerts] Fix action variables, default message, and EU… (elastic#62061)
  Update CODEOWNERS with ES-UI apps, including grok debugger. (elastic#62045)
  Update ILM node attributes blacklist. (elastic#62093)
@rashmivkulkarni rashmivkulkarni mentioned this pull request Apr 22, 2020
Closed
@timroes timroes added v7.13.0 release_note:skip Skip the PR/issue when compiling release notes labels Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myasonik myasonik myasonik approved these changes

@bhavyarm bhavyarm bhavyarm approved these changes

Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure test_ui_functional v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rashmivkulkarni @elasticmachine @kibanamachine @bhavyarm @myasonik @timroes