[Logs / Metrics UI] Switch to scopedHistory and enhance useLinkProps hook

[Kerry350]

Summary

This ticket primarily fixes #58112 (which switches us over to using scopedHistory), but there have also been two enhancements to the useLinkProps hook. I'll explain the changes in detail below:

Use scopedHistory

We now use the scopedHistory history instance that is passed in from platform as part of the AppMountParameters.

Use navigateToApp exclusively in useLinkProps

Previously the useLinkProps hook had two logic forks, one for internal links and one for external links. Now that we're using scopedHistory, and because navigateToApp just pushes to history under the hood, we can just make use of navigateToApp for all onClick handlers.

If navigating between two new platform applications there will be no page refresh (this is all NP apps now, not just navigating between logs and metrics).

Links to legacy apps will hard refresh, as expected.

Custom <Prompt /> implementation

This is the change that requires the most explanation. Previously we were using the <Prompt /> component from react-router to warn the user if they were going to lose source configuration form changes.

However, under the hood that react-router component uses history.block. history.block is now banned with scopedHistory, it will throw an Error and instead suggest the use of the onAppLeave mount parameter.

There are a couple of issues with using onAppLeave, A) it only handles switching between apps (not tabs of an app) and B) I found the behaviour a little buggy (sometimes the handler didn't fire switching apps).

I've therefore implemented a little bit of context, and a custom <Prompt /> component, to recreate the same behaviour the react-router component gave us.

As we have a centralised location that handles the generation of our link props with useLinkProps it was easy to block navigation if needed there.

Testing

• Do links still work as expected? (Are the href attributes correct, encoded correctly etc. Do they work as expected when clicked?)

• If you make changes to the source configuration form, and then try to navigate away, is a warning displayed?

[elasticmachine]

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

[jasonrhodes]

I'm taking a look at this today.

[Kerry350]

@elasticmachine merge upstream

[Kerry350]

@jasonrhodes Were there any changes needed on this one?

[jasonrhodes]

Tested this thoroughly and wasn't able to find anything wrong with it at all, I was pretty bummed to be honest. Merge away. Sorry again for the delay!

[jasonrhodes]

@elasticmachine merge upstream

[elasticmachine]

merge conflict between base and head

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 903e213

History

• 💔 Build #42249 failed e2e82d3
• 💚 Build #38802 succeeded 4dc8b6f
• 💚 Build #38151 succeeded 352423c
• 💔 Build #38111 failed b7653cc
• 💔 Build #37797 failed a9846d8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream