Fix validation for index threshold when selecting an index #61615

mikecote · 2020-03-27T13:09:28Z

I'm making the "Select a field" text remain after validation fails and ensuring "INDEX" remains red until validation passes.

More UX could be done, let me know what you think.

elasticmachine · 2020-03-27T13:09:31Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

YulNaumenko

LGTM

mikecote · 2020-03-31T15:44:00Z

@elasticmachine merge upstream

pmuellr · 2020-03-31T18:38:40Z

It looks like there's no error indication when an index is selected but the time field is not - you can't save, but it also doesn't show you what's missing:

…x-field-validation

mikecote · 2020-03-31T19:10:40Z

@pmuellr I made some changes in c43def3 to ensure the "Expression contains error" message appears when not setting the time field. Let me know what you think!

pmuellr · 2020-03-31T20:22:39Z

With the new commit, it's obvious where the error is now. There's still a kinda odd thing that after you select the index, you're not really forced to set the time field, nothing is telling you to do that (besides the default drop-down entry of "select field" or whatever), until you click away and then the error appears.

Seems like it's better than before, so 👍 for that! Will review in a minute.

pmuellr

LGTM

mikecote · 2020-03-31T20:27:55Z

With the new commit, it's obvious where the error is now. There's still a kinda odd thing that after you select the index, you're not really forced to set the time field, nothing is telling you to do that (besides the default drop-down entry of "select field" or whatever), until you click away and then the error appears.

I can make the time field seem like it failed validation after selecting an index pattern. I think it's a few lines of code. If you're +1 on that behaviour I can push a change tomorrow.

kibanamachine · 2020-03-31T21:15:12Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: c43def3
Flaky suites:
- xpack-kibana-ciGroup1

Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_rules·ts.detection engine api security and spaces enabled create_rules creating rules should create a single Machine Learning rule

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 5 times on tracked branches: https://github.com/elastic/kibana/issues/61995

[00:00:00]       │
[00:00:00]         └-: detection engine api security and spaces enabled
[00:00:00]           └-> "before all" hook
[00:00:12]           └-: create_rules
[00:00:12]             └-> "before all" hook
[00:00:12]             └-: creating rules
[00:00:12]               └-> "before all" hook
[00:00:12]               └-> should create a single rule with a rule_id
[00:00:12]                 └-> "before each" hook: global before each
[00:00:12]                 └-> "before each" hook
[00:00:12]                   │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] adding index lifecycle policy [.siem-signals-default]
[00:00:12]                   │ info [o.e.c.m.MetaDataIndexTemplateService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] adding template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:00:12]                   │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1], mappings [_doc]
[00:00:13]                   │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:00:13]                   │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [.siem-signals-default]
[00:00:13]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [.siem-signals-default]
[00:00:17]                 │ info [o.e.x.s.a.AuthenticationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] Authentication using apikey failed - api key has been invalidated
[00:00:17]                 │ proc [kibana]   log   [20:27:36.138] [error][plugins][siem] An error occurred during rule execution:
[00:00:17]                 │ proc [kibana] message: "[security_exception] missing authentication credentials for REST request [/auditbeat-*/_search?allow_no_indices=true&size=100&ignore_unavailable=true], with { header={ WWW-Authenticate={ 0="Bearer realm=\"security\"" & 1="ApiKey" & 2="Basic realm=\"security\" charset=\"UTF-8\"" } } }"
[00:00:17]                 │ proc [kibana] name: "Simple Rule Query"
[00:00:17]                 │ proc [kibana] id: "784a2662-63aa-4398-aea7-b405e1060fee"
[00:00:17]                 │ proc [kibana] rule id: "rule-1"
[00:00:17]                 │ proc [kibana] signals index: ".siem-signals-default"
[00:00:17]                 │ info [o.e.x.s.a.AuthenticationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] Authentication using apikey failed - api key has been invalidated
[00:00:17]                 │ proc [kibana]   log   [20:27:36.147] [error][alerting][alerting][plugins][plugins] Executing Alert "784a2662-63aa-4398-aea7-b405e1060fee" has resulted in Error: [security_exception] missing authentication credentials for REST request [/_security/user/_has_privileges], with { header={ WWW-Authenticate={ 0="Bearer realm=\"security\"" & 1="ApiKey" & 2="Basic realm=\"security\" charset=\"UTF-8\"" } } }
[00:00:17]                 └- ✓ pass  (4.5s) "detection engine api security and spaces enabled create_rules creating rules should create a single rule with a rule_id"
[00:00:17]               └-> "after each" hook
[00:00:17]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] [.siem-signals-default-000001/bkEoJIhwQHO_8dglgKgfig] deleting index
[00:00:17]                 │ info [o.e.c.m.MetaDataIndexTemplateService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] removing template [.siem-signals-default]
[00:00:17]               └-> should create a single rule without an input index
[00:00:17]                 └-> "before each" hook: global before each
[00:00:17]                 └-> "before each" hook
[00:00:17]                   │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] adding index lifecycle policy [.siem-signals-default]
[00:00:17]                   │ info [o.e.c.m.MetaDataIndexTemplateService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] adding template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:00:18]                   │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1], mappings [_doc]
[00:00:18]                   │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:00:18]                   │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [.siem-signals-default]
[00:00:18]                   │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [.siem-signals-default]
[00:00:22]                 │ info [o.e.x.s.a.AuthenticationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] Authentication using apikey failed - api key has been invalidated
[00:00:22]                 │ proc [kibana]   log   [20:27:41.163] [error][plugins][siem] An error occurred during rule execution:
[00:00:22]                 │ proc [kibana] message: "[security_exception] missing authentication credentials for REST request [/apm-*-transaction*%2Cauditbeat-*%2Cendgame-*%2Cfilebeat-*%2Cpacketbeat-*%2Cwinlogbeat-*/_search?allow_no_indices=true&size=100&ignore_unavailable=true], with { header={ WWW-Authenticate={ 0="Bearer realm=\"security\"" & 1="ApiKey" & 2="Basic realm=\"security\" charset=\"UTF-8\"" } } }"
[00:00:22]                 │ proc [kibana] name: "Simple Rule Query"
[00:00:22]                 │ proc [kibana] id: "a74b136b-f4f7-4177-ae67-e572d5121228"
[00:00:22]                 │ proc [kibana] rule id: "rule-1"
[00:00:22]                 │ proc [kibana] signals index: ".siem-signals-default"
[00:00:22]                 │ info [o.e.x.s.a.AuthenticationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] Authentication using apikey failed - api key has been invalidated
[00:00:22]                 │ proc [kibana]   log   [20:27:41.169] [error][alerting][alerting][plugins][plugins] Executing Alert "a74b136b-f4f7-4177-ae67-e572d5121228" has resulted in Error: [security_exception] missing authentication credentials for REST request [/_security/user/_has_privileges], with { header={ WWW-Authenticate={ 0="Bearer realm=\"security\"" & 1="ApiKey" & 2="Basic realm=\"security\" charset=\"UTF-8\"" } } }
[00:00:22]                 └- ✓ pass  (4.3s) "detection engine api security and spaces enabled create_rules creating rules should create a single rule without an input index"
[00:00:22]               └-> "after each" hook
[00:00:22]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] [.siem-signals-default-000001/0NPiHo21StyfIdqhzcm5FQ] deleting index
[00:00:22]                 │ info [o.e.c.m.MetaDataIndexTemplateService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] removing template [.siem-signals-default]
[00:00:22]               └-> should create a single rule without a rule_id
[00:00:22]                 └-> "before each" hook: global before each
[00:00:22]                 └-> "before each" hook
[00:00:22]                   │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] adding index lifecycle policy [.siem-signals-default]
[00:00:23]                   │ info [o.e.c.m.MetaDataIndexTemplateService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] adding template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:00:23]                   │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1], mappings [_doc]
[00:00:23]                   │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:00:23]                   │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [.siem-signals-default]
[00:00:23]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [.siem-signals-default]
[00:00:27]                 └- ✓ pass  (4.4s) "detection engine api security and spaces enabled create_rules creating rules should create a single rule without a rule_id"
[00:00:27]               └-> "after each" hook
[00:00:27]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] [.siem-signals-default-000001/wqIJr6l4RD-bPvpgICSyaw] deleting index
[00:00:27]                 │ info [o.e.c.m.MetaDataIndexTemplateService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] removing template [.siem-signals-default]
[00:00:28]               └-> should create a single Machine Learning rule
[00:00:28]                 └-> "before each" hook: global before each
[00:00:28]                 └-> "before each" hook
[00:00:28]                   │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] adding index lifecycle policy [.siem-signals-default]
[00:00:28]                   │ info [o.e.c.m.MetaDataIndexTemplateService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] adding template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:00:28]                   │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1], mappings [_doc]
[00:00:28]                   │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:00:28]                   │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [.siem-signals-default]
[00:00:28]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [.siem-signals-default]
[00:00:31]                 │ proc [kibana]   log   [20:27:50.472] [warning][plugins][siem] Machine learning job is not started:
[00:00:31]                 │ proc [kibana] job id: "some_job_id"
[00:00:31]                 │ proc [kibana] job status: "undefined"
[00:00:31]                 │ proc [kibana] datafeed status: "undefined"
[00:00:31]                 │ proc [kibana] name: "Simple ML Rule"
[00:00:31]                 │ proc [kibana] id: "c2698165-9f00-4de7-af27-be2845bfdf46"
[00:00:31]                 │ proc [kibana] rule id: "rule-1"
[00:00:31]                 │ proc [kibana] signals index: ".siem-signals-default"
[00:00:33]                 │ info [o.e.x.s.a.AuthenticationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] Authentication using apikey failed - api key has been invalidated
[00:00:33]                 │ proc [kibana]   log   [20:27:52.507] [error][plugins][siem] An error occurred during rule execution:
[00:00:33]                 │ proc [kibana] message: "[security_exception] missing authentication credentials for REST request [/_security/user/_has_privileges], with { header={ WWW-Authenticate={ 0="Bearer realm=\"security\"" & 1="ApiKey" & 2="Basic realm=\"security\" charset=\"UTF-8\"" } } }"
[00:00:33]                 │ proc [kibana] name: "Simple ML Rule"
[00:00:33]                 │ proc [kibana] id: "c2698165-9f00-4de7-af27-be2845bfdf46"
[00:00:33]                 │ proc [kibana] rule id: "rule-1"
[00:00:33]                 │ proc [kibana] signals index: ".siem-signals-default"
[00:00:33]                 │ info [o.e.x.s.a.AuthenticationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585681794298074041] Authentication using apikey failed - api key has been invalidated
[00:00:33]                 │ proc [kibana]   log   [20:27:52.514] [error][alerting][alerting][plugins][plugins] Executing Alert "c2698165-9f00-4de7-af27-be2845bfdf46" has resulted in Error: [security_exception] missing authentication credentials for REST request [/_security/user/_has_privileges], with { header={ WWW-Authenticate={ 0="Bearer realm=\"security\"" & 1="ApiKey" & 2="Basic realm=\"security\" charset=\"UTF-8\"" } } }
[00:00:34]                 └- ✖ fail: "detection engine api security and spaces enabled create_rules creating rules should create a single Machine Learning rule"
[00:00:34]                 │

Stack Trace

{ Error: expected { created_by: 'elastic',
  description: 'Simple Machine Learning Rule',
  enabled: true,
  false_positives: [],
  from: 'now-6m',
  immutable: false,
  interval: '5m',
  rule_id: 'rule-1',
  output_index: '.siem-signals-default',
  max_signals: 100,
  risk_score: 1,
  name: 'Simple ML Rule',
  references: [],
  severity: 'high',
  updated_by: 'elastic',
  tags: [],
  to: 'now',
  type: 'machine_learning',
  threat: [],
  version: 1,
  lists: [],
  actions: [],
  throttle: 'no_actions',
  last_failure_at: '2020-03-31T20:27:50.492Z',
  last_failure_message: 'Machine learning job is not started:\njob id: "some_job_id"\njob status: "undefined"\ndatafeed status: "undefined"\nname: "Simple ML Rule"\nid: "c2698165-9f00-4de7-af27-be2845bfdf46"\nrule id: "rule-1"\nsignals index: ".siem-signals-default"',
  anomaly_threshold: 44,
  machine_learning_job_id: 'some_job_id' } to sort of equal { actions: [],
  created_by: 'elastic',
  description: 'Simple Machine Learning Rule',
  enabled: true,
  false_positives: [],
  from: 'now-6m',
  immutable: false,
  interval: '5m',
  rule_id: 'rule-1',
  output_index: '.siem-signals-default',
  max_signals: 100,
  risk_score: 1,
  name: 'Simple ML Rule',
  references: [],
  severity: 'high',
  updated_by: 'elastic',
  tags: [],
  to: 'now',
  type: 'machine_learning',
  threat: [],
  throttle: 'no_actions',
  lists: [],
  version: 1,
  anomaly_threshold: 44,
  machine_learning_job_id: 'some_job_id' }
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.it (test/detection_engine_api_integration/security_and_spaces/tests/create_rules.ts:101:34)
  actual:
   '{\n  "actions": []\n  "anomaly_threshold": 44\n  "created_by": "elastic"\n  "description": "Simple Machine Learning Rule"\n  "enabled": true\n  "false_positives": []\n  "from": "now-6m"\n  "immutable": false\n  "interval": "5m"\n  "last_failure_at": "2020-03-31T20:27:50.492Z"\n  "last_failure_message": "Machine learning job is not started:\\njob id: \\"some_job_id\\"\\njob status: \\"undefined\\"\\ndatafeed status: \\"undefined\\"\\nname: \\"Simple ML Rule\\"\\nid: \\"c2698165-9f00-4de7-af27-be2845bfdf46\\"\\nrule id: \\"rule-1\\"\\nsignals index: \\".siem-signals-default\\""\n  "lists": []\n  "machine_learning_job_id": "some_job_id"\n  "max_signals": 100\n  "name": "Simple ML Rule"\n  "output_index": ".siem-signals-default"\n  "references": []\n  "risk_score": 1\n  "rule_id": "rule-1"\n  "severity": "high"\n  "tags": []\n  "threat": []\n  "throttle": "no_actions"\n  "to": "now"\n  "type": "machine_learning"\n  "updated_by": "elastic"\n  "version": 1\n}',
  expected:
   '{\n  "actions": []\n  "anomaly_threshold": 44\n  "created_by": "elastic"\n  "description": "Simple Machine Learning Rule"\n  "enabled": true\n  "false_positives": []\n  "from": "now-6m"\n  "immutable": false\n  "interval": "5m"\n  "lists": []\n  "machine_learning_job_id": "some_job_id"\n  "max_signals": 100\n  "name": "Simple ML Rule"\n  "output_index": ".siem-signals-default"\n  "references": []\n  "risk_score": 1\n  "rule_id": "rule-1"\n  "severity": "high"\n  "tags": []\n  "threat": []\n  "throttle": "no_actions"\n  "to": "now"\n  "type": "machine_learning"\n  "updated_by": "elastic"\n  "version": 1\n}',
  showDiff: true }

History

💚 Build #37559 succeeded c5e5ab9
💚 Build #36780 succeeded 90061fb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

pmuellr · 2020-03-31T21:37:24Z

I can make the time field seem like it failed validation after selecting an index pattern. I think it's a few lines of code. If you're +1 on that behaviour I can push a change tomorrow.

Really not a fan of adding "a few lines of code" post FF - it's not a blocker of any kind, doesn't seem worth it to me. Ship it!

…1615) * Fix validation for index threshold when selecting an index * Ensure timeField gets validation message Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…62147) * Fix validation for index threshold when selecting an index * Ensure timeField gets validation message Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…62148) * Fix validation for index threshold when selecting an index * Ensure timeField gets validation message Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (44 commits) [Alerting] add alerting privileges for uptime and metrics (elastic#61113) Update percy agent to latest version (elastic#62089) [APM] Update central configuration text (elastic#61556) [Fleet] Ouput api key do not need metricbeat* access (elastic#60319) Document new `xpack.security.authc.*` settings and related 8.0.0 breaking changes. (elastic#61443) Migrate test plugins ⇒ NP (kbn_tp_sample_panel_action) (elastic#60749) [Alerting] Add "Start trial" button for connectors (elastic#61774) [ML] Transforms: Fix handling of default and advanced search on step summary view. (elastic#61799) [Task Manager] Change info message "ran out Available Workers" to debug (elastic#62083) [Maps] Highlight selected layer in TOC (elastic#61510) ensure pageIndex is set correclty in analytics list (elastic#62041) [ML] Functional API tests - fix mml request bodies (elastic#62116) Fix validation for index threshold when selecting an index (elastic#61615) [SIEM][Detection Engine] Adds release notes link and updates one UI section [backport] Bump to 5.1.2 (elastic#62117) [APM] .apm-agent-configuration is not created if Kibana is started while ES is not ready (elastic#61610) [Fleet] Enrollment list page (elastic#61346) [ML] Fix maximum default enabled columns for data grid. (elastic#62005) [Home][Tutorial] Add Oracle data UI (elastic#61595) [APM] Ensure telemetry data matches SO/telemetry mapping (elastic#61957) ...

Fix validation for index threshold when selecting an index

90061fb

mikecote added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 labels Mar 27, 2020

mikecote self-assigned this Mar 27, 2020

mikecote marked this pull request as ready for review March 27, 2020 17:39

mikecote requested a review from a team as a code owner March 27, 2020 17:39

YulNaumenko approved these changes Mar 27, 2020

View reviewed changes

Merge branch 'master' into alerting/index-field-validation

c5e5ab9

mikecote added 2 commits March 31, 2020 14:51

Merge branch 'master' of github.com:elastic/kibana into alerting/inde…

9691672

…x-field-validation

Ensure timeField gets validation message

c43def3

pmuellr approved these changes Mar 31, 2020

View reviewed changes

mikecote merged commit dd70c81 into elastic:master Apr 1, 2020

mikecote mentioned this pull request Apr 1, 2020

[7.x] Fix validation for index threshold when selecting an index (#61615) #62147

Merged

mikecote mentioned this pull request Apr 1, 2020

[7.7] Fix validation for index threshold when selecting an index (#61615) #62148

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix validation for index threshold when selecting an index #61615

Fix validation for index threshold when selecting an index #61615

mikecote commented Mar 27, 2020

elasticmachine commented Mar 27, 2020

YulNaumenko left a comment

mikecote commented Mar 31, 2020

pmuellr commented Mar 31, 2020

mikecote commented Mar 31, 2020

pmuellr commented Mar 31, 2020

pmuellr left a comment

mikecote commented Mar 31, 2020

kibanamachine commented Mar 31, 2020

Standard Out

Stack Trace

pmuellr commented Mar 31, 2020

Fix validation for index threshold when selecting an index #61615

Fix validation for index threshold when selecting an index #61615

Conversation

mikecote commented Mar 27, 2020

elasticmachine commented Mar 27, 2020

YulNaumenko left a comment

Choose a reason for hiding this comment

mikecote commented Mar 31, 2020

pmuellr commented Mar 31, 2020

mikecote commented Mar 31, 2020

pmuellr commented Mar 31, 2020

pmuellr left a comment

Choose a reason for hiding this comment

mikecote commented Mar 31, 2020

kibanamachine commented Mar 31, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

History

pmuellr commented Mar 31, 2020