-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validation for index threshold when selecting an index #61615
Fix validation for index threshold when selecting an index #61615
Conversation
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
With the new commit, it's obvious where the error is now. There's still a kinda odd thing that after you select the index, you're not really forced to set the time field, nothing is telling you to do that (besides the default drop-down entry of "select field" or whatever), until you click away and then the error appears. Seems like it's better than before, so 👍 for that! Will review in a minute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I can make the time field seem like it failed validation after selecting an index pattern. I think it's a few lines of code. If you're +1 on that behaviour I can push a change tomorrow. |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_rules·ts.detection engine api security and spaces enabled create_rules creating rules should create a single Machine Learning ruleStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
Really not a fan of adding "a few lines of code" post FF - it's not a blocker of any kind, doesn't seem worth it to me. Ship it! |
…1615) * Fix validation for index threshold when selecting an index * Ensure timeField gets validation message Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…1615) * Fix validation for index threshold when selecting an index * Ensure timeField gets validation message Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…62147) * Fix validation for index threshold when selecting an index * Ensure timeField gets validation message Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…62148) * Fix validation for index threshold when selecting an index * Ensure timeField gets validation message Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* master: (44 commits) [Alerting] add alerting privileges for uptime and metrics (elastic#61113) Update percy agent to latest version (elastic#62089) [APM] Update central configuration text (elastic#61556) [Fleet] Ouput api key do not need metricbeat* access (elastic#60319) Document new `xpack.security.authc.*` settings and related 8.0.0 breaking changes. (elastic#61443) Migrate test plugins ⇒ NP (kbn_tp_sample_panel_action) (elastic#60749) [Alerting] Add "Start trial" button for connectors (elastic#61774) [ML] Transforms: Fix handling of default and advanced search on step summary view. (elastic#61799) [Task Manager] Change info message "ran out Available Workers" to debug (elastic#62083) [Maps] Highlight selected layer in TOC (elastic#61510) ensure pageIndex is set correclty in analytics list (elastic#62041) [ML] Functional API tests - fix mml request bodies (elastic#62116) Fix validation for index threshold when selecting an index (elastic#61615) [SIEM][Detection Engine] Adds release notes link and updates one UI section [backport] Bump to 5.1.2 (elastic#62117) [APM] .apm-agent-configuration is not created if Kibana is started while ES is not ready (elastic#61610) [Fleet] Enrollment list page (elastic#61346) [ML] Fix maximum default enabled columns for data grid. (elastic#62005) [Home][Tutorial] Add Oracle data UI (elastic#61595) [APM] Ensure telemetry data matches SO/telemetry mapping (elastic#61957) ...
Fixes #61431
I'm making the "Select a field" text remain after validation fails and ensuring "INDEX" remains red until validation passes.
More UX could be done, let me know what you think.