Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] 7.7 documentation updates #61332

Merged
merged 4 commits into from
Apr 6, 2020
Merged

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Mar 25, 2020

No description provided.

@nreese nreese added Team:Docs [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 labels Mar 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the additions. I'm not sure if we should re-work the grid-agg documentation. The add-layer wizard will change significantly in 7.x to enable more curated workflows, and it might be nice to preserve the wordings in the UX for consistency. otherwise lgtm.

docs/maps/maps-aggregations.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style.asciidoc Outdated Show resolved Hide resolved
* *Fill color*
* *Border color*
* *Label color*
* *Label border color*

Qualitative data driven styling uses a {ref}/search-aggregations-bucket-terms-aggregation.html[terms aggregation] to retrieve the top nine categories for the property. Feature values within the top categories are assigned a unique color. Feature values outside of the top categories are grouped into the *Other* category. A feature is assigned the *Other* category when the property value is undefined.
To ensure symbols are consistent as you pan, zoom, and filter the map, qualitative data driven styling uses a {ref}/search-aggregations-bucket-terms-aggregation.html[terms aggregation] to retrieve the top nine categories for the property. Feature values within the top categories are assigned a unique style. Feature values outside of the top categories are grouped into the *Other* category. A feature is assigned the *Other* category when the property value is undefined.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are feature values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vector layers display features. A feature is a geometric shape like a point, line, or polygon. The feature also has a set of properties associated with the geometric shape. For example, if the feature is an airplane position the properties may be heading, speed, altitude, callsign, and so on. Feature values are the values for a property from all the features in a set.

docs/maps/vector-style.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style.asciidoc Outdated Show resolved Hide resolved
docs/maps/maps-aggregations.asciidoc Outdated Show resolved Hide resolved
docs/maps/maps-aggregations.asciidoc Outdated Show resolved Hide resolved
docs/maps/maps-aggregations.asciidoc Outdated Show resolved Hide resolved
docs/maps/maps-aggregations.asciidoc Outdated Show resolved Hide resolved
docs/maps/maps-aggregations.asciidoc Outdated Show resolved Hide resolved
@nreese nreese requested a review from KOTungseth April 1, 2020 22:54
Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nreese nreese merged commit d26372c into elastic:master Apr 6, 2020
nreese added a commit to nreese/kibana that referenced this pull request Apr 6, 2020
* [Maps] 7.7 doc updates

* blended layer

* revert to grid aggregation language

* review feedback
nreese added a commit to nreese/kibana that referenced this pull request Apr 6, 2020
* [Maps] 7.7 doc updates

* blended layer

* revert to grid aggregation language

* review feedback
nreese added a commit that referenced this pull request Apr 6, 2020
* [Maps] 7.7 doc updates

* blended layer

* revert to grid aggregation language

* review feedback
nreese added a commit that referenced this pull request Apr 6, 2020
* [Maps] 7.7 doc updates

* blended layer

* revert to grid aggregation language

* review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants