Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy "interpreter" plugin #61263

Merged
merged 8 commits into from
May 5, 2020
Merged

Remove legacy "interpreter" plugin #61263

merged 8 commits into from
May 5, 2020

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Mar 25, 2020 •
edited
Loading

Summary

This change completely deletes the legacy "interpreter" plugin.

After #58387 was merged, we can now delete "interpreter" plugin.

@streamich streamich marked this pull request as ready for review March 25, 2020 14:26
@streamich streamich requested a review from a team as a code owner March 25, 2020 14:26
@streamich streamich changed the title chore: 🤖 delete legacy interpreter registries Remove "legacy" expressions plugin Mar 25, 2020
@streamich streamich added Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes review Team:AppArch labels Mar 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich changed the title Remove "legacy" expressions plugin Remove legacy "interpreter" plugin Mar 25, 2020
@lukeelmers
Copy link
Member

There are still a few legacy plugins that have require: ['interpreter'] in their index.ts, which is probably contributing to some of the build failures.

@streamich
Copy link
Contributor Author

@lukeelmers yup, looking at that.

@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine elasticmachine requested a review from a team March 25, 2020 15:25
@elasticmachine elasticmachine requested a review from a team as a code owner March 25, 2020 15:25
crob611
crob611 suggested changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the Canvas stuff needs to stay for now. It's not actually related to interpreter plugin, but is the main interface for other plugins to add to canvas. It will likely change in the near future, but needs to stay for now.

x-pack/legacy/plugins/canvas/public/legacy_plugin_support.ts Outdated Show resolved Hide resolved
x-pack/legacy/plugins/canvas/README.md Outdated Show resolved Hide resolved
@streamich streamich requested review from crob611 and ppisljar March 26, 2020 08:35
flash1293
flash1293 approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana app changes LGTM

lizozom
lizozom approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ppisljar
ppisljar approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

@rayafratkina rayafratkina added v7.8.0 and removed v7.8 labels Apr 6, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit d77d2e4 into elastic:master May 5, 2020
@streamich streamich mentioned this pull request May 5, 2020
Merged
streamich added a commit that referenced this pull request May 5, 2020
@streamich @elasticmachine
Remove legacy "interpreter" plugin (#61263) (#65221)
1c9f6d1 
* chore: 🤖 delete legacy interpreter registries

* chore: 🤖 completely delete legacy "interpreter" plugin

* chore: 🤖 remove dependencies on legacy "interpreter" plugin

* chore: 🤖 revert back Canvas global registries

* test: 💍 fix Lens test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

@flash1293 flash1293 flash1293 approved these changes

@lizozom lizozom lizozom approved these changes

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes review v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@streamich @elasticmachine @lukeelmers @kibanamachine @crob611 @flash1293 @lizozom @ppisljar @rayafratkina