Fix race condition in flaky alerting test #60438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
Feature:Alerting
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
gmmorris
approved these changes
Mar 18, 2020
Agreed, I'm also hoping the advanced API key invalidation (#53868) will help reduce the need for code like this. Since the general invalidation of API keys (#53732), we've had a lot of race conditions in our tests. |
|
Found some flakiness (fixed in 413b6d2), doing another flaky test runner run here: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/264/. |
…cleanup-race-condition
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Mar 19, 2020
* Fix race condition in flaky test * Fix flakiness in test * Fix more flakiness
mikecote
added a commit
that referenced
this pull request
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm fixing a race condition where the alert gets disabled before the cleanup of the action task params can finish.
I'm renaming in the task manager utils
waitForIdletowaitForEmptyand adding a newwaitForAllTasksIdlefunction that will be called before disabling an alert. This allows the actions that run after an alert execution to also finish running.Reproducing steps
You can reproduce the flakiness by adding
await new Promise(r => setTimeout(r, 3000));here:
kibana/x-pack/plugins/actions/server/lib/task_runner_factory.ts
Line 103 in 8def60e
Fixes #58991
Fixes #58643