Make context.core required argument to context providers #59996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolf
added
chore
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
rudolf
commented
Mar 12, 2020
| @@ -882,8 +882,10 @@ export interface IContextContainer<THandler extends HandlerFunction<any>> { | |||
| registerContext<TContextName extends keyof HandlerContextType<THandler>>(pluginOpaqueId: PluginOpaqueId, contextName: TContextName, provider: IContextProvider<THandler, TContextName>): this; | |||
| } | |||
|
|
|||
| // Warning: (ae-forgotten-export) The symbol "PartialExceptFor" needs to be exported by the entry point index.d.ts | |||
There was a problem hiding this comment.
I think it's fine not to expose PartialExceptFor as plugins would never need to use this type directly.
rudolf
force-pushed
the
required-core-context
branch
from
98f92b2
to
a2cd39b
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
rudolf
added a commit
that referenced
this pull request
Mar 12, 2020
7 tasks
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 13, 2020
* master: [Alerting] extend Alert Type with names/descriptions of action variables (elastic#59756) [Ingest] Fix data source creation and double system data source (elastic#60069) Add button to view full service map (elastic#59394) unskip tests for code coverage (elastic#59725) [Ingest] Add Fleet & EPM features (elastic#59376) [Logs UI] Show navigation bar while loading source configurati… (elastic#59997) [Endpoint] ERT-82 Alerts search bar (elastic#59702) Aggregate queue types being used by Beats (elastic#59850) skip flaky suite (elastic#59541) Convert Timeline to TypeScript (elastic#59966) Make context.core required argument to context providers (elastic#59996)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes plugins' code for registering context providers a little bit cleaner.
Checklist
Delete any items that are not applicable to this PR.
For maintainers