Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Transforms: Updates Jest snapshots #59897

Merged
merged 1 commit into from
Mar 11, 2020
Merged

[ML] Transforms: Updates Jest snapshots #59897

merged 1 commit into from
Mar 11, 2020

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Mar 11, 2020 •
edited
Loading

Snapshot is failing on master

Closes #59878

#59782 was merged with failing test.

[ML] Updates Jest snapshots
68d392b 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 11, 2020
@tylersmalley tylersmalley requested a review from a team as a code owner March 11, 2020 13:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@tylersmalley tylersmalley changed the title [ML] Updates Jest snapshots [ML] Transforms: Updates Jest snapshots Mar 11, 2020
walterra
walterra approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@tylersmalley tylersmalley merged commit d781b3e into elastic:master Mar 11, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 12, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59897 or prevent reminders by adding the backport:skip label.

@walterra walterra added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 12, 2020
@walterra
Copy link
Contributor

Added backport:skip label since the backport of the original PR includes the snapshot fix #59868

simianhacker pushed a commit to simianhacker/kibana that referenced this pull request Mar 12, 2020
@simianhacker
[ML] Updates Jest snapshots (elastic#59897)
7cef371 
elastic#59782 was merged with failing test.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Mar 12, 2020
@jkelastic
[ML] Updates Jest snapshots (elastic#59897)
257367e 
elastic#59782 was merged with failing test.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@tylersmalley @elasticmachine @kibanamachine @walterra @jbudz