[Maps] Add UI to disable style meta and get top categories from current features #59707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orical_field_meta
…orical_field_meta
…orical_field_meta
nreese
added
release_note:enhancement
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
commented
Mar 9, 2020
| @@ -52,6 +53,10 @@ export class DynamicStyleProperty extends AbstractStyleProperty { | |||
| const fieldName = this.getFieldName(); | |||
| const rangeFieldMetaFromLocalFeatures = styleMeta.getRangeFieldMetaDescriptor(fieldName); | |||
|
|
|||
| if (!this.isFieldMetaEnabled()) { | |||
There was a problem hiding this comment.
Fixes a bug introduced in #58766 where disabling style meta would still use style meta range, instead of range from local features.
nreese
changed the title
gchaps
reviewed
Mar 10, 2020
...legacy/plugins/maps/public/layers/styles/vector/components/field_meta/field_meta_popover.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/common/style_property_descriptor_types.d.ts
Outdated
Show resolved
Hide resolved
| @@ -52,6 +53,10 @@ export class DynamicStyleProperty extends AbstractStyleProperty { | |||
| const fieldName = this.getFieldName(); | |||
| const rangeFieldMetaFromLocalFeatures = styleMeta.getRangeFieldMetaDescriptor(fieldName); | |||
|
|
|||
| if (!this.isFieldMetaEnabled()) { | |||
x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_style_property.d.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_style_property.d.ts
Outdated
Show resolved
Hide resolved
| supportsFeatureState(): boolean; | ||
| pluckOrdinalStyleMetaFromFeatures(features: unknown[]): RangeFieldMeta; | ||
| pluckCategoricalStyleMetaFromFeatures(features: unknown[]): CategoryFieldMeta; | ||
| pluckOrdinalStyleMetaFromFieldMetaData(fieldMetaData: unknown): RangeFieldMeta; |
There was a problem hiding this comment.
Worth creating types for the ES-responses? (don't feel strongly)
There was a problem hiding this comment.
I don't think this is worthwhile, at least not in this PR
thomasneirynck
approved these changes
Mar 11, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Mar 11, 2020
…nt features (elastic#59707) * rough start * remove unused files * get everything working * add style options types * convert DynmaicStyleProperty to TS * limit scope of PR * CategoricalFieldMetaPopover * update label and move functions to IStyleProperty interface * fix ts lint errors * replace unknown with IJoin now that its available * remove duplicate import * review feedback
nreese
added a commit
that referenced
this pull request
Mar 11, 2020
…nt features (#59707) (#59933) * rough start * remove unused files * get everything working * add style options types * convert DynmaicStyleProperty to TS * limit scope of PR * CategoricalFieldMetaPopover * update label and move functions to IStyleProperty interface * fix ts lint errors * replace unknown with IJoin now that its available * remove duplicate import * review feedback Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides UI to allow users to turn off style meta and instead get top categories from current features. PR also adds a bunch of types for StyleProperty and DynamicStyleProperty.
Categorical style meta fetches the top 9 terms for styling. When styling on a field with high cardinality, the current view may not contain any features with the top 9 terms. Allowing users to disable field meta will allow them to style by current features on the map.