Configurable shield credentials for tests #5967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epixa
force-pushed
the
5562-tests-with-shield
branch
from
594d44b
to
33091c2
Compare
While there are still hardcoded defaults, this change allows people to specify custom credentials via environment variables for each shield role in our tests.
epixa
force-pushed
the
5562-tests-with-shield
branch
from
33091c2
to
d50c48b
Compare
|
@epixa my only comment is whether we should be calling this something like the 'elasticsearch.admin.username'? |
|
I wanted the shield config itself to express the users and roles as they are configured in shield rather than how we may ultimately take advantage of them in our tests. |
|
LGTM |
epixa
added a commit
that referenced
this pull request
Jan 21, 2016
Configurable shield credentials for tests
|
courtewing merged this into the following branches!
|
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jan 21, 2016
While there are still hardcoded defaults, this change allows people to specify custom credentials via environment variables for each shield role in our tests. Fixes #5967
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there are still hardcoded defaults, this change allows people to
specify custom credentials via environment variables for each shield
role in our tests.
For #5562