Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Refactoring anomaly detector job types #59556

Merged
merged 6 commits into from
Mar 9, 2020
Merged

[ML] Refactoring anomaly detector job types #59556

merged 6 commits into from
Mar 9, 2020

Conversation

jgowdyelastic
Copy link
Member

Completes our interfaces for Jobs and Datafeeds and moves them to a common location. Removing the original partial Job config.

Typescriptifies server side Job Summary endpoint.

@jgowdyelastic jgowdyelastic requested a review from a team as a code owner March 6, 2020 15:26
@jgowdyelastic jgowdyelastic self-assigned this Mar 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov added the release_note:skip Skip the PR/issue when compiling release notes label Mar 6, 2020
@jgowdyelastic jgowdyelastic added the non-issue Indicates to automation that a pull request should not appear in the release notes label Mar 6, 2020
@jgowdyelastic jgowdyelastic force-pushed the refactoring-anomaly-detector-job-types branch from 3ca1b86 to 335e8c3 Compare March 6, 2020 16:47
walterra
walterra approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

pheyos
pheyos approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test changes LGTM

@jgowdyelastic jgowdyelastic force-pushed the refactoring-anomaly-detector-job-types branch from 809f5ed to b7ca502 Compare March 9, 2020 08:56
peteharverson
peteharverson reviewed Mar 9, 2020
View reviewed changes
x-pack/legacy/plugins/ml/common/types/anomaly_detection_jobs/datafeed_stats.ts Outdated

export interface DatafeedStats {
datafeed_id: string;
state: 'starting' | 'started' | 'stopping' | 'stopped';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the enums out of ml/common/constants/states.ts ?

x-pack/legacy/plugins/ml/common/types/anomaly_detection_jobs/job_stats.ts Outdated
data_counts: DataCounts;
model_size_stats: ModelSizeStats;
forecasts_stats: ForecastsStats;
state: 'closed' | 'closing' | 'failed' | 'opened' | 'opening' | 'deleted';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the enums out of ml/common/constants/states.ts ?

peteharverson
peteharverson approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic merged commit 92cc04c into elastic:master Mar 9, 2020
@jgowdyelastic jgowdyelastic deleted the refactoring-anomaly-detector-job-types branch March 9, 2020 13:51
@jgowdyelastic jgowdyelastic mentioned this pull request Mar 9, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Mar 9, 2020
@jgowdyelastic
[ML] Refactoring anomaly detector job types (elastic#59556)
56f5eb3 
* [ML] Refactoring anomaly detector job types

* removing calendar type

* update validateCardinality

* fixing test

* updating  types in functional tests

* using state constants
jgowdyelastic added a commit that referenced this pull request Mar 9, 2020
@jgowdyelastic
[ML] Refactoring anomaly detector job types (#59556) (#59655)
331c68e 
* [ML] Refactoring anomaly detector job types

* removing calendar type

* update validateCardinality

* fixing test

* updating  types in functional tests

* using state constants
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 10, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
0363764 
* master: (22 commits)
  Generate docs from data plugin (elastic#56955)
  Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514)
  Harden creation of child processes (elastic#55697)
  [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475)
  [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553)
  chore: 🤖 hide Drilldowns in master (elastic#59698)
  [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175)
  Use HTTP request schemas to create types, use those types in the client (elastic#59340)
  [Maps] Support categorical styling for numbers and dates (elastic#57908)
  [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665)
  Fix slm_ui setting by changing camel case back to snake case. (elastic#59663)
  removes beta tag (elastic#59618)
  [DOCS] Removed spatial references (elastic#59595)
  fix outdated docs (elastic#58729)
  [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639)
  [ML] Refactoring anomaly detector job types (elastic#59556)
  [Upgrade Assistant] Better handling of closed indices (elastic#58890)
  additional visualizations plugin cleanup before moving to NP (elastic#59318)
  In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285)
  [Visualize] Remove global state in visualize (elastic#58352)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 10, 2020
@gmmorris
Merge branch 'alerting/fix-flaky-instance-test' of github.com:gmmorri…
ea98883 
…s/kibana into alerting/fix-flaky-instance-test

* 'alerting/fix-flaky-instance-test' of github.com:gmmorris/kibana: (176 commits)
  Generate docs from data plugin (elastic#56955)
  Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514)
  Harden creation of child processes (elastic#55697)
  [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475)
  [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553)
  chore: 🤖 hide Drilldowns in master (elastic#59698)
  [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175)
  Use HTTP request schemas to create types, use those types in the client (elastic#59340)
  [Maps] Support categorical styling for numbers and dates (elastic#57908)
  [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665)
  Fix slm_ui setting by changing camel case back to snake case. (elastic#59663)
  removes beta tag (elastic#59618)
  [DOCS] Removed spatial references (elastic#59595)
  fix outdated docs (elastic#58729)
  [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639)
  [ML] Refactoring anomaly detector job types (elastic#59556)
  [Upgrade Assistant] Better handling of closed indices (elastic#58890)
  additional visualizations plugin cleanup before moving to NP (elastic#59318)
  In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285)
  [Visualize] Remove global state in visualize (elastic#58352)
  ...
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Mar 12, 2020
@jgowdyelastic @jkelastic
[ML] Refactoring anomaly detector job types (elastic#59556)
5d1a6bc 
* [ML] Refactoring anomaly detector job types

* removing calendar type

* update validateCardinality

* fixing test

* updating  types in functional tests

* using state constants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@pheyos pheyos pheyos approved these changes

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov Awaiting requested review from darnautov

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@jgowdyelastic jgowdyelastic

Labels
chore Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jgowdyelastic @elasticmachine @kibanamachine @walterra @pheyos @peteharverson @darnautov