-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest] Add Fleet & EPM features #59376
Commits on Nov 13, 2019
-
[EPM] Documentation of HTTP routes & TS types for Ingest (#48798)
* Add beginning models and two routes for Ingest * Update types & models per discussion w/Ruflin Also reviewed data structures listed at https://docs.google.com/document/d/1IBR3f9dpHqJmXYEdg06WV34KSMd3g5k4aMGa4jde_Eg/edit# * Update: /policies always returns array. /policy returns single policy * Add pagination for /policy & /datasources. Uses per_page & page params * Add API metadata. Standardize policy_id param name. * Update descriptions to match Google Doc. Move use case to Policy. Disabled the '@typescript-eslint/array-type' rule because it was going around in circles. It didn't like Datasource[] or Array<Datasource> * Return to initial TS annotation for Arrays Remove the line disabling @typescript-eslint/array-type now that it's behaving normally again 🤷
John Schulz committedNov 13, 2019 Configuration menu - View commit details
-
Copy full SHA for e4284b4 - Browse repository at this point
Copy the full SHA e4284b4View commit details
Commits on Nov 14, 2019
-
[EPM] Add directory structure for server/lib. (#50469)
* Add directory structure for server/lib. * 'tests' seems to be more common than 'test' * Make CI happy
Configuration menu - View commit details
-
Copy full SHA for e8ca16b - Browse repository at this point
Copy the full SHA e8ca16bView commit details -
[EPM] Add basic documentation directory (#50478)
* [EPM] Add basic documentation directory Having the doc directory around allows us to easily add docs from here on to document how EPM works. To run the docs build, use the following command from the kibana directory: ``` ../docs/build_docs --doc docs/epm/index.asciidoc --open ``` The above assumes that docs (https://github.com/elastic/docs) are checked out in the same directory as Kibana. With this change, the EPM docs build is not included yet in the overall docs build. For this adjustments to https://github.com/elastic/docs/blob/master/conf.yaml must be made.
Configuration menu - View commit details
-
Copy full SHA for ee2ecf4 - Browse repository at this point
Copy the full SHA ee2ecf4View commit details -
[EPM] Add basic index template (#50471)
This PR adds the very basic index template we will use for the packages. It contains all the basic settings and some examples. The examples will be remove as soon as we have an actual implementation with packages but for now is convenient to see if it is a valid package. This code is put into the lib directory as it does not tie directly into any handlers. It also adds an functional tests for loading a template. This means we have a way to check if a template is valid in Elasticsearch. Based on this we can check in the future all our generated templates for validity with Elasticsearch. To run the functional test, go to the Kibana x-pack directory. Start the first command: ``` node scripts/functional_tests_server.js --config test/epm_api_integration/config.ts ``` Keep the above running and switch to an other Terminal. Now run: ``` node scripts/functional_test_runner.js --config x-pack/test/epm_api_integration/config.ts ```
Configuration menu - View commit details
-
Copy full SHA for dc9f781 - Browse repository at this point
Copy the full SHA dc9f781View commit details -
40752 rewrite ingest pipeline (#50627)
* Add directory structure for server/lib. * 'tests' seems to be more common than 'test' * Make CI happy * Implement pipeline rewriting. * Add more testcases * For posterity (comment change) * Allow beats-style template delimiters * Be more succinct * Document better
Configuration menu - View commit details
-
Copy full SHA for 19a5746 - Browse repository at this point
Copy the full SHA 19a5746View commit details -
Replace AssetType enum with union type (#50696)
See #50609 (comment) Discussed in Slack and agree to revert for now. Can track down the issues & restore later
John Schulz committedNov 14, 2019 Configuration menu - View commit details
-
Copy full SHA for c522886 - Browse repository at this point
Copy the full SHA c522886View commit details -
Remove unnecessary await if we can return the promise (#50329)
John Schulz committedNov 14, 2019 Configuration menu - View commit details
-
Copy full SHA for 1f6b520 - Browse repository at this point
Copy the full SHA 1f6b520View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cbd647 - Browse repository at this point
Copy the full SHA 4cbd647View commit details
Commits on Nov 15, 2019
-
Merge branch 'master' of github.com:elastic/kibana into feature-integ…
…rations-manager
John Schulz committedNov 15, 2019 Configuration menu - View commit details
-
Copy full SHA for 505ef0d - Browse repository at this point
Copy the full SHA 505ef0dView commit details -
Add fix & comment for TS 3.7.2 regression
John Schulz committedNov 15, 2019 Configuration menu - View commit details
-
Copy full SHA for fc5daa3 - Browse repository at this point
Copy the full SHA fc5daa3View commit details -
Merge branch 'master' of github.com:elastic/kibana into feature-integ…
…rations-manager
John Schulz committedNov 15, 2019 Configuration menu - View commit details
-
Copy full SHA for 14c7655 - Browse repository at this point
Copy the full SHA 14c7655View commit details -
[EPM] cleanup assets, filter assets for those currently supported (#5…
…0609) * cleanup assets, filter assets for those currently supported * removed unused type * fix type * add comment for better type * change type name to be more descriptive
Configuration menu - View commit details
-
Copy full SHA for 435b6b9 - Browse repository at this point
Copy the full SHA 435b6b9View commit details -
Merge branch 'feature-integrations-manager' of github.com:elastic/kib…
…ana into feature-integrations-manager
John Schulz committedNov 15, 2019 Configuration menu - View commit details
-
Copy full SHA for f4fe3ec - Browse repository at this point
Copy the full SHA f4fe3ecView commit details -
hardcode image width for ie11 (#49796)
* hardcode image width for ie11 * eslint * improve comment * add maxWidth
Configuration menu - View commit details
-
Copy full SHA for 7b8e7f5 - Browse repository at this point
Copy the full SHA 7b8e7f5View commit details -
[EPM] useKibana hook & render in plugin.start (#50110)
* plugin.start now does reactdom.render vs returning react element export plugin function from public/index * Move setClient call from plugin.start to plugin.setup * Use `useUiSetting$` from `useKibana` hooks
John Schulz committedNov 15, 2019 Configuration menu - View commit details
-
Copy full SHA for d470bb9 - Browse repository at this point
Copy the full SHA d470bb9View commit details -
Fix broken app due to bad hooks usage
Can't use useKibana outside a React component. Reverting to prior approach since it's still NP. Can revisit context usage in a followup PR
John Schulz committedNov 15, 2019 Configuration menu - View commit details
-
Copy full SHA for 1d8b931 - Browse repository at this point
Copy the full SHA 1d8b931View commit details -
[EPM] Install package from detail view on button click (#50735)
* Support basic "click button -> show spinner -> installed" install flow * Remove incorrect comments. Add TS return types to data functions.
John Schulz committedNov 15, 2019 Configuration menu - View commit details
-
Copy full SHA for e7a7f74 - Browse repository at this point
Copy the full SHA e7a7f74View commit details -
[EPM] Use NP feature_catalogue.register (#50108)
* Use NP feature_catalogue.register * Use type from NP plugin
John Schulz committedNov 15, 2019 Configuration menu - View commit details
-
Copy full SHA for 232347f - Browse repository at this point
Copy the full SHA 232347fView commit details
Commits on Nov 16, 2019
-
Merge branch 'feature-make-it-ingest' of github.com:elastic/kibana in…
…to feature-ingest
Configuration menu - View commit details
-
Copy full SHA for 570c1c7 - Browse repository at this point
Copy the full SHA 570c1c7View commit details -
Merge branch 'feature-integrations-manager' of github.com:elastic/kib…
…ana into feature-ingest
Configuration menu - View commit details
-
Copy full SHA for c7aa2ed - Browse repository at this point
Copy the full SHA c7aa2edView commit details
Commits on Nov 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 536d9f1 - Browse repository at this point
Copy the full SHA 536d9f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0831ef0 - Browse repository at this point
Copy the full SHA 0831ef0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9447054 - Browse repository at this point
Copy the full SHA 9447054View commit details
Commits on Nov 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for d05f20d - Browse repository at this point
Copy the full SHA d05f20dView commit details -
Revert "skipping test due to ES param change"
This reverts commit d05f20d.
Configuration menu - View commit details
-
Copy full SHA for 9fc2f1c - Browse repository at this point
Copy the full SHA 9fc2f1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0571584 - Browse repository at this point
Copy the full SHA 0571584View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8aa89d7 - Browse repository at this point
Copy the full SHA 8aa89d7View commit details
Commits on Nov 19, 2019
-
[EPM] Final(?) update from integrations_manager -> EPM (#50976)
* Update (all remaining?) references from integrations_manager to EPM * Update path in i18n file
John Schulz committedNov 19, 2019 Configuration menu - View commit details
-
Copy full SHA for be9ca17 - Browse repository at this point
Copy the full SHA be9ca17View commit details -
[EPM] update compatibility section (#50975)
* change min max version to single range value * add elastic stack icon and change text * remove badge from version and use code font * remove euistyled * add back version component lost in merge * remove euiStyled * remove old file
Configuration menu - View commit details
-
Copy full SHA for ece3570 - Browse repository at this point
Copy the full SHA ece3570View commit details -
Merge branch 'master' of github.com:elastic/kibana into feature-ingest
John Schulz committedNov 19, 2019 Configuration menu - View commit details
-
Copy full SHA for 646b340 - Browse repository at this point
Copy the full SHA 646b340View commit details -
Restore RequirementVersionRange type
John Schulz committedNov 19, 2019 Configuration menu - View commit details
-
Copy full SHA for 590ccbe - Browse repository at this point
Copy the full SHA 590ccbeView commit details -
Disable test for elasticsearch username.
Temporary work around until we know how the stack wants to add the permissions we need. Either adding to the kibana user or creating a new user.
John Schulz committedNov 19, 2019 Configuration menu - View commit details
-
Copy full SHA for f1020e4 - Browse repository at this point
Copy the full SHA f1020e4View commit details -
Merge branch 'master' of github.com:elastic/kibana into feature-ingest
John Schulz committedNov 19, 2019 Configuration menu - View commit details
-
Copy full SHA for ef97a13 - Browse repository at this point
Copy the full SHA ef97a13View commit details -
Revert "Disable test for elasticsearch username."
This reverts commit f1020e4.
John Schulz committedNov 19, 2019 Configuration menu - View commit details
-
Copy full SHA for 4720fd9 - Browse repository at this point
Copy the full SHA 4720fd9View commit details
Commits on Nov 20, 2019
-
Disable test for elasticsearch username.
Temporary work around until we know how the stack wants to add the permissions we need. Either adding to the kibana user or creating a new user.
Configuration menu - View commit details
-
Copy full SHA for 37dad5c - Browse repository at this point
Copy the full SHA 37dad5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 098c220 - Browse repository at this point
Copy the full SHA 098c220View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c158e5 - Browse repository at this point
Copy the full SHA 9c158e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 229745f - Browse repository at this point
Copy the full SHA 229745fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f68a23 - Browse repository at this point
Copy the full SHA 9f68a23View commit details
Commits on Nov 21, 2019
-
* Initialize es in test. * Add it(), no es.init() * Clean up.
Configuration menu - View commit details
-
Copy full SHA for c1512f8 - Browse repository at this point
Copy the full SHA c1512f8View commit details -
[EPM] add confirmation modal (#51172)
* add confirmation modal, move install state to Header * update callout to use title * move components only used in detail view to detail dir * use better variable names * update to more descriptive variable names
Configuration menu - View commit details
-
Copy full SHA for e373cba - Browse repository at this point
Copy the full SHA e373cbaView commit details -
Restore prior response vaulues for install & delete package (#51252)
Discussed this with @skh #51112 (comment) & #51112 (comment) as well as in a video call Also added some TS type annotations for data fetching functions to make the contracts more explicit
John Schulz committedNov 21, 2019 Configuration menu - View commit details
-
Copy full SHA for 0493795 - Browse repository at this point
Copy the full SHA 0493795View commit details
Commits on Nov 22, 2019
-
[EPM] /package API only lists installable assets. Restore enums. (#51414
) * API only shows installable assets. Server types to own file. Restore enums * Fix type imports * Only return installable asset types (kibana for now) * server/types now only has code from hapi which shouldn't go to client * Add more restricted TS types to DisplayAssets object * Flip order of arguments to Extract In these cases it still works the same, but looking at https://www.typescriptlang.org/docs/handbook/advanced-types.html the signature is `Extract<T, U>` - Extract from `T` those types that are assignable to `U` so the larger set should be first
John Schulz committedNov 22, 2019 Configuration menu - View commit details
-
Copy full SHA for a081bf4 - Browse repository at this point
Copy the full SHA a081bf4View commit details
Commits on Nov 25, 2019
-
Configuration menu - View commit details
-
Copy full SHA for d47ab5d - Browse repository at this point
Copy the full SHA d47ab5dView commit details
Commits on Nov 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ef39895 - Browse repository at this point
Copy the full SHA ef39895View commit details -
[EPM] Add docs entry about registryUrl config (#51697)
This documentation is at the moment mainly for internal use. I found myself searching for this URL several times in the code or PRs so I thought I rather add it to the docs for now.
Configuration menu - View commit details
-
Copy full SHA for 14bbe8e - Browse repository at this point
Copy the full SHA 14bbe8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 399bbd3 - Browse repository at this point
Copy the full SHA 399bbd3View commit details -
[Fleet] Move agent status server side and API to get aggregated statu…
…s for a policy (#51673)
Configuration menu - View commit details
-
Copy full SHA for a860bbd - Browse repository at this point
Copy the full SHA a860bbdView commit details -
[EPM] Add basic docs around install/delete API endpoint (#51728)
This is mainly for internal usage at the moment to look up.
Configuration menu - View commit details
-
Copy full SHA for 99ead3d - Browse repository at this point
Copy the full SHA 99ead3dView commit details -
* wip policy * tweaks * tweaks * FIX TYPOS * WIP move policy => agent config conversion to fleet, WIP policy changed method * fix tests and bugs * updates tests and snaps * more fixes * use AGENT_POLLING_INTERVAL * cleanup and fix some formatting * Update x-pack/legacy/plugins/ingest/server/libs/datasources.ts Co-Authored-By: John Schulz <github.com@jfsiii.org> * Update x-pack/legacy/plugins/ingest/server/libs/datasources.ts Co-Authored-By: John Schulz <github.com@jfsiii.org> * Update x-pack/legacy/plugins/ingest/server/libs/outputs.ts Co-Authored-By: John Schulz <github.com@jfsiii.org> * Update x-pack/legacy/plugins/fleet/server/libs/policy.ts Co-Authored-By: John Schulz <github.com@jfsiii.org> * fix things broken by PR review suggestions * remove unused field * fix types * fix mappings * add datasource mappings * Fix mappings and remove get full policy from checkin * Fix ingest api integration tests
Configuration menu - View commit details
-
Copy full SHA for 1a05deb - Browse repository at this point
Copy the full SHA 1a05debView commit details
Commits on Nov 27, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2e3fc27 - Browse repository at this point
Copy the full SHA 2e3fc27View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8a1b22 - Browse repository at this point
Copy the full SHA d8a1b22View commit details -
Configuration menu - View commit details
-
Copy full SHA for d726419 - Browse repository at this point
Copy the full SHA d726419View commit details -
Configuration menu - View commit details
-
Copy full SHA for 171749e - Browse repository at this point
Copy the full SHA 171749eView commit details -
[EPM] Track package install state and add toast notification (#51734)
* add notifications from core to plugin * add package install state hook * fix type error * use toMountPoint helper to add jsx to notification * add warning notification to failed install * make notifications dependency explicit prop * move PackageInstall provider lower * add comment about InstallStatus type overlapping InstallationStatus * use InstallStatus type in InstallationButton component * fix type
Configuration menu - View commit details
-
Copy full SHA for ce760f0 - Browse repository at this point
Copy the full SHA ce760f0View commit details -
[Ingest] Adds support for a working default output (#51841)
* aadding config * add working settings to the default output * remove default username and password * update libs
Matt Apperson committedNov 27, 2019 Configuration menu - View commit details
-
Copy full SHA for ef9bc47 - Browse repository at this point
Copy the full SHA ef9bc47View commit details
Commits on Nov 28, 2019
-
[EPM] Add basics for creating the ILM setup (#50474)
This contains the basic objects to setup ILM * Create index and alias with a write index * Get the policy The code does not contain any functional tests yet as it is still open on how to do it best. I suggest to get this in as a foundation and then iterate on top of it.
Configuration menu - View commit details
-
Copy full SHA for 74d984d - Browse repository at this point
Copy the full SHA 74d984dView commit details -
[EPM] Add datasource (ingest pipeline) from package (#51851)
## Summary This mixes a few concerns but I think it's worth it to show the parts working together. Take a look at the individual commits for a better separation of features. This adds - the `/datasource/install/{pkgkey}` endpoint which installs ingest pipelines from a package into ES and saves a reference to them in the EPM state Saved Object - Connects the "Add datasource" button in the successful installation Toast to the new API - Adds a toast notification to inform the user the datasource was added correctly - Adds a "Delete Package" button on the details page so we can uninstall a package while we're waiting for the separate view which allows deletes - b99eda6 Pushes logic that was in the detail view into `InstallationButton`. This consolidates the logic in one component (or one component & the existing hook) and, iiic, means we can put `<InstallationButton package={...} />` on any view and get the same behavior I'm marking this as a normal PR so people can merge if they wish ![add-datasource-delete-package-small](https://user-images.githubusercontent.com/57655/69775686-7fb39280-1167-11ea-8d41-e2b8a02252a1.gif)
Configuration menu - View commit details
-
Copy full SHA for 38e2e14 - Browse repository at this point
Copy the full SHA 38e2e14View commit details -
[EPM] Add basic processing of fields.yml file (#51148)
The fields.yml is used to generate the Elasticsearch template and Kibana index pattern. This PR adds a very basic implementation of processing the fields.yml and then create an Elasticsearch template out of it. The only fields that are supported at the moment are keyword fields, more will be added as a follow up. The testing was implemented with a golden file. The output from the method is compared to a json file. If the input is changed or the method is changed, it is possible to regenerate the files with the `-generate` flag as following: ``` node scripts/jest ./legacy/plugins/epm/server/lib/template/template.test.ts -generate ``` This will allow us to quickly test many inputs / outputs in the future, make adjustments to the existing files and generate the new outputs. We then can compare it in the diff it the changes make sense.
Configuration menu - View commit details
-
Copy full SHA for 756f4cc - Browse repository at this point
Copy the full SHA 756f4ccView commit details -
[EPM] Create basic implementation to merge input template and dataset…
… manifest (#51803) * [EPM] Create basic implementation to merge input template and dataset manifest With this code it is possible to take an input template for the agent and merge it with the config variables from the dataset manifest file. Currently only the name and the default value are merged. Later on we must implement to be able to pass user configured variables to it and make decision based on OS selection. Closing #51794
Configuration menu - View commit details
-
Copy full SHA for 729488f - Browse repository at this point
Copy the full SHA 729488fView commit details
Commits on Dec 2, 2019
-
[EPM] Refactoring of lib structure (#51885)
This refactors the structure of lib. As so far all the lib parts are related to assets in the package, it is organised the same way with the same structure. Each directory has its own tests directory if it needs one. This makes it possible to (almost) not need relative paths for tests.
Configuration menu - View commit details
-
Copy full SHA for 7771ec2 - Browse repository at this point
Copy the full SHA 7771ec2View commit details -
[EPM] Allow to read files from fields directory (#51958)
This change allows to also extract files from the `fields` directory. Previously this was not possible because it always assumed a service must be there.
Configuration menu - View commit details
-
Copy full SHA for 9a4e9d8 - Browse repository at this point
Copy the full SHA 9a4e9d8View commit details -
[EPM] Install Elasticsearch Index Template for data source (#51878)
This installs the Elasticsearch index template for each dataset in a package. For now the names are hardcoded based on package key and dataset name but will be more dynamic later on when we pass the full dataset information. The dataset extractions is a bit "hacky" at the moment and we should get a full implementation of dataset at a later stage and replace this code.
Configuration menu - View commit details
-
Copy full SHA for dd7473a - Browse repository at this point
Copy the full SHA dd7473aView commit details
Commits on Dec 3, 2019
-
[Fleet] Policy list, details, create, edit UIs (#51950)
* Set up simple policies list view * Adjust spec to return single policy * Set up simple policy details page * Add demo stats/chart to policy details * Add description string * Initial setup of policy form and create policy UI * Policy create/edit form; integrate policy list api * Integrate create policy api * Integrate policy detail, agent status, and policy edit APIs; adjust policy list api integration in agent enrollment * Fix edit policy mock meta * Fix policy list search bar * PR and linting fixes; use typings from ingest plugin * Fix i18n
Configuration menu - View commit details
-
Copy full SHA for 979d2b6 - Browse repository at this point
Copy the full SHA 979d2b6View commit details -
[EPM] Add datasource saved object type (#51871)
## Summary This PR makes a few assumptions, and contains a lot of refactoring. It might be beneficial to look at the resulting directory structure under `server` first to get the (new) big picture. Assumptions: - our API deals with several concerns, for now these are packages and datasources - we manage our own HTTP API endpoints for these concerns (in particular, don't use the ingest plugin for that) - we manage (for now) the Kibana saved object in which datasources are saved. importing and calling methods from the ingest plugin to do that down the road will (hopefully) be a manageable change This led to the following decisions: - the code is separated into subdirectories by concern, containing all the route handlers and tightly coupled code - for now, these directories are in `server/packages` and `server/datasources`. I'm tempted to move them into `server/api/{packages,datasources}` but wanted to limit the amount of refactoring in one PR - shared code lives in `server/lib` - some code from `server/packages` has been almost duplicated to handle saving to Datasource saved objects, some has been refactored and is used from both places. The deduplication needs further improvement - maybe `server/registry` should also move under `server/lib` (but see above, I'm trying to not move everything around all at once) Testing: * Please note that this is a breaking change because the saved object type for package information has also been renamed. You'll need to start with a fresh `.kibana-*` index. Restarting `yarn es snapshot` (withouth specifying a data directory) should do the trick. * Package installation should still work, e.g. with a GET request to `http://localhost:5601/api/epm/package/coredns-1.0.1`. The saved objects for packages can be inspected with a GET request to `http://localhost:5601/api/saved_objects/epm-package/$PKG_KEY`, e.g. `http://localhost:5601/api/saved_objects/epm-package/coredns-1.0.1` * Datasource creation should still work, e.g. with a GET request to `http://localhost:5601/api/epm/datasource/install/coredns-1.0.1`. The saved objects for datasources can be inspected with a GET to `http://localhost:5601/api/saved_objects/epm-datasource/$PKG_KEY`, e.g. `http://localhost:5601/api/saved_objects/epm-datasource/coredns-1.0.1`
Configuration menu - View commit details
-
Copy full SHA for 0eca4db - Browse repository at this point
Copy the full SHA 0eca4dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 677f9ce - Browse repository at this point
Copy the full SHA 677f9ceView commit details
Commits on Dec 4, 2019
-
[EPM] Add /epr prefix to the tar.gz download path (#51881)
The registry slightly changed the .tar.gz path because of download stats reason. This adjusts for it. See elastic/package-registry#169
Configuration menu - View commit details
-
Copy full SHA for 006aeaf - Browse repository at this point
Copy the full SHA 006aeafView commit details -
[EPM] Move template installation to lib and add asset helper (#52049)
* [EPM] Move template installation to lib and add asset helper All the logic related to the installation of the templates for a package should be inside the template library folder. This moves the logic into this folder. A few refactorings were made to simplify installation: * Introduction of DataSet interface: This interface is needed to extract the data sets inside a package and install one template per data set. * Pass package instead of package key to installation process: Passing the package instead of the package key means fetching of package information is decoupled from the installation process and abstracted. This separates the two concerns and should simplify testing. * getAsssets method: The getAssets methods works on top of the package object to extract asset paths. It is inspired by get_objects methods but supports passing a package and a dataset. Currently one problem with testing that exists is that to fetch the content of an asset is not decoupled yet.
Configuration menu - View commit details
-
Copy full SHA for 0c162bc - Browse repository at this point
Copy the full SHA 0c162bcView commit details -
[EPM] Reduce data source to one type (#52061)
Between Fleet / Ingest / EPM there had been several interface definitions of Datasource and the related types. This reduces it to one place for the definition. The same applies to the policy definition. The goal of this is that from now on we all rely on the same definition. If we make changes, we make them in all parts of the code. In this PR is only the minimal change needed to get us all on one interface. Further changes will be needed that we all rely on the same saved objects etc. * add export command * revert 2 more files to rely on export * revert imports * Fix types for Datasource Saved Object * merge in master * fix type check
Configuration menu - View commit details
-
Copy full SHA for 00d55fb - Browse repository at this point
Copy the full SHA 00d55fbView commit details
Commits on Dec 5, 2019
-
Run VSCode's organize imports on EPM files (#52234)
Learned about it on Slack from https://twitter.com/ryanchenkie/status/1201883268527927301 Blog at https://code.visualstudio.com/updates/v1_23#_run-code-actions-on-save Basically does the order we've been loosely following (3rd party, then relative) & alphabetic by location and variable name. It's not customizable but it's reasonable and, afaict, consistent.
Configuration menu - View commit details
-
Copy full SHA for dc088b1 - Browse repository at this point
Copy the full SHA dc088b1View commit details -
[EPM] More realistic datasource SO. Error if package not installed. (#…
…52229) * Move cache 'hack' into getAssetsData * p -> pkg. package is reserved. pkgkey is used in many places * Remove unnecessary type cast * Clarify reasons behind asset path manipulation * Return the Datasource; not the Saved Object. * Use real values from package in fake datasource SO * Error if /datasource/install before /package/install ``` > curl --user elastic:changeme localhost:5601/api/epm/datasource/install/coredns-1.0.1 { "statusCode": 403, "error": "Forbidden", "message": "coredns-1.0.1 is not installed" } > curl --user elastic:changeme localhost:5601/api/epm/install/coredns-1.0.1 [ { "id": "53aa1f70-443e-11e9-8548-ab7fbe04f038", "type": "dashboard" }, { "id": "Metricbeat-CoreDNS-Dashboard-ecs", "type": "dashboard" }, { "id": "75743f70-443c-11e9-8548-ab7fbe04f038", "type": "visualization" }, { "id": "36e08510-53c4-11e9-b466-9be470bbd327-ecs", "type": "visualization" }, { "id": "277fc650-67a9-11e9-a534-715561d0bf42", "type": "visualization" }, { "id": "cfde7fb0-443d-11e9-8548-ab7fbe04f038", "type": "visualization" }, { "id": "a19df590-53c4-11e9-b466-9be470bbd327-ecs", "type": "visualization" }, { "id": "a58345f0-7298-11e9-b0d0-414c3011ddbb", "type": "visualization" }, { "id": "9dc640e0-4432-11e9-8548-ab7fbe04f038", "type": "visualization" }, { "id": "3ad75810-4429-11e9-8548-ab7fbe04f038", "type": "visualization" }, { "id": "57c74300-7308-11e9-b0d0-414c3011ddbb", "type": "visualization" }, { "id": "27da53f0-53d5-11e9-b466-9be470bbd327-ecs", "type": "visualization" }, { "id": "86177430-728d-11e9-b0d0-414c3011ddbb", "type": "visualization" }, { "id": "4804eaa0-7315-11e9-b0d0-414c3011ddbb", "type": "visualization" } ] > curl --user elastic:changeme localhost:5601/api/epm/datasource/install/coredns-1.0.1 [ { "id": "coredns_1_0_1_dataset_log_elasticsearch_ingest_pipeline_pipeline_plaintext_json", "type": "ingest-pipeline" }, { "id": "coredns_1_0_1_dataset_log_elasticsearch_ingest_pipeline_pipeline_json_json", "type": "ingest-pipeline" }, { "id": "coredns_1_0_1_dataset_log_elasticsearch_ingest_pipeline_pipeline_entry_json", "type": "ingest-pipeline" } ] ``` * fix duplicated imports
John Schulz committedDec 5, 2019 Configuration menu - View commit details
-
Copy full SHA for fde70ff - Browse repository at this point
Copy the full SHA fde70ffView commit details -
[EPM] Move golden files generation over to jest snapshot (#52203)
* [EPM] Move golden files generation over to jest snapshot I initially used my own implementation to write the generated files. It runs out jest has a feature to write snapshots which simplifies the code a lot. I added a loop with an additional test file so in the future we can just keep adding test files without having to modify the test code. To updated the snapshots, the param `-u` has to be used: ``` node scripts/jest legacy/plugins/epm/server/lib/fields/field.test.ts -u ```
Configuration menu - View commit details
-
Copy full SHA for 2e230bf - Browse repository at this point
Copy the full SHA 2e230bfView commit details -
[EPM] Create metrics-* and logs-* Kibana index pattern (#52277)
This creates the very basic Kibana index patterns metrics-* and logs-* for Kibana. At the moment it is overwritten every time. We need to change this in the future to take the fields from all installed data sources and regenerate it.
Configuration menu - View commit details
-
Copy full SHA for 4c5b038 - Browse repository at this point
Copy the full SHA 4c5b038View commit details
Commits on Dec 6, 2019
-
[EPM] Create helper for elasticsearch asset names (#52265)
Most of the Elasticsearch assets have the same base name. This creates a helper to get the base name for the assets. In case we decide to change the base name in the future, we can change it in one place. * fix tests and destructing
Configuration menu - View commit details
-
Copy full SHA for 329fff2 - Browse repository at this point
Copy the full SHA 329fff2View commit details
Commits on Dec 7, 2019
-
[EPM] Update Registry types. Prevent errors installing certain dataso…
…urces. (#52285) * Update RegistryPackage type * Use download key from EPR to fetch archive * Fix errors caused by correcting the Registry types. The issues were largely that some Registry types like `title, `datasets` and `assets` where marked as required, but are actually optional. This highlighted area in the code were we relied on them always being present. We added to the issue by wrapping Registry types in `Required` which made those items which were correctly listed as optional, required for EPM code. Updated EPM types to reflect the largely pass-through nature of the EPM types. There are two properties which we ensure are in every EPM response, those were put into their own (unexported) type. Confirm by trying to add a datasource to a package which has no datasources, like apache-1.0.1 or system-2.0.1. In `feature-ingest` and the earlier version of this PR, the `/datasource/install` call returns a 500. In this PR it succeeds.
Configuration menu - View commit details
-
Copy full SHA for af4d6a0 - Browse repository at this point
Copy the full SHA af4d6a0View commit details
Commits on Dec 9, 2019
-
[EPM] Add setup of default ILM policies (#52272)
This creates two ILM policies: logs-default and metrics-default. These are the default ILM policies used. Currently the policy content is hardcoded in the code but should be fetched from the base package in the future. The setup happens as part of the datasource installation. When a data source is installed it is a good time to check if the assets are there but we might extract this to a better place in the future.
Configuration menu - View commit details
-
Copy full SHA for 40c4df8 - Browse repository at this point
Copy the full SHA 40c4df8View commit details -
[EPM] 52075 add data source first page (#52320)
* Update RegistryPackage type * add first page of add data source * fix for ie11 flex min width bug * remove toDetailViewRelative * remove unneeded spread
Configuration menu - View commit details
-
Copy full SHA for 6f91887 - Browse repository at this point
Copy the full SHA 6f91887View commit details -
Update TS type names for EPR search results (#52512)
* `RegistryList -> RegistrySearchResults` * `RegistryListItem -> RegistrySearchResult`
John Schulz committedDec 9, 2019 Configuration menu - View commit details
-
Copy full SHA for f6239e7 - Browse repository at this point
Copy the full SHA f6239e7View commit details -
Restore import sort order from #52234 (#52548)
Many of the changes from #52234 were lost. Presumably due to PR(s) merging which were based on branches which had the previous unsorted order.
John Schulz committedDec 9, 2019 Configuration menu - View commit details
-
Copy full SHA for 71ab5a0 - Browse repository at this point
Copy the full SHA 71ab5a0View commit details
Commits on Dec 10, 2019
-
[EPM] Replace wildcard export (#52554)
* PackageNotInstalledError -> packages/index.ts * pkgToPkgKey -> registry/index.ts (will convert existing `${name}-${version}` instances later) * Replace export * from packages. There's an argument that the import sites should be updated to import from `packages/get`, `packages/install`, etc but that can wait for a later PR.
John Schulz committedDec 10, 2019 Configuration menu - View commit details
-
Copy full SHA for d2c126f - Browse repository at this point
Copy the full SHA d2c126fView commit details -
[EPM] Reduce usage of epm-package SavedObject (#52576)
* Delete existing Installation type. Rename InstallationAttributes to Installation * Reduce usage of EPM SO. Add getInstallation(). Replaced two calls of getInstallationObject() with getInstallation(). Two less places with knowledge of SO internals. Lots of potential improvements for EPM TS types remain (refactoring/removing Installable, etc), but this is a good incremental step, IMO
John Schulz committedDec 10, 2019 Configuration menu - View commit details
-
Copy full SHA for 5b1f7f6 - Browse repository at this point
Copy the full SHA 5b1f7f6View commit details -
[EPM] Fix missing export link (#52628)
Without it, things break. I am surprised CI did not catch this.
Configuration menu - View commit details
-
Copy full SHA for 328474a - Browse repository at this point
Copy the full SHA 328474aView commit details
Commits on Dec 11, 2019
-
[EPM] Cleanup ILM loading (#52632)
Before the check for the ILM policy to exist triggered an exception. With this change it is a normal response also if the policy does not exist yet. A follow up issue will be created in Elasticsearch to get a HEAD request for this available.
Configuration menu - View commit details
-
Copy full SHA for 786e4db - Browse repository at this point
Copy the full SHA 786e4dbView commit details -
[EPM] Switch to staging URL for registry (#52626)
The old cluster with the registry will be removed as soon as this is merged.
Configuration menu - View commit details
-
Copy full SHA for 00b36c4 - Browse repository at this point
Copy the full SHA 00b36c4View commit details -
[EPM] Use Dataset interface to generate template (#52255)
This will make sure we have to pass much feature params and can fully rely on the datasource object to create names for assets.
Configuration menu - View commit details
-
Copy full SHA for 189d375 - Browse repository at this point
Copy the full SHA 189d375View commit details -
Configuration menu - View commit details
-
Copy full SHA for 654bc21 - Browse repository at this point
Copy the full SHA 654bc21View commit details -
[EPM] Data source integration tests (#52542)
* Add fixtures for data source integration test. * Move test setup to beforeEach * Add test for datasource creation * Handle pipelines in yml format. * Make integration test for adding a data source pass.
Configuration menu - View commit details
-
Copy full SHA for fce4f82 - Browse repository at this point
Copy the full SHA fce4f82View commit details -
Configuration menu - View commit details
-
Copy full SHA for b26ba26 - Browse repository at this point
Copy the full SHA b26ba26View commit details -
[EPM] Add Data Source page updates (#52705)
* remove dupe type RegistryPackage * change switches to checkboxes, use datasets to create checkboxes, add some local form state * update types
Configuration menu - View commit details
-
Copy full SHA for 7bb19c5 - Browse repository at this point
Copy the full SHA 7bb19c5View commit details
Commits on Jan 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ecedffb - Browse repository at this point
Copy the full SHA ecedffbView commit details -
[EPM] redirect after package install (#52771)
* add callback after successful installation and redirect * add temp data sources tab content to access add data source page * remove assets tab for mvp * hide data sources link and redirect from data sources tab if package not installed * change callback name * remove commented out assets logic * add redirect to hook * fix type
Configuration menu - View commit details
-
Copy full SHA for 12a2534 - Browse repository at this point
Copy the full SHA 12a2534View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8e0cc1 - Browse repository at this point
Copy the full SHA f8e0cc1View commit details -
Use ingest datasource api (#52964)
Incremental change. Uses HTTP API for datasource creation. Will do follow-up PR which uses JS function instead * Remove duplicate fetchInfo & installTemplates I think this was from a bad merge, but pretty sure we don't want these functions called twice in the same function * WIP. Pushing so others can see * Improve correctness/flexibility of absolute URL * Disable datasource test & template installation
Configuration menu - View commit details
-
Copy full SHA for e4211a7 - Browse repository at this point
Copy the full SHA e4211a7View commit details -
[Ingest] Data source APIs (#52448)
* Clean up ingest imports and remove unneeded mock_spec files * Initial pass at datasources lib and API endpoints * Add add/remove datasource to/from policy API endpoints * Add datasource contract tests and related policy contract tests; update snapshots * Fix tests * Fix tests again * Fix tests 3 * Adjust routes, PR feedback
Configuration menu - View commit details
-
Copy full SHA for 0710ed8 - Browse repository at this point
Copy the full SHA 0710ed8View commit details -
modify epm createDatasource endpoint to use user data (#52971)
* change epm/datasource/install/{pkg} to POST, send user data to endpoint, install pipelines and templates based on user selected datasets * change test to post for installing a datasource * change some names and types around * delete request.headers['transfer-encoding'] being passed through from epm request
Configuration menu - View commit details
-
Copy full SHA for 5b2aca7 - Browse repository at this point
Copy the full SHA 5b2aca7View commit details -
[EPM] Don't share CreateFakeDatasource type (#53068)
It's not shared between client & server so it doesn't need to be in common. Also, it imports server code which would try to bring server types to the client. It's types so they're compiled away but it's important to keep common to what's truly common. Breaking this separation is why we thought enums broke the client. A lint rule just landed in master to prevent this.
Configuration menu - View commit details
-
Copy full SHA for 39878ff - Browse repository at this point
Copy the full SHA 39878ffView commit details -
[EPM] Index template generation fixes (#53104)
* Only add keyword type field to mappings. * Index template installation * Handle empty fields definition files * Re-enable index template installation
Configuration menu - View commit details
-
Copy full SHA for 96ff0ed - Browse repository at this point
Copy the full SHA 96ff0edView commit details -
[Fleet] Assign/Unassign data source from policy UI (#53058)
* Add index files to export various modules; normalize imports * Clean up unused files; extract datasources table component from policy details page * Expose http client to frontend libs; remove unused types; import ES UI's useRequest lib * Adjust shape of rest api adapter interface to better match with rest of kibana; remove unused node adapter; change per_page param to perPage in agent events route * Initial pass at assign data sources flyout * Initial pass at unassigning data sources from policy * Make data sources table searchable by package values * Fix enrollment key lib for rest adapter param changes * Fix imports and types * `yarn.lock` changes after bootstrapping
Configuration menu - View commit details
-
Copy full SHA for a78aaa4 - Browse repository at this point
Copy the full SHA a78aaa4View commit details -
[EPM] Implement getConfig for dataset (#53261)
* [EPM] Implement getConfig for dataset * Implements a getConfig method on a dataset object. * Build the configuration for each dataset in a package. * construct and save streams into datasource saved object
Configuration menu - View commit details
-
Copy full SHA for 9ad1e54 - Browse repository at this point
Copy the full SHA 9ad1e54View commit details -
[EPM] Fix template installation (#53272)
As dataset.package was not set, the installed templates contained undefined in the template name. This changes fixes this.
Configuration menu - View commit details
-
Copy full SHA for be9f0c0 - Browse repository at this point
Copy the full SHA be9f0c0View commit details -
[EM] Refactor ingest pipeline installation (#53309)
* Refactor ingest pipeline installation * Only install index templates for requested datasets * Add index.default_pipeline to index template * Hook up pipeline rewriting * Add correct types.
Configuration menu - View commit details
-
Copy full SHA for dd8846d - Browse repository at this point
Copy the full SHA dd8846dView commit details -
change POST create datasources path (#53165)
* change POST create datasources path * remove pkgkey from params
Configuration menu - View commit details
-
Copy full SHA for 20af911 - Browse repository at this point
Copy the full SHA 20af911View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8474491 - Browse repository at this point
Copy the full SHA 8474491View commit details -
[Ingest] Return associated policy IDs in data source info (#53350)
* Return number of policies from data source, surface in assign data source UI * Update snapshots
Configuration menu - View commit details
-
Copy full SHA for fedfaa9 - Browse repository at this point
Copy the full SHA fedfaa9View commit details -
[EPM]: Assign data source to policy in UI (#53597)
* Let ES generate source ids. Refactor along the way. * Datasource.id isn't optional. It's just missing before we send to Ingest * Delete EPM's mapping of datasources saved object. Ingest handles that. * Keep datasource object-related work in constructDatasource * Move asset installation into own function. Keep entry point high-level. * More descriptive (less ambiguous) names for these two functions * Use enum values from Ingest instead of plain strings * Limit the 'type' key of references to known asset types. * Update variable names to clarify that we're merging arrays of references * Use [].flat instead .reduce + .concat to avoid error on empty arrays. * Pass PackageInfo value directly to component vs pulling off n properties * Name handlers/options based on the data, not the UI element * Populate policy combo box based on values from Ingest policy API * Mark Dataset.vars as optional. * Add TODOs
Configuration menu - View commit details
-
Copy full SHA for 1a55633 - Browse repository at this point
Copy the full SHA 1a55633View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bbf5ac - Browse repository at this point
Copy the full SHA 6bbf5acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 054c311 - Browse repository at this point
Copy the full SHA 054c311View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f0d7ca - Browse repository at this point
Copy the full SHA 0f0d7caView commit details
Commits on Jan 3, 2020
-
[Fleet] Code in 'common' directories shouldn't import server code (#5…
…3938) * [Fleet] Remove server code from common folder in fleet * [Fleet] Fix typescript issues after master merge * [EPM] Fix typescript issues after master merge
Configuration menu - View commit details
-
Copy full SHA for 1a35843 - Browse repository at this point
Copy the full SHA 1a35843View commit details -
Configuration menu - View commit details
-
Copy full SHA for cda20be - Browse repository at this point
Copy the full SHA cda20beView commit details -
Configuration menu - View commit details
-
Copy full SHA for b852594 - Browse repository at this point
Copy the full SHA b852594View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed44d98 - Browse repository at this point
Copy the full SHA ed44d98View commit details
Commits on Jan 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b7da72c - Browse repository at this point
Copy the full SHA b7da72cView commit details -
Configuration menu - View commit details
-
Copy full SHA for becd154 - Browse repository at this point
Copy the full SHA becd154View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb42f9c - Browse repository at this point
Copy the full SHA bb42f9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17c8e99 - Browse repository at this point
Copy the full SHA 17c8e99View commit details
Commits on Jan 7, 2020
-
[Fleet] Fix registration of Ingest management section (#54065)
* Fix registration of Ingest management section * Fix i18n key
Configuration menu - View commit details
-
Copy full SHA for 19fb164 - Browse repository at this point
Copy the full SHA 19fb164View commit details -
Configuration menu - View commit details
-
Copy full SHA for c154afc - Browse repository at this point
Copy the full SHA c154afcView commit details -
[Fleet] Connect fleet to policy change update (#53201)
* [Fleet] Send created event when a policy is created * [Fleet] updated created event when a policy is created * [Fleet] Send deleted event when a policy is deleted
Configuration menu - View commit details
-
Copy full SHA for 50fde69 - Browse repository at this point
Copy the full SHA 50fde69View commit details
Commits on Jan 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for cb3ce1c - Browse repository at this point
Copy the full SHA cb3ce1cView commit details -
[Ingest] Remove policies UI (#54308)
* Remove meta field UI from policy add/edit form * Initial pass at policy bulk+single delete UI and API * Adjust policy links from agent list and detail pages so that links are only active if policy exists * Add delete policy UI to policy detail page * Disable policy delete button for default policy
Configuration menu - View commit details
-
Copy full SHA for 38ca8c1 - Browse repository at this point
Copy the full SHA 38ca8c1View commit details -
Merge branch 'master' of github.com:elastic/kibana into feature-ingest
John Schulz committedJan 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 54fa272 - Browse repository at this point
Copy the full SHA 54fa272View commit details -
Commit updated kbn-pm artifact.
CI is failing with messages like 14:52:28 ERROR: 'yarn kbn run build -i @kbn/pm' caused changes to the following files: 14:52:28 14:52:28 packages/kbn-pm/dist/index.js Following advice from https://elastic.slack.com/archives/C0D8P2XK5/p1570032166063400 and running/committing build
John Schulz committedJan 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 11bbd8c - Browse repository at this point
Copy the full SHA 11bbd8cView commit details -
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Tyler Smalley committedJan 9, 2020 Configuration menu - View commit details
-
Copy full SHA for c8f3fa8 - Browse repository at this point
Copy the full SHA c8f3fa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ecace7 - Browse repository at this point
Copy the full SHA 1ecace7View commit details -
[EPM] create logs metrics index patterns (#54037)
* fixes bug in for loop returning too early and not looping through all yaml files creating incomplete index template, move loading yaml files to own function, other cleanup * use reduce in place of for loop * basic functionality for creating index patterns * separate logs and metrics index patterns * dedupe fields * adjust flattenFields to rename nested fields with parent name path * some tests * use yml files for tests * add awaits as part of installing the package * optimize loading of yaml files * fix typo * change type packageName to package * update tests to use all files from the beginning * fix type errors * fix test
Configuration menu - View commit details
-
Copy full SHA for 5791fbc - Browse repository at this point
Copy the full SHA 5791fbcView commit details
Commits on Jan 10, 2020
-
Merge branch 'master' of github.com:elastic/kibana into feature-ingest
John Schulz committedJan 10, 2020 Configuration menu - View commit details
-
Copy full SHA for a50b11a - Browse repository at this point
Copy the full SHA a50b11aView commit details -
Merge branch 'feature-ingest' of github.com:elastic/kibana into featu…
…re-ingest
John Schulz committedJan 10, 2020 Configuration menu - View commit details
-
Copy full SHA for eccf88e - Browse repository at this point
Copy the full SHA eccf88eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0393fea - Browse repository at this point
Copy the full SHA 0393feaView commit details -
Form validation on add datasource page. (#53920)
John Schulz committedJan 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 08d1df5 - Browse repository at this point
Copy the full SHA 08d1df5View commit details -
[Ingest] Add support for policy
label
field (#54413)* Allow `label` field in policy APIs, update UIs to support `label` field * PR review changes, typo fixes, update tests
Configuration menu - View commit details
-
Copy full SHA for 43d9cca - Browse repository at this point
Copy the full SHA 43d9ccaView commit details
Commits on Jan 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c69724d - Browse repository at this point
Copy the full SHA c69724dView commit details
Commits on Jan 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1bbbfec - Browse repository at this point
Copy the full SHA 1bbbfecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8452df6 - Browse repository at this point
Copy the full SHA 8452df6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fc063f - Browse repository at this point
Copy the full SHA 8fc063fView commit details
Commits on Jan 16, 2020
-
[EPM] update index pattern fields (#54862)
* add DatasetType type * move loadFieldsFromYaml to fields * add logic to determine field values * update tests * add back accidentally removed readFromDocValues * remove DatasetType and add IndexPatternType * rename dedup to dedupe * group tests * use null coalescing operator
Configuration menu - View commit details
-
Copy full SHA for 3f87c31 - Browse repository at this point
Copy the full SHA 3f87c31View commit details -
Merge branch 'master' of github.com:elastic/kibana into feature-ingest
John Schulz committedJan 16, 2020 Configuration menu - View commit details
-
Copy full SHA for 71c3f46 - Browse repository at this point
Copy the full SHA 71c3f46View commit details
Commits on Jan 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f93e4f8 - Browse repository at this point
Copy the full SHA f93e4f8View commit details
Commits on Jan 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7018ac9 - Browse repository at this point
Copy the full SHA 7018ac9View commit details
Commits on Jan 21, 2020
-
[EPM] Prevent double submit when creating data sources
Update installationRequested state after submit (#55100)
John Schulz committedJan 21, 2020 Configuration menu - View commit details
-
Copy full SHA for 60cc144 - Browse repository at this point
Copy the full SHA 60cc144View commit details
Commits on Jan 22, 2020
-
[EPM] handle alias fields when creating kibana index pattern (#55254)
* add alias support, update flattenFields to handle alias copying, update and add tests * update snapshot * update findFieldByPath to return undefined if not leaf node * remove temporary alias type from map
Configuration menu - View commit details
-
Copy full SHA for 7d24bfd - Browse repository at this point
Copy the full SHA 7d24bfdView commit details -
[EPM] handle multi fields when creating index patterns (#55554)
* handle mult_fields * move nested function out
Configuration menu - View commit details
-
Copy full SHA for 439b740 - Browse repository at this point
Copy the full SHA 439b740View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc98087 - Browse repository at this point
Copy the full SHA bc98087View commit details
Commits on Jan 23, 2020
-
[EPM] Start to document definitions (#55361)
This is a first stab at creating a place where we define the terms we use across ingest management. This is not complete but defines a place where we can add all the future defintions.
Configuration menu - View commit details
-
Copy full SHA for 8acca30 - Browse repository at this point
Copy the full SHA 8acca30View commit details -
[EPM] Indexing strategy docs (#55301)
* [EPM] Indexing strategy docs This documentation is to start documenting our new indexing strategy in a public place and have it versioned. This will allow us to share the current state of the indexing strategy more easily in a single place, track it when updated and also already have it ready for our future users to look it up and understand the benefits of it. * update typos * fix one more typo * apply review feedback
Configuration menu - View commit details
-
Copy full SHA for 3f0bd56 - Browse repository at this point
Copy the full SHA 3f0bd56View commit details
Commits on Jan 24, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7599709 - Browse repository at this point
Copy the full SHA 7599709View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e4b13d - Browse repository at this point
Copy the full SHA 0e4b13dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0d496a - Browse repository at this point
Copy the full SHA c0d496aView commit details
Commits on Jan 27, 2020
-
[EPM] Create fieldFormatMap in kibana index pattern (#55892)
* add support for fieldFormatMap * output params must be camel case * fix case * add url_template param
Configuration menu - View commit details
-
Copy full SHA for 1f78f61 - Browse repository at this point
Copy the full SHA 1f78f61View commit details
Commits on Jan 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c0e3f31 - Browse repository at this point
Copy the full SHA c0e3f31View commit details -
[EPM] Document package upgrade behaviour (#56138)
This PR adds more detailed documentation on what should happen when a package is upgraded.
Configuration menu - View commit details
-
Copy full SHA for 5f4baeb - Browse repository at this point
Copy the full SHA 5f4baebView commit details
Commits on Jan 30, 2020
-
Merge branch 'master' of github.com:elastic/kibana into feature-ingest
John Schulz committedJan 30, 2020 Configuration menu - View commit details
-
Copy full SHA for b589070 - Browse repository at this point
Copy the full SHA b589070View commit details -
Remove some explicit typing to pass type checks.
This abstraction will be removed in the single plugin going into master.
John Schulz committedJan 30, 2020 Configuration menu - View commit details
-
Copy full SHA for b318bea - Browse repository at this point
Copy the full SHA b318beaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e11bad - Browse repository at this point
Copy the full SHA 8e11badView commit details -
Add symlink to yarn.lock to fix(?) CI
https://github.com/elastic/kibana/pull/56443/checks?check_run_id=418123781 failed saying EPM directory "MUST have a 'yarn.lock' symlink" Seems to have originated with #55440 Following example from other legacy/plugins/* in that PR
John Schulz committedJan 30, 2020 Configuration menu - View commit details
-
Copy full SHA for 441d9ed - Browse repository at this point
Copy the full SHA 441d9edView commit details -
John Schulz committed
Jan 30, 2020 Configuration menu - View commit details
-
Copy full SHA for 9200ac2 - Browse repository at this point
Copy the full SHA 9200ac2View commit details
Commits on Jan 31, 2020
-
Merge branch 'feature-ingest' of github.com:elastic/kibana into featu…
…re-ingest
John Schulz committedJan 31, 2020 Configuration menu - View commit details
-
Copy full SHA for 9925179 - Browse repository at this point
Copy the full SHA 9925179View commit details -
[Ingest] Convert
ingest
plugin to new platformingest_manager
plu……gin (#56262) * Seed Ingest Manager as a new NP plugin * Add contexts for core, deps, and config. Begin routing and nav UI * Export NP ready request from top-level es_ui_shared/public/ * Add nav styling w/ theming, add useRequest hook * Set up license and config server-side services; add test routes * Move most types and constants into /common * Initial pass at: * data stream and agent config models * data stream routes and schemas * Initial pass at agent config api route handlers * Change plugin id to camel case * Fix circular schema dependency, add security as optional plugin * Create appContext service, use request user info in agent config routes + libs * Create default agent config * Add default output host config, output typings, and create default output and its api key * Move saved object mapping to new plugin * Change data streams -> datasources * Add legacy plugin to bootstrap mappings * Adjust fleet's ingest dependencies * Disable policies UI in Fleet * Adjust EPM's ingest dependencies * Adjust ingest manager base API route * Adjust fleet's client side ingest dependencies * Remove more ingest dependencies from fleet * REMOVE MOST OF LEGACY INGEST PLUGIN * Add section for agent configs in UI nav * Allow useRequest and sendRequest consumers to specify typing for response * Initial pass at porting over agent config list UI * Port over agent config creation * Port over delete agent config functionality * Fix app routing * Port over fleet setup routes * Adjust fleet's ingest dependencies * Make fleet happy path work, skip some tests (MESSY! :)) * Remove policy list UI code from fleet * Change useRequestResponse error type * Add missing agent config schemas and hooks * Fix type check issues * Register IM under management * Fix type issues as a result of changes to use/sendRequest interfaces * Make all ingest saved objects *not* space-aware * Fix i18n path * Fix app categories import * Fix datasource package assets schema (array of asset objects) * Seed Ingest Manager privileges to fix tests * Change `features` to optional plugin instead of required * Fix security privileges tests * Fix feature test * Fix duplicate enrollment key created for default agent config * Fix fleet agent enrollment by catching agent config 404 * PR feedback
Configuration menu - View commit details
-
Copy full SHA for c66e5ee - Browse repository at this point
Copy the full SHA c66e5eeView commit details
Commits on Feb 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a75cc23 - Browse repository at this point
Copy the full SHA a75cc23View commit details
Commits on Feb 4, 2020
-
[EPM] update index patterns on install/uninstall of package (#56591)
* create index patterns functionality on install/uninstall of package * update snapshots
Configuration menu - View commit details
-
Copy full SHA for ef8ddc5 - Browse repository at this point
Copy the full SHA ef8ddc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for fba1137 - Browse repository at this point
Copy the full SHA fba1137View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ba7763 - Browse repository at this point
Copy the full SHA 0ba7763View commit details
Commits on Feb 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 34bceed - Browse repository at this point
Copy the full SHA 34bceedView commit details
Commits on Feb 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a5c95fe - Browse repository at this point
Copy the full SHA a5c95feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7566b15 - Browse repository at this point
Copy the full SHA 7566b15View commit details -
Configuration menu - View commit details
-
Copy full SHA for c126dd4 - Browse repository at this point
Copy the full SHA c126dd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d72a57f - Browse repository at this point
Copy the full SHA d72a57fView commit details
Commits on Feb 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b359206 - Browse repository at this point
Copy the full SHA b359206View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c7e288 - Browse repository at this point
Copy the full SHA 0c7e288View commit details
Commits on Feb 10, 2020
-
[EPM] NP Migration: Move server files and route handlers to ingest_ma…
…nager (#56854) * initial pass moving registry and categories endpoint * moves all needed server files and gets list endpoint working * add route list validation schema * remove epm config * use config to get the registryUrl * clean up registry url * gets file endpoint working * add info endpoint * get install package endpoint working * support uninstall package endpoint * add API response types * move epm types to models * move AssetType to IngestAsset type from ingest plugin * remove redundant export * update epm_api_integration tests to new endpoint paths in ingest manager
Configuration menu - View commit details
-
Copy full SHA for 76f4da0 - Browse repository at this point
Copy the full SHA 76f4da0View commit details
Commits on Feb 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a8c221b - Browse repository at this point
Copy the full SHA a8c221bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83bc198 - Browse repository at this point
Copy the full SHA 83bc198View commit details
Commits on Feb 12, 2020
-
[Ingest Management] Change indexing from {type}-{namespace}-{dataset}…
… to {type}-{dataset}-{namespace} (#56132) Currently we have the indexing strategy defined as `{type}-{namespace}-{dataset}`. In this PR I propose to change this to `{type}-{dataset}-{namespace}`. As all 3 fields are constant keyword fields, the orders does not matter in most cases. The reason I propose this change is to better align the name of indices with the name of the other assets: * ingest pipeline: {type}-{dataset} * index template: {type}-{dataset} * Index pattern: {type}-{dataset}-* * alias name: {type}-{dataset}-{namespace} This makes it easier to remember the asset names conventions (at least for me). It makes a difference when specifying security per namespace: To lock down security, previously it is `/(logs|metrics)-prod-$/` and becomes `/(logs|metrics)-[^-]+-prod-$/`. In any case, we should help / assist the user to get this right.
Configuration menu - View commit details
-
Copy full SHA for 6eecfa4 - Browse repository at this point
Copy the full SHA 6eecfa4View commit details -
[EPM] Remove epm plugin and directory (#57309)
* delete server files, move over epm saved object schemas and mapping, stop epm plugin loading in xpack * updated yarn * change to updated name * remove epm dir, copy readme to ingest_manager * move package.json over and update yarn.lock * update package name * add yarn.lock symlink * fix yarn.lock symlink * remove epm from security privileges map * remove epm from feature endpoint and i18nrc
Configuration menu - View commit details
-
Copy full SHA for adff25f - Browse repository at this point
Copy the full SHA adff25fView commit details
Commits on Feb 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 491ee28 - Browse repository at this point
Copy the full SHA 491ee28View commit details
Commits on Feb 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 6e00b53 - Browse repository at this point
Copy the full SHA 6e00b53View commit details
Commits on Feb 18, 2020
-
[EPM] EPM to new plugin, UI part (#56882)
* Move EPM home / list view over to ingest-manager * Use react-router-dom in epm section. * WIP: add package detail view. * Use correct route. * Only import needed types to public * Remove obsolete file. * Import type correctly * Revert "Remove obsolete file." This reverts commit 4b06110. * Routes are still needed, fix them. * Import types correctly * More type import fixes. * update get categories hook * remove no longer used getCategories function * get list packages hook working * delete routes.tsx, cleanup links * add the usePackageInstall hook * replace rest of api calls with use/send request * remove tmp_routes * bring over breadcrumbs * remove comments and get styles working * get ride side col loading * temp type fix * remove useCore * add assets * remove comment * add public directory to legacy ingest_manager and update asset path * Fix PackageInfo type. Use for API & UI vs a saved object type. The `as PackageInfo` cast was required because the pipeline was typed as returning `Installed | NotInstalled` which are saved object response. Updating that to PackageInfo allows the `as` to be removed but revealed an incompatibility between the `assets` properties of RegistryPackage and PackageInfo ``` Types of property 'assets' are incompatible. Type 'Record<"kibana", Record<KibanaAssetType, KibanaAssetParts[]>>' is missing the following properties from type 'string[]': length, pop, push, concat, and 28 more. ``` It seems the `RegistryPackage & PackageAdditions` didn't cause the PackageAdditions.assets to replace the RegistryPackage.assets property. I changed the definition of PackageInfo to do what I initially thought it was doing. See comments in models/epm.ts for more about how the new type is constructed. * remove comment * fix paths * fix public paths * fix path * remove ui types file * fix types Co-authored-by: Sandra Gonzales <neptunian@users.noreply.github.com> Co-authored-by: John Schulz <github.com@jfsiii.org>
Configuration menu - View commit details
-
Copy full SHA for ac05485 - Browse repository at this point
Copy the full SHA ac05485View commit details
Commits on Feb 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5adbdc7 - Browse repository at this point
Copy the full SHA 5adbdc7View commit details -
Merge branch 'master' into feature-ingest
`yarn start --no-base-path --xpack.ingestManager.enabled=true --xpack.ingestManager.epm.enabled=true --xpack.ingestManager.fleet.enabled=true` builds but type check fails: ``` ± ~/work/kibana [feature-ingest @ ac05485] ✗ ‣ node scripts/type_check.js --project x-pack/tsconfig.json ✖ x-pack ERROR x-pack failed x-pack/plugins/ingest_manager/server/routes/agent/handlers.ts:36:7 - error TS2322: Type '{ status: AgentStatus; type: AgentTypeSchema; active: boolean; enrolled_at: string; user_provided_metadata: Record<string, string>; local_metadata: Record<...>; ... 9 more ...; access_api_key?: string | undefined; }' is not assignable to type 'Readonly<{ id: string; user_provided_metadata: Record<string, string>; local_metadata: Record<string, string>; access_api_key: string | undefined; status: string | undefined; ... 10 more ...; current_error_events: Readonly<...>[]; }>'. Property 'access_api_key' is optional in type '{ status: AgentStatus; type: AgentTypeSchema; active: boolean; enrolled_at: string; user_provided_metadata: Record<string, string>; local_metadata: Record<...>; ... 9 more ...; access_api_key?: string | undefined; }' but required in type 'Readonly<{ id: string; user_provided_metadata: Record<string, string>; local_metadata: Record<string, string>; access_api_key: string | undefined; status: string | undefined; ... 10 more ...; current_error_events: Readonly<...>[]; }>'. 36 item: { ~~~~ x-pack/plugins/ingest_manager/server/types/rest_spec/agent.ts:34:3 34 item: Agent; ~~~~ The expected type comes from property 'item' which is declared here on type 'GetOneAgentResponse' x-pack/plugins/ingest_manager/server/routes/agent/handlers.ts:72:7 - error TS2322: Type 'AgentEventBase[]' is not assignable to type 'Readonly<{ type: "STATE" | "ERROR" | "ACTION_RESULT" | "ACTION"; subtype: "RUNNING" | "STARTING" | "IN_PROGRESS" | "CONFIG" | "FAILED" | "STOPPED" | "DATA_DUMP" | "STOPPING" | "ACKNOWLEDGED" | "UNKNOWN"; ... 6 more ...; stream_id: string | undefined; }>[]'. Type 'AgentEventBase' is not assignable to type 'Readonly<{ type: "STATE" | "ERROR" | "ACTION_RESULT" | "ACTION"; subtype: "RUNNING" | "STARTING" | "IN_PROGRESS" | "CONFIG" | "FAILED" | "STOPPED" | "DATA_DUMP" | "STOPPING" | "ACKNOWLEDGED" | "UNKNOWN"; ... 6 more ...; stream_id: string | undefined; }>'. Property 'payload' is optional in type 'AgentEventBase' but required in type 'Readonly<{ type: "STATE" | "ERROR" | "ACTION_RESULT" | "ACTION"; subtype: "RUNNING" | "STARTING" | "IN_PROGRESS" | "CONFIG" | "FAILED" | "STOPPED" | "DATA_DUMP" | "STOPPING" | "ACKNOWLEDGED" | "UNKNOWN"; ... 6 more ...; stream_id: string | undefined; }>'. 72 list: items, ~~~~ x-pack/plugins/ingest_manager/server/types/rest_spec/agent.ts:101:3 101 list: AgentEvent[]; ~~~~ The expected type comes from property 'list' which is declared here on type 'GetOneAgentEventsResponse' x-pack/plugins/ingest_manager/server/routes/agent/handlers.ts:310:7 - error TS2322: Type '{ status: AgentStatus; type: AgentTypeSchema; active: boolean; enrolled_at: string; user_provided_metadata: Record<string, string>; local_metadata: Record<...>; ... 9 more ...; access_api_key?: string | undefined; }[]' is not assignable to type 'Readonly<{ id: string; user_provided_metadata: Record<string, string>; local_metadata: Record<string, string>; access_api_key: string | undefined; status: string | undefined; ... 10 more ...; current_error_events: Readonly<...>[]; }>[]'. Type '{ status: AgentStatus; type: AgentTypeSchema; active: boolean; enrolled_at: string; user_provided_metadata: Record<string, string>; local_metadata: Record<...>; ... 9 more ...; access_api_key?: string | undefined; }' is not assignable to type 'Readonly<{ id: string; user_provided_metadata: Record<string, string>; local_metadata: Record<string, string>; access_api_key: string | undefined; status: string | undefined; ... 10 more ...; current_error_events: Readonly<...>[]; }>'. Property 'access_api_key' is optional in type '{ status: AgentStatus; type: AgentTypeSchema; active: boolean; enrolled_at: string; user_provided_metadata: Record<string, string>; local_metadata: Record<...>; ... 9 more ...; access_api_key?: string | undefined; }' but required in type 'Readonly<{ id: string; user_provided_metadata: Record<string, string>; local_metadata: Record<string, string>; access_api_key: string | undefined; status: string | undefined; ... 10 more ...; current_error_events: Readonly<...>[]; }>'. 310 list: agents.map(agent => ({ ~~~~ x-pack/plugins/ingest_manager/server/types/rest_spec/agent.ts:20:3 20 list: Agent[]; ~~~~ The expected type comes from property 'list' which is declared here on type 'GetAgentsResponse' x-pack/plugins/ingest_manager/server/routes/agent_config/handlers.ts:30:7 - error TS2322: Type 'AgentConfigSchema[]' is not assignable to type 'Readonly<{ id: string; status: AgentConfigStatus; datasources: string[] | Readonly<{ id: string; name: string; namespace: string | undefined; read_alias: string | undefined; agent_config_id: string; package: Readonly<...> | undefined; streams: Readonly<...>[]; }>[]; ... 4 more ...; description: string | undefined; }...'. Type 'AgentConfigSchema' is not assignable to type 'Readonly<{ id: string; status: AgentConfigStatus; datasources: string[] | Readonly<{ id: string; name: string; namespace: string | undefined; read_alias: string | undefined; agent_config_id: string; package: Readonly<...> | undefined; streams: Readonly<...>[]; }>[]; ... 4 more ...; description: string | undefined; }>'. Types of property 'datasources' are incompatible. Type '(string | DatasourceSchema)[]' is not assignable to type 'string[] | Readonly<{ id: string; name: string; namespace: string | undefined; read_alias: string | undefined; agent_config_id: string; package: Readonly<{ assets: Readonly<{ id: string; type: string; }>[]; description: string; name: string; title: string; version: string; }> | undefined; streams: Readonly<...>[]; }...'. Type '(string | DatasourceSchema)[]' is not assignable to type 'string[]'. Type 'string | DatasourceSchema' is not assignable to type 'string'. Type 'DatasourceSchema' is not assignable to type 'string'. 30 items, ~~~~~ x-pack/plugins/ingest_manager/server/types/rest_spec/agent_config.ts:15:3 15 items: AgentConfig[]; ~~~~~ The expected type comes from property 'items' which is declared here on type 'GetAgentConfigsResponse' x-pack/plugins/ingest_manager/server/routes/agent_config/handlers.ts:53:9 - error TS2322: Type 'AgentConfigSchema' is not assignable to type 'Readonly<{ id: string; status: AgentConfigStatus; datasources: string[] | Readonly<{ id: string; name: string; namespace: string | undefined; read_alias: string | undefined; agent_config_id: string; package: Readonly<...> | undefined; streams: Readonly<...>[]; }>[]; ... 4 more ...; description: string | undefined; }>'. 53 item: agentConfig, ~~~~ x-pack/plugins/ingest_manager/server/types/rest_spec/agent_config.ts:29:3 29 item: AgentConfig; ~~~~ The expected type comes from property 'item' which is declared here on type 'GetOneAgentConfigResponse' x-pack/plugins/ingest_manager/server/routes/agent_config/handlers.ts:84:47 - error TS2322: Type 'AgentConfigSchema' is not assignable to type 'Readonly<{ id: string; status: AgentConfigStatus; datasources: string[] | Readonly<{ id: string; name: string; namespace: string | undefined; read_alias: string | undefined; agent_config_id: string; package: Readonly<...> | undefined; streams: Readonly<...>[]; }>[]; ... 4 more ...; description: string | undefined; }>'. 84 const body: CreateAgentConfigResponse = { item: agentConfig, success: true }; ~~~~ x-pack/plugins/ingest_manager/server/types/rest_spec/agent_config.ts:38:3 38 item: AgentConfig; ~~~~ The expected type comes from property 'item' which is declared here on type 'CreateAgentConfigResponse' x-pack/plugins/ingest_manager/server/routes/agent_config/handlers.ts:112:47 - error TS2322: Type 'AgentConfigSchema' is not assignable to type 'Readonly<{ id: string; status: AgentConfigStatus; datasources: string[] | Readonly<{ id: string; name: string; namespace: string | undefined; read_alias: string | undefined; agent_config_id: string; package: Readonly<...> | undefined; streams: Readonly<...>[]; }>[]; ... 4 more ...; description: string | undefined; }>'. 112 const body: UpdateAgentConfigResponse = { item: agentConfig, success: true }; ~~~~ x-pack/plugins/ingest_manager/server/types/rest_spec/agent_config.ts:48:3 48 item: AgentConfig; ~~~~ The expected type comes from property 'item' which is declared here on type 'UpdateAgentConfigResponse' x-pack/plugins/ingest_manager/server/services/agents/acks.ts:26:5 - error TS2322: Type 'AgentActionBaseSchema[]' is not assignable to type 'Readonly<{ type: "POLICY_CHANGE" | "DATA_DUMP" | "RESUME" | "PAUSE"; id: string; created_at: string; data: string | undefined; sent_at: string | undefined; }>[]'. Type 'AgentActionBaseSchema' is not assignable to type 'Readonly<{ type: "POLICY_CHANGE" | "DATA_DUMP" | "RESUME" | "PAUSE"; id: string; created_at: string; data: string | undefined; sent_at: string | undefined; }>'. Property 'data' is optional in type 'AgentActionBaseSchema' but required in type 'Readonly<{ type: "POLICY_CHANGE" | "DATA_DUMP" | "RESUME" | "PAUSE"; id: string; created_at: string; data: string | undefined; sent_at: string | undefined; }>'. 26 actions: updatedActions, ~~~~~~~ x-pack/plugins/ingest_manager/server/types/models/agent.ts:92:3 92 actions: schema.arrayOf(AgentActionSchema), ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The expected type comes from property 'actions' which is declared here on type 'Partial<Readonly<{ user_provided_metadata: string; local_metadata: string; current_error_events: string | undefined; type: AgentTypeSchema; active: boolean; enrolled_at: string; ... 6 more ...; actions: Readonly<...>[]; }>>' x-pack/plugins/ingest_manager/server/services/agents/checkin.ts:75:79 - error TS2345: Argument of type '{ last_checkin: string; default_api_key?: string | undefined; actions?: AgentActionBaseSchema[] | undefined; local_metadata?: string | undefined; current_error_events?: string | undefined; }' is not assignable to parameter of type 'Partial<Readonly<{ user_provided_metadata: string; local_metadata: string; current_error_events: string | undefined; type: AgentTypeSchema; active: boolean; enrolled_at: string; ... 6 more ...; actions: Readonly<...>[]; }>>'. Types of property 'actions' are incompatible. Type 'AgentActionBaseSchema[] | undefined' is not assignable to type 'Readonly<{ type: "POLICY_CHANGE" | "DATA_DUMP" | "RESUME" | "PAUSE"; id: string; created_at: string; data: string | undefined; sent_at: string | undefined; }>[] | undefined'. Type 'AgentActionBaseSchema[]' is not assignable to type 'Readonly<{ type: "POLICY_CHANGE" | "DATA_DUMP" | "RESUME" | "PAUSE"; id: string; created_at: string; data: string | undefined; sent_at: string | undefined; }>[]'. 75 await soClient.update<AgentSOAttributes>(AGENT_SAVED_OBJECT_TYPE, agent.id, updateData); ~~~~~~~~~~ x-pack/plugins/ingest_manager/server/services/agents/checkin.ts:122:9 - error TS2322: Type '{ attributes: { payload: string | undefined; type: "STATE" | "ERROR" | "ACTION_RESULT" | "ACTION"; subtype: "RUNNING" | "STARTING" | "IN_PROGRESS" | "CONFIG" | "FAILED" | "STOPPED" | "DATA_DUMP" | "STOPPING" | "ACKNOWLEDGED" | "UNKNOWN"; ... 6 more ...; agent_id: string; }; type: string; }[]' is not assignable to type 'SavedObjectsBulkCreateObject<Readonly<{ type: "STATE" | "ERROR" | "ACTION_RESULT" | "ACTION"; subtype: "RUNNING" | "STARTING" | "IN_PROGRESS" | "CONFIG" | "FAILED" | "STOPPED" | "DATA_DUMP" | "STOPPING" | "ACKNOWLEDGED" | "UNKNOWN"; ... 6 more ...; stream_id: string | undefined; }>>[]'. Type '{ attributes: { payload: string | undefined; type: "STATE" | "ERROR" | "ACTION_RESULT" | "ACTION"; subtype: "RUNNING" | "STARTING" | "IN_PROGRESS" | "CONFIG" | "FAILED" | "STOPPED" | "DATA_DUMP" | "STOPPING" | "ACKNOWLEDGED" | "UNKNOWN"; ... 6 more ...; agent_id: string; }; type: string; }' is not assignable to type 'SavedObjectsBulkCreateObject<Readonly<{ type: "STATE" | "ERROR" | "ACTION_RESULT" | "ACTION"; subtype: "RUNNING" | "STARTING" | "IN_PROGRESS" | "CONFIG" | "FAILED" | "STOPPED" | "DATA_DUMP" | "STOPPING" | "ACKNOWLEDGED" | "UNKNOWN"; ... 6 more ...; stream_id: string | undefined; }>>'. Types of property 'attributes' are incompatible. Type '{ payload: string | undefined; type: "STATE" | "ERROR" | "ACTION_RESULT" | "ACTION"; subtype: "RUNNING" | "STARTING" | "IN_PROGRESS" | "CONFIG" | "FAILED" | "STOPPED" | "DATA_DUMP" | "STOPPING" | "ACKNOWLEDGED" | "UNKNOWN"; ... 6 more ...; agent_id: string; }' is not assignable to type 'Readonly<{ type: "STATE" | "ERROR" | "ACTION_RESULT" | "ACTION"; subtype: "RUNNING" | "STARTING" | "IN_PROGRESS" | "CONFIG" | "FAILED" | "STOPPED" | "DATA_DUMP" | "STOPPING" | "ACKNOWLEDGED" | "UNKNOWN"; ... 6 more ...; stream_id: string | undefined; }>'. Property 'data' is optional in type '{ payload: string | undefined; type: "STATE" | "ERROR" | "ACTION_RESULT" | "ACTION"; subtype: "RUNNING" | "STARTING" | "IN_PROGRESS" | "CONFIG" | "FAILED" | "STOPPED" | "DATA_DUMP" | "STOPPING" | "ACKNOWLEDGED" | "UNKNOWN"; ... 6 more ...; agent_id: string; }' but required in type 'Readonly<{ type: "STATE" | "ERROR" | "ACTION_RESULT" | "ACTION"; subtype: "RUNNING" | "STARTING" | "IN_PROGRESS" | "CONFIG" | "FAILED" | "STOPPED" | "DATA_DUMP" | "STOPPING" | "ACKNOWLEDGED" | "UNKNOWN"; ... 6 more ...; stream_id: string | undefined; }>'. 122 const objects: Array<SavedObjectsBulkCreateObject<AgentEventSOAttributes>> = events.map( ~~~~~~~ x-pack/plugins/ingest_manager/server/services/api_keys/security.ts:31:43 - error TS2339: Property 'getClusterClient' does not exist on type 'AppContextService'. 31 const clusterClient = appContextService.getClusterClient(); ~~~~~~~~~~~~~~~~ x-pack/plugins/ingest_manager/server/services/epm/registry/extract.ts:7:17 - error TS7016: Could not find a declaration file for module 'tar'. '/Users/jfsiii/work/kibana/x-pack/node_modules/tar/index.js' implicitly has an 'any' type. Try `npm install @types/tar` if it exists or add a new declaration (.d.ts) file containing `declare module 'tar';` 7 import tar from 'tar'; ~~~~~ Found 12 errors. ```
John Schulz committedFeb 19, 2020 Configuration menu - View commit details
-
Copy full SHA for 948cd6f - Browse repository at this point
Copy the full SHA 948cd6fView commit details
Commits on Feb 20, 2020
-
Remove legacy
ingest
plugin completely (#58056)Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a2e5e3d - Browse repository at this point
Copy the full SHA a2e5e3dView commit details -
WIP. 1 type error (but >1 bugs) remaining.
John Schulz committedFeb 20, 2020 Configuration menu - View commit details
-
Copy full SHA for 119c5d1 - Browse repository at this point
Copy the full SHA 119c5d1View commit details -
Add
callCluster
accessors for using ES vs appContext.getClusterClie……nt()
John Schulz committedFeb 20, 2020 Configuration menu - View commit details
-
Copy full SHA for 9e91031 - Browse repository at this point
Copy the full SHA 9e91031View commit details -
Merge branch 'feature-ingest' of github.com:elastic/kibana into featu…
…re-ingest Pick up the changes from #57818
John Schulz committedFeb 20, 2020 Configuration menu - View commit details
-
Copy full SHA for 61caadc - Browse repository at this point
Copy the full SHA 61caadcView commit details -
Undo (?) changes to kbn-pm/dist/index.js
John Schulz committedFeb 20, 2020 Configuration menu - View commit details
-
Copy full SHA for 49e073d - Browse repository at this point
Copy the full SHA 49e073dView commit details -
Run scripts/build_renovate_config for @types/tar
John Schulz committedFeb 20, 2020 Configuration menu - View commit details
-
Copy full SHA for 0c3f0d8 - Browse repository at this point
Copy the full SHA 0c3f0d8View commit details
Commits on Feb 21, 2020
-
Replace data w/ agent_id in server schema
John Schulz committedFeb 21, 2020 Configuration menu - View commit details
-
Copy full SHA for 1dff32e - Browse repository at this point
Copy the full SHA 1dff32eView commit details -
Different way to declare a saved object type
John Schulz committedFeb 21, 2020 Configuration menu - View commit details
-
Copy full SHA for a12d827 - Browse repository at this point
Copy the full SHA a12d827View commit details -
Use a more specific path to the agent script
John Schulz committedFeb 21, 2020 Configuration menu - View commit details
-
Copy full SHA for d7daa8b - Browse repository at this point
Copy the full SHA d7daa8bView commit details -
Replace data with agent_id for agent checkin
John Schulz committedFeb 21, 2020 Configuration menu - View commit details
-
Copy full SHA for 9871743 - Browse repository at this point
Copy the full SHA 9871743View commit details -
Restore internalSavedObjectsClient in app context
John Schulz committedFeb 21, 2020 Configuration menu - View commit details
-
Copy full SHA for fbc4821 - Browse repository at this point
Copy the full SHA fbc4821View commit details -
Use project & HTTP TS types in scripts/dev_agent
John Schulz committedFeb 21, 2020 Configuration menu - View commit details
-
Copy full SHA for 2b66026 - Browse repository at this point
Copy the full SHA 2b66026View commit details -
Remove ingestManager from FTR features
The plugin is disabled by default and not currently running the FTR tests. I believe we'll add this back when we restore the EPM integration tests.
John Schulz committedFeb 21, 2020 Configuration menu - View commit details
-
Copy full SHA for b964c14 - Browse repository at this point
Copy the full SHA b964c14View commit details -
Move more variables to common/{constants,types}
John Schulz committedFeb 21, 2020 Configuration menu - View commit details
-
Copy full SHA for f83875a - Browse repository at this point
Copy the full SHA f83875aView commit details -
Remove ingestManager from default expected features
John Schulz committedFeb 21, 2020 Configuration menu - View commit details
-
Copy full SHA for aa10fee - Browse repository at this point
Copy the full SHA aa10feeView commit details -
Enable conditional routes. Adjust integration tests
EPM routes currently return a 500 for these tests. For now they `.expect(500)` when enabled and `.expect(404)` when disabled. We can look into the issue and get them to `.expect(200)` in later tests.
John Schulz committedFeb 21, 2020 Configuration menu - View commit details
-
Copy full SHA for 1f27d34 - Browse repository at this point
Copy the full SHA 1f27d34View commit details -
Replace React.FC with React.FunctionComponent following new repo pattern
John Schulz committedFeb 21, 2020 Configuration menu - View commit details
-
Copy full SHA for 26a4690 - Browse repository at this point
Copy the full SHA 26a4690View commit details
Commits on Feb 22, 2020
-
Enable Fleet & Ingest FTR tests
John Schulz committedFeb 22, 2020 Configuration menu - View commit details
-
Copy full SHA for f41b6ce - Browse repository at this point
Copy the full SHA f41b6ceView commit details
Commits on Feb 23, 2020
-
Remove duplicate *Response entries from server/types
John Schulz committedFeb 23, 2020 Configuration menu - View commit details
-
Copy full SHA for 79411a9 - Browse repository at this point
Copy the full SHA 79411a9View commit details
Commits on Feb 24, 2020
-
Update README instructions for CLI flags. Rearrange sections (#58363)
* Add instructions for CLI flags. Rearrange sections Also added some more information about the plugin behavior with links to relevant code * Add instructions for Ingest & Fleet FTR tests
John Schulz committedFeb 24, 2020 Configuration menu - View commit details
-
Copy full SHA for c2da4b2 - Browse repository at this point
Copy the full SHA c2da4b2View commit details
Commits on Feb 25, 2020
-
Merge branch 'master' into feature-ingest
John Schulz committedFeb 25, 2020 Configuration menu - View commit details
-
Copy full SHA for 33fcc05 - Browse repository at this point
Copy the full SHA 33fcc05View commit details -
Restore search to EPM list page
John Schulz committedFeb 25, 2020 Configuration menu - View commit details
-
Copy full SHA for 5101a9c - Browse repository at this point
Copy the full SHA 5101a9cView commit details
Commits on Feb 26, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7280694 - Browse repository at this point
Copy the full SHA 7280694View commit details
Commits on Feb 27, 2020
-
[Ingest] Adjust saved object mappings and rename policy -> config (#5…
…8670) * Replace all reference to (agent) "policy"/"policies" with "config"/"configs" * Adjust output and datasource saved object mappings * Update schemas and types to match SO changes * Fix type check * Adjust default output object * Fix property names in tests
Configuration menu - View commit details
-
Copy full SHA for a479cdd - Browse repository at this point
Copy the full SHA a479cddView commit details -
Move installing of index templates and ingest pipelines to package in…
…stallation (#58619) * update template and pipeline asset names, install on package install * fix package install error handling messaging * save references to installations to package saved object * add epm.enabled flag for epm functional test runner * don't add suffix to pipeline entry
Configuration menu - View commit details
-
Copy full SHA for bf04422 - Browse repository at this point
Copy the full SHA bf04422View commit details -
Merge branch 'master' into feature-ingest
John Schulz committedFeb 27, 2020 Configuration menu - View commit details
-
Copy full SHA for 83d7ea5 - Browse repository at this point
Copy the full SHA 83d7ea5View commit details
Commits on Feb 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 98d1719 - Browse repository at this point
Copy the full SHA 98d1719View commit details
Commits on Mar 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8023f4f - Browse repository at this point
Copy the full SHA 8023f4fView commit details -
Adding events for index pattern generation (#58908)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 463c2b8 - Browse repository at this point
Copy the full SHA 463c2b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 809246f - Browse repository at this point
Copy the full SHA 809246fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c36d3c - Browse repository at this point
Copy the full SHA 6c36d3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2dc18a - Browse repository at this point
Copy the full SHA f2dc18aView commit details
Commits on Mar 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f3a62b2 - Browse repository at this point
Copy the full SHA f3a62b2View commit details
Commits on Mar 4, 2020
-
support for top level elasticsearch assets installation (#58869)
* add support for ilm policy installation * check if ilm policy exists * handle prebuilt index templates, update tests * cleanup * update type in install * fix installing index templates to create multiple ones for inheritance
Configuration menu - View commit details
-
Copy full SHA for bc7fbf5 - Browse repository at this point
Copy the full SHA bc7fbf5View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc04eb8 - Browse repository at this point
Copy the full SHA cc04eb8View commit details -
Use the new definitions from package-registry#176 (#59311)
John Schulz committedMar 4, 2020 Configuration menu - View commit details
-
Copy full SHA for e7e1b08 - Browse repository at this point
Copy the full SHA e7e1b08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cab6bd - Browse repository at this point
Copy the full SHA 5cab6bdView commit details -
[Ingest] Full agent config schema & API (#59262)
* Add schema for full agent config and business logic to convert SO agent config -> full agent config * Adjust output properties in full agent config * Whitelist full agent config output fields
Configuration menu - View commit details
-
Copy full SHA for 3a29d3a - Browse repository at this point
Copy the full SHA 3a29d3aView commit details
Commits on Mar 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 203303d - Browse repository at this point
Copy the full SHA 203303dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0340a92 - Browse repository at this point
Copy the full SHA 0340a92View commit details -
Use POST vs GET for EPM install & remove (#59367)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 16b3616 - Browse repository at this point
Copy the full SHA 16b3616View commit details -
install default packages during setup (#59330)
* install default packages during setup * check if package is already installed
Configuration menu - View commit details
-
Copy full SHA for c479755 - Browse repository at this point
Copy the full SHA c479755View commit details -
[Ingest] Updates to Agent Configuration List UI (#59374)
- Added search bar - Sync of columns to design - Actions per row in popup menu - Connect pagination and per-page count to API request - Support for `kuery` url param
Configuration menu - View commit details
-
Copy full SHA for 1135b25 - Browse repository at this point
Copy the full SHA 1135b25View commit details -
Update docs from /api/:section to /api/ingest_manager/:section (#59422)
John Schulz committedMar 5, 2020 Configuration menu - View commit details
-
Copy full SHA for 785f934 - Browse repository at this point
Copy the full SHA 785f934View commit details
Commits on Mar 6, 2020
-
[EPM] Add Streams TS type to mirror EPR's (#59446)
* Add Streams TS type in EPM to mirror EPR's Follows the changes add in https://github.com/elastic/package-registry/pull/230/files#diff-7dea786222588c32c19238bffffee9c2 * Add RegistryPackage.datasources * Add more detailed shape for Registry Vars
John Schulz committedMar 6, 2020 Configuration menu - View commit details
-
Copy full SHA for dcab91b - Browse repository at this point
Copy the full SHA dcab91bView commit details -
Don't code in modify src/plugins/management
See PR convo at https://github.com/elastic/kibana/pull/59376/files/c47975535f72e41b0f9a70e678454aac15927db6#r389042975
John Schulz committedMar 6, 2020 Configuration menu - View commit details
-
Copy full SHA for dcade4c - Browse repository at this point
Copy the full SHA dcade4cView commit details -
[Ingest] Add agent counts to each agent config output of `/agent_conf…
…igs` API (#59552) * Added agent counts to getAgentConfigsHandler * Show agent counts on Agent Config List
Configuration menu - View commit details
-
Copy full SHA for cf5bacb - Browse repository at this point
Copy the full SHA cf5bacbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 624e0d9 - Browse repository at this point
Copy the full SHA 624e0d9View commit details
Commits on Mar 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for fea5a1f - Browse repository at this point
Copy the full SHA fea5a1fView commit details
Commits on Mar 9, 2020
-
[EPM] Use /packages & /packages/{pkgkey} (#59550)
* Use /packages & /packages/{pkgkey} * Update paths in skipped tests * Docs use /packages vs /package/{install,delete} Some copy & code sample changes. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for cf40b2c - Browse repository at this point
Copy the full SHA cf40b2cView commit details -
[Ingest] Design sync for Agent Configuration Create Flyout (#59479)
* Match form to design * Support URI route param to open flyout
Configuration menu - View commit details
-
Copy full SHA for a5683d8 - Browse repository at this point
Copy the full SHA a5683d8View commit details -
[Ingest] Create data source step 1 & 2 (#59590)
* Add Error and PackageIcon components * Add create datasource layout+navigation, and select package step * Add description field to datasource, remove assets and description from datasource package * Add temporary datasources typing for EPM package info * Initial pass at configure datasources step. Stream vars only (no input vars yet) * First pass at input vars config; separate components * Fix issue with adding more than one datasource to a config * Add shell review step; save datasouce * Remove assign/unassign datasource from agent config details UI, replace with add datasource buttons * Remove actions column from datasource table * Initial pass at create datasource from package * Move package to config service to /common, add tests * Rename VarsEntry to RegistryVarsEntry, add datasets and datasources to RegistrySearchResult definition * Add typings to create datasource flow * Add real count of agents to select agent config list * Ensure the necessary package is installed at time of datasource creation
Configuration menu - View commit details
-
Copy full SHA for 97cf2ff - Browse repository at this point
Copy the full SHA 97cf2ffView commit details -
Use lowercase pkgkey for consistency
John Schulz committedMar 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 2279881 - Browse repository at this point
Copy the full SHA 2279881View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f4fd17 - Browse repository at this point
Copy the full SHA 5f4fd17View commit details
Commits on Mar 10, 2020
-
Update EPM file path to use /packages (#59693)
John Schulz committedMar 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 5ca355d - Browse repository at this point
Copy the full SHA 5ca355dView commit details -
Henry committed
Mar 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 2db4723 - Browse repository at this point
Copy the full SHA 2db4723View commit details -
[EPM] Use icons from packages, if present (#59765)
John Schulz committedMar 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 3477080 - Browse repository at this point
Copy the full SHA 3477080View commit details -
[Ingest] Create data source step 3 (#59822)
* Make app setup loading state prettier * Add review step of datasource wizard * Change name to ID in agent config datasources field * Fix types * Add stored datasource to agent datasource unit tests * Adjustment of registry typings and which registry copy fields to show to sync with elastic/package-registry#242 * Fix `multi` vars not populating with array: #59724 * Account for if a stream is enabled by default from registry package definition: #59724 * Adjust tests to account for last two commits * Fix review page back link * Fix d'oh typo
Configuration menu - View commit details
-
Copy full SHA for 189b4b9 - Browse repository at this point
Copy the full SHA 189b4b9View commit details
Commits on Mar 11, 2020
-
[Ingest] Agent Config Details header and sub tabs navigation (#59783)
- Syncs Agent Config Details header to design - Includes sub navigation tabs connected to route URL - Agent Config List Create data source row action enabled
Configuration menu - View commit details
-
Copy full SHA for 576f61e - Browse repository at this point
Copy the full SHA 576f61eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dac462 - Browse repository at this point
Copy the full SHA 8dac462View commit details -
Merge remote-tracking branch 'upstream/master' into feature-ingest
John Schulz committedMar 11, 2020 Configuration menu - View commit details
-
Copy full SHA for 111a170 - Browse repository at this point
Copy the full SHA 111a170View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe96065 - Browse repository at this point
Copy the full SHA fe96065View commit details -
Merge branch 'feature-ingest' of github.com:elastic/kibana into featu…
…re-ingest
John Schulz committedMar 11, 2020 Configuration menu - View commit details
-
Copy full SHA for ab43d14 - Browse repository at this point
Copy the full SHA ab43d14View commit details
Commits on Mar 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 27d85cf - Browse repository at this point
Copy the full SHA 27d85cfView commit details -
[Ingest] Address #59376 feedback (#59961)
* Disable create/destroy CTAs if no write capability Use `core.application.capabilities.ingestManager.write` to test user permissions * Add -all & -read tags for HTTP routes * Update test .expect() to match description * Add useCapabilities hook. Fix two issues with hiding/disabling CTA. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e12a8ad - Browse repository at this point
Copy the full SHA e12a8adView commit details -
John Schulz committed
Mar 12, 2020 Configuration menu - View commit details
-
Copy full SHA for 352e5f6 - Browse repository at this point
Copy the full SHA 352e5f6View commit details -
Use package icon as default when no other can be found (#60025)
John Schulz committedMar 12, 2020 Configuration menu - View commit details
-
Copy full SHA for 1ee3c1e - Browse repository at this point
Copy the full SHA 1ee3c1eView commit details -
Merge remote-tracking branch 'upstream/master' into feature-ingest
John Schulz committedMar 12, 2020 Configuration menu - View commit details
-
Copy full SHA for e83b67b - Browse repository at this point
Copy the full SHA e83b67bView commit details -
Remove duplicate xpack setting
FTR tests failing to start ES with error ``` ERROR ERROR: setting [xpack.security.authc.api_key.enabled] already set, saw [true] and [true] ``` https://github.com/elastic/kibana/pull/59376/checks?check_run_id=503930031 & https://github.com/elastic/kibana/pull/59376/checks?check_run_id=503975576 etc It appears the xpack.security.authc.api_key.enabled flag was recently added to master in another part, so remove our instance of the setting to prevent the error
John Schulz committedMar 12, 2020 Configuration menu - View commit details
-
Copy full SHA for fe7cf47 - Browse repository at this point
Copy the full SHA fe7cf47View commit details -
Update EPM file tests to use /packages/{pkgkey}
These should have failed when the routes were changed. Will go back and see what happened.
John Schulz committedMar 12, 2020 Configuration menu - View commit details
-
Copy full SHA for 4a9af8d - Browse repository at this point
Copy the full SHA 4a9af8dView commit details -
[Ingest] Add
revision
to agent configs & data sources (#59848)* Add revision to agent config and datasource saved objects, add delete datasource service and datasource * Add revision to full agent config output * PR feedback
Configuration menu - View commit details
-
Copy full SHA for 755ba3a - Browse repository at this point
Copy the full SHA 755ba3aView commit details