Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry migration operations which fail due to snapshot in progress #58884

Merged
merged 3 commits into from
Mar 2, 2020
Merged

Retry migration operations which fail due to snapshot in progress #58884

merged 3 commits into from
Mar 2, 2020

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Feb 28, 2020 •
edited
Loading

Summary

Fixes: #47808
Related to: #52202

Release notes:
Fixes a bug that could cause saved object migrations to fail when an Elasticsearch snapshot is currently in progress.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@rudolf rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform v8.0.0 v7.7.0 v7.6.2 labels Feb 28, 2020
@rudolf rudolf requested a review from a team as a code owner February 28, 2020 15:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

pgayvallet
pgayvallet approved these changes Feb 29, 2020
View reviewed changes
src/core/server/elasticsearch/retry_call_cluster.ts
Comment on lines -67 to +68
error instanceof esErrors.Gone
error instanceof esErrors.Gone ||
error?.body?.error?.type === 'snapshot_in_progress_exception'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is not on our side, but ES error handling seems like a mess...

@rudolf
Copy link
Contributor Author

rudolf commented Mar 2, 2020

@elasticmachine merge upstream

@rudolf
Copy link
Contributor Author

rudolf commented Mar 2, 2020

CI previously passed but failed after merging master due to #58983 so going ahead and merging.

@rudolf rudolf merged commit d7601cc into elastic:master Mar 2, 2020
@rudolf rudolf deleted the retry-snapshot-exception branch March 2, 2020 12:16
rudolf added a commit to rudolf/kibana that referenced this pull request Mar 2, 2020
@rudolf @elasticmachine
Retry migration operations which fail due to snapshot in progress (el…
57c051a 
…astic#58884)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@rudolf rudolf mentioned this pull request Mar 2, 2020
Merged
rudolf added a commit to rudolf/kibana that referenced this pull request Mar 2, 2020
@rudolf @elasticmachine
Retry migration operations which fail due to snapshot in progress (el…
4dc8205 
…astic#58884)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@rudolf rudolf mentioned this pull request Mar 2, 2020
Merged
rudolf added a commit that referenced this pull request Mar 2, 2020
@rudolf @elasticmachine
Retry migration operations which fail due to snapshot in progress (#5…
f626539 
…8884) (#59018)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
rudolf added a commit that referenced this pull request Mar 3, 2020
@rudolf @elasticmachine
[7.6] Retry migration operations which fail due to snapshot in progre…
8462fc0 
…ss (#58884) (#59019)

* Retry migration operations which fail due to snapshot in progress (#58884)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Import APICaller type

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
Feature:New Platform release_note:fix Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.6.2 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kibana migrations potentially fail if there's a running ES snapshot
4 participants
@rudolf @elasticmachine @kibanamachine @pgayvallet