-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded panel styles #58654
Merged
ryankeairns
merged 1 commit into
elastic:feat/lens-embeds-in-canvas
from
ryankeairns:feat/lens-embeds-in-canvas
Feb 27, 2020
Merged
Embedded panel styles #58654
ryankeairns
merged 1 commit into
elastic:feat/lens-embeds-in-canvas
from
ryankeairns:feat/lens-embeds-in-canvas
Feb 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryankeairns
force-pushed
the
feat/lens-embeds-in-canvas
branch
from
February 26, 2020 20:32
5e1ea74
to
c879909
Compare
💔 Build FailedTest FailuresKibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/legacy/plugins/canvas/canvas_plugin_src/renderers/embeddable.input to expression Lens Embeddable converts to a savedLens expressionStandard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/machine_learning/data_frame_analytics/classification_creation·ts.machine learning data frame analytics classification creation bank marketing starts the analytics jobStandard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/machine_learning/data_frame_analytics/classification_creation·ts.machine learning data frame analytics classification creation bank marketing starts the analytics jobStandard Out
Stack Trace
To update your PR or re-run it, just comment with: |
cqliu1
added a commit
that referenced
this pull request
Mar 3, 2020
Fixed import embedded panel styles (#58654) Merging to WIP draft branch
cqliu1
added a commit
that referenced
this pull request
Mar 4, 2020
Fixed import embedded panel styles (#58654) Merging to WIP draft branch
cqliu1
added a commit
that referenced
this pull request
Mar 5, 2020
Fixed import embedded panel styles (#58654) Merging to WIP draft branch
cqliu1
added a commit
that referenced
this pull request
Mar 6, 2020
Fixed import embedded panel styles (#58654) Merging to WIP draft branch
cqliu1
added a commit
that referenced
this pull request
Mar 9, 2020
Fixed import embedded panel styles (#58654) Merging to WIP draft branch
cqliu1
added a commit
that referenced
this pull request
Mar 13, 2020
Fixed import embedded panel styles (#58654) Merging to WIP draft branch
cqliu1
added a commit
that referenced
this pull request
Mar 19, 2020
Fixed import embedded panel styles (#58654) Merging to WIP draft branch
cqliu1
added a commit
that referenced
this pull request
Mar 19, 2020
* Added lens embeddables to embed flyout Fixed import embedded panel styles (#58654) Merging to WIP draft branch * Added i18n strings for savedLens * Added tests for lens embeddables * Updated tests * Updated tests * Added style overrides for lens table * DDisables triggers on lens emebeddable * Updated test * Sets embeddable view mode according to app state * Fix embeddable component * Removed embeddable view mode logic * Removed unused import
cqliu1
added a commit
that referenced
this pull request
Mar 20, 2020
* Added lens embeddables to embed flyout Fixed import embedded panel styles (#58654) Merging to WIP draft branch * Added i18n strings for savedLens * Added tests for lens embeddables * Updated tests * Updated tests * Added style overrides for lens table * DDisables triggers on lens emebeddable * Updated test * Sets embeddable view mode according to app state * Fix embeddable component * Removed embeddable view mode logic * Removed unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing some panel changes that Catherine and I discussed.
These may need moved to another file, but since this is a WIP it was the easiest way to test.