Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Fix column reordering in settings page #58104

Merged
merged 3 commits into from
Feb 20, 2020

Commits on Feb 20, 2020

  1. Ensure only one element has scroll

    Apparently having multiple elements with scroll confuses the
    `react-beautiful-dnd` mechanism to determine the position of the
    elements. Adding `overflowY` to the app root fixes it.
    Alejandro Fernández Gómez committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    a1c32a6 View commit details
    Browse the repository at this point in the history
  2. Fix upper bound check for log column reordering

    Alejandro Fernández Gómez committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    a4eb08d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    25fc73a View commit details
    Browse the repository at this point in the history