Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] NP: ensure bucket span estimator validation endpoint works as expected #58004

Merged
merged 1 commit into from
Feb 20, 2020
Merged

[ML] NP: ensure bucket span estimator validation endpoint works as expected #58004

merged 1 commit into from
Feb 20, 2020

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Feb 19, 2020 •
edited
Loading

Summary

Updates /api/ml/validate/estimate_bucket_span endpoint schema to include missing filters property. Adds test.

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner February 19, 2020 14:07
@alvarezmelissa87 alvarezmelissa87 self-assigned this Feb 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

pheyos
pheyos approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM (MLQA tests are also passing again with this fix)

@alvarezmelissa87
Copy link
Contributor Author

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

walterra
walterra approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87 alvarezmelissa87 merged commit 47bb7c6 into elastic:master Feb 20, 2020
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Feb 20, 2020
Merged
@alvarezmelissa87 alvarezmelissa87 deleted the ml-job-validation-schema-fix branch February 20, 2020 14:14
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Feb 20, 2020
@alvarezmelissa87
update estimateBucketSpan schema and api test (elastic#58004)
93a29c6
alvarezmelissa87 added a commit that referenced this pull request Feb 20, 2020
@alvarezmelissa87
update estimateBucketSpan schema and api test (#58004) (#58123)
1f87879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@pheyos pheyos pheyos approved these changes

@darnautov darnautov Awaiting requested review from darnautov

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:NP Migration :ml release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alvarezmelissa87 @elasticmachine @kibanamachine @walterra @pheyos