Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling action triggers in embeddables #57691

Merged
merged 3 commits into from
Feb 19, 2020
Merged

Allow disabling action triggers in embeddables #57691

merged 3 commits into from
Feb 19, 2020

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Feb 14, 2020 •
edited
Loading

Summary

Partially adresses #9220

  • Allow disabling action triggers in embeddables.
  • Disable embeddable triggers in Canvas.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@streamich streamich requested review from a team as code owners February 14, 2020 14:22
@streamich streamich added Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes review Team:AppArch Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.7.0 v8.0.0 labels Feb 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@lizozom
Copy link
Contributor

lizozom commented Feb 16, 2020

@elasticmachine merge upstream

crob611
crob611 approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Dosant
Dosant approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

@streamich streamich merged commit 0101c63 into elastic:master Feb 19, 2020
@streamich streamich mentioned this pull request Feb 19, 2020
Merged
streamich added a commit that referenced this pull request Feb 19, 2020
@streamich @elasticmachine
feat: 🎸 allow disablint action trigger execution in embeddables (#57691…
0beb112 
…) (#57979)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@crob611 crob611 mentioned this pull request Apr 21, 2021
Closed
@drewdaemon drewdaemon mentioned this pull request Oct 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@streamich @elasticmachine @lizozom @kibanamachine @crob611 @Dosant