Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Single Metric Viewer: Fix brush visibility. #57564

Merged
merged 1 commit into from
Feb 14, 2020
Merged

[ML] Single Metric Viewer: Fix brush visibility. #57564

merged 1 commit into from
Feb 14, 2020

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Feb 13, 2020 •
edited
Loading

Summary

Checklist

For maintainers

@walterra walterra added bug Fixes for quality problems that affect the customer experience regression release_note:fix :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 v7.7.0 v7.6.1 labels Feb 13, 2020
@walterra walterra requested a review from a team as a code owner February 13, 2020 13:02
@walterra walterra self-assigned this Feb 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM ⚡️

peteharverson
peteharverson approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@walterra walterra merged commit c1cf489 into elastic:master Feb 14, 2020
@walterra walterra deleted the ml-fix-brush branch February 14, 2020 12:08
@walterra walterra mentioned this pull request Feb 14, 2020
Merged
walterra added a commit to walterra/kibana that referenced this pull request Feb 14, 2020
@walterra
[ML] Fix brush visibility. (elastic#57564)
0abe039 
Fixes brush visibility. The brush will no longer be hidden if it covers the full available timespan. Removes all code that was earlier used to manage brush visibility.
walterra added a commit to walterra/kibana that referenced this pull request Feb 14, 2020
@walterra
[ML] Fix brush visibility. (elastic#57564)
ae9c669 
Fixes brush visibility. The brush will no longer be hidden if it covers the full available timespan. Removes all code that was earlier used to manage brush visibility.
@walterra walterra mentioned this pull request Feb 14, 2020
Merged
walterra added a commit that referenced this pull request Feb 14, 2020
@walterra
[ML] Fix brush visibility. (#57564) (#57676)
d9becbb 
Fixes brush visibility. The brush will no longer be hidden if it covers the full available timespan. Removes all code that was earlier used to manage brush visibility.
walterra added a commit that referenced this pull request Feb 14, 2020
@walterra
[ML] Fix brush visibility. (#57564) (#57678)
00542a7 
Fixes brush visibility. The brush will no longer be hidden if it covers the full available timespan. Removes all code that was earlier used to manage brush visibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov Awaiting requested review from darnautov

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

Assignees

@walterra walterra

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml regression release_note:fix v7.6.1 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Single metric viewer - time slider hidden when expanded to full width
5 participants
@walterra @elasticmachine @kibanamachine @alvarezmelissa87 @peteharverson