Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expressions server-side #57537

Merged
merged 9 commits into from
Feb 19, 2020
Merged

Expressions server-side #57537

merged 9 commits into from
Feb 19, 2020

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Feb 13, 2020 •
edited
Loading

Summary

Partially addresses #46906

  • Expose expression service server contract (which should look the same as client side one)

Checklist

For maintainers

Dev Docs

It is now possible to register expression functions and types on the Kibana server and execute expressions on the server. The API is the same as in the browser-side plugin, e.g:

plugins.expressions.registerFunction(/* ... */);
const result = await plugins.expressions.run('var_set name="foo" value="bar" | var name="foo"', null);

@streamich streamich requested a review from a team as a code owner February 13, 2020 08:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. review v7.7.0 v8.0.0 labels Feb 13, 2020
@streamich streamich changed the title Expressions server side Expressions server-side Feb 13, 2020
@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

@streamich streamich requested a review from ppisljar February 13, 2020 12:05
ppisljar
ppisljar approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit 6678436 into elastic:master Feb 19, 2020
@streamich streamich mentioned this pull request Feb 19, 2020
Merged
streamich added a commit that referenced this pull request Feb 19, 2020
@streamich @elasticmachine
Expressions server-side (#57537) (#58009)
90fd9ad 
* refactor: 💡 improve setup and documentations of expr service

* feat: 🎸 expose ExpressionsService on server-side

* feat: 🎸 freeze expression plugin contracts

* test: 💍 add basic integration test to server-side expr plugin

* feat: 🎸 export static exports from expressions server-side

* fix: 🐛 fix Jest mocks

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. review v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@streamich @elasticmachine @kibanamachine @ppisljar