Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Use ES Permission API to check if a user has permissions to read from APM indices #57311

Merged
merged 7 commits into from
Feb 19, 2020
Merged

[APM] Use ES Permission API to check if a user has permissions to read from APM indices #57311

merged 7 commits into from
Feb 19, 2020

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Feb 11, 2020 •
edited
Loading

fixes #57215
Server route: /api/apm/security/indices_privileges
I renamed all server-side from 'Permissions' to 'Privileges', since I'm going to return all privileges from APM indices. And in the client, I'll check if the user has permission based on the privileges.

Screenshot 2020-02-13 at 09 48 34

Screenshot 2020-02-13 at 09 51 22

Screenshot 2020-02-13 at 09 51 44

Screenshot 2020-02-13 at 09 53 33

@cauemarcondes cauemarcondes marked this pull request as ready for review February 13, 2020 10:06
@cauemarcondes cauemarcondes requested a review from a team as a code owner February 13, 2020 10:06
sorenlouv
sorenlouv approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few few copy changes

@sorenlouv sorenlouv mentioned this pull request Feb 14, 2020
Closed
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@cauemarcondes
Copy link
Contributor Author

retest

@cauemarcondes cauemarcondes merged commit e7b6386 into elastic:master Feb 19, 2020
@cauemarcondes cauemarcondes deleted the missing-permission branch February 19, 2020 10:27
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Feb 19, 2020
@cauemarcondes
[APM] Use ES Permission API to check if a user has permissions to rea…
1a50fa9 
…d from APM indices (elastic#57311)

* get indices privileges from has_privileges api

* changing to ES privileges api

* changing missing permission page

* always show dimiss button

* always show dimiss button

* changing message and unit test

* fixing react warning message
@cauemarcondes cauemarcondes mentioned this pull request Feb 19, 2020
Merged
cauemarcondes added a commit that referenced this pull request Feb 19, 2020
@cauemarcondes
[APM] Use ES Permission API to check if a user has permissions to rea…
75fa271 
…d from APM indices (#57311) (#57984)

* get indices privileges from has_privileges api

* changing to ES privileges api

* changing missing permission page

* always show dimiss button

* always show dimiss button

* changing message and unit test

* fixing react warning message
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@formgeist formgeist formgeist left review comments

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
release_note:fix v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Use ES Privileges API to check if a user has permissions to read from APM indices
4 participants
@cauemarcondes @kibanamachine @sorenlouv @formgeist