[SIEM] Fixes failing Cypress tests #57202
Conversation
MadameSheema
added
Team:SIEM
v8.0.0
v7.7.0
backport:skip
|
Pinging @elastic/siem (Team:SIEM) |
MadameSheema
added
release_note:skip
| `[data-test-subj="timeline"] [data-test-subj="toggle-field-${timestampField}"]` | ||
| ).uncheck({ force: true }); | ||
| cy.get(`[data-test-subj="timeline"] [data-test-subj="toggle-field-${timestampField}"]`, { | ||
| timeout: DEFAULT_TIMEOUT, |
There was a problem hiding this comment.
@MadameSheema should we move DEFAULT_TIMEOUT into cypress.json, or is the intention to only use it for slow actions?
There was a problem hiding this comment.
@rylnd timeouts are a little bit tricky in Cypress. These are the ones that we can set in the configuration (https://docs.cypress.io/guides/references/configuration.html#Timeouts). If we extract that time out to the json file, as defaultCommandTimeout that timeout is only for the element in the DOM but when we put the timeout like that, we are also setting that timeout to the next action in this case the uncheck so in this case is used with intention. Nevertheless as now are tests are faster I'll revisit all of them in the refactor I'm working on. But for now for having the tests working with the latest master changes I would say that is ok :)
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* fixes events viewer tests * fixes 'toggle column' tests * fixes 'url state' tests * fixes type check issues
* master: (27 commits) Include actions new platform plugin for codeowners (elastic#57252) [APM][docs] 7.6 documentation updates (elastic#57124) Expressions refactor (elastic#54342) [ML] New Platform server shim: update annotation routes to use new platform router (elastic#57067) Remove injected ui app vars from Canvas (elastic#56190) update max_anomaly_score route schema to handle possible undefined values (elastic#57339) [Add panel flyout] Moving create new to the top of SavedObjectFinder (elastic#56428) Add mock of a legacy ui api to re-enable Canvas storybook (elastic#56673) [monitoring] Removes noisy event received log (elastic#57275) Remove use of copied MANAGEMENT_BREADCRUMBS and use `setBreadcrumbs` from management section's mount (elastic#57324) Advanced Settings management app to kibana platform plugin (elastic#56931) [ML] New Platform server shim: update recognize modules routes to use new platform router (elastic#57206) [ML] Fix overall stats for saved search on the Data Visualizer page (elastic#57312) [ML] [NP] Removing ui imports (elastic#56358) [SIEM] Fixes failing Cypress tests (elastic#57202) Create observability CODEOWNERS reference (elastic#57109) fix results service schema (elastic#57217) don't register a wrapper if browser side function exists. (elastic#57196) Ui Actions explorer example (elastic#57006) Fix update alert API to still work when AAD is out of sync (elastic#57039) ...
Summary
Fixes failing Cypress tests