Explicit index pattern namespace #57194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
added 2 commits
February 10, 2020 18:10
…index-pattern-namespace
lizozom
force-pushed
the
newplatform/data/index-pattern-namespace
branch
from
f45936c
to
1d1f3ae
Compare
…index-pattern-namespace
lizozom
commented
Feb 10, 2020
lizozom
commented
Feb 10, 2020
...egacy/core_plugins/kibana/public/discover/np_ready/components/field_chooser/field_chooser.js
Outdated
Show resolved
Hide resolved
lizozom
added
Feature:New Platform
release_note:skip
added 8 commits
February 10, 2020 20:24
…ata/index-pattern-namespace
…ata/index-pattern-namespace
|
@elasticmachine merge upstream |
…:lizozom/kibana into newplatform/data/index-pattern-namespace
nreese
approved these changes
Feb 11, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
lukeelmers
approved these changes
Feb 11, 2020
nickofthyme
approved these changes
Feb 11, 2020
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Feb 12, 2020
* Explicit index pattern namespace * typing of index patterns * fix ts error on master * export FieldList * Move isFilterable into indexPatterns namespace * Server index pattern cleanup * comment * isDefault * karma mock fix + discover fix Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lizozom
pushed a commit
that referenced
this pull request
Feb 12, 2020
* Explicit index pattern namespace * typing of index patterns * fix ts error on master * export FieldList * Move isFilterable into indexPatterns namespace * Server index pattern cleanup * comment * isDefault * karma mock fix + discover fix Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #56881
This PR applies the proposed resolution for #52374, trying to balance code readability, API discoverability, DX and documentation generation using ApiExtractor on index patterns.
Checklist
Delete any items that are not applicable to this PR.
For maintainers