Show blank lines instead of N/A on service map popovers #57014
Conversation
smith
added
Team:APM - DEPRECATED
|
Pinging @elastic/apm-ui (Team:apm) |
💔 Build Failed
To update your PR or re-run it, just comment with: |
smith
force-pushed
the
nls/popover-data
branch
2 times, most recently
from
6cd6b75 to
77da10b
Compare
💔 Build Failed
History
To update your PR or re-run it, just comment with: |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
@elasticmachine merge upstream |
| end, | ||
| environment | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: what do you think about collapsing small objects like this?
{
pathname: "/api/apm/service-map/service/{serviceName}",
params: {
path: { serviceName },
query: { start, end, environment }
}
};(I wish there was a prettier setting for this...)
There was a problem hiding this comment.
I usually try to compress them but don't think too much about them.
| ); | ||
| const isLoading = status === 'loading'; | ||
|
|
||
| return <ServiceMetricList {...data} isLoading={isLoading} />; |
There was a problem hiding this comment.
Interesting approach with a fetcher component. Reminds me of Redux' "smart" and "dumb" components.
It results in an extra component - makes testing the inner component a lot more straightforward. So I'm all for it 👍
There was a problem hiding this comment.
I wanted to test out the scenarios in storybook without having to mock a bunch of requests. It makes that easier and I think it makes for a good pattern in some cases.
smith
force-pushed
the
nls/popover-data
branch
from
53310fd to
92603aa
Compare
Because RUM agents never show CPU or memory usage, we don't want to always show the metric with N/A. If a metric is null, just hide the lines. Break up the display and fetching components and update the popover stories to show the list. Update some types.
smith
force-pushed
the
nls/popover-data
branch
from
157d185 to
f859192
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
* Show blank lines instead of N/A on service map popovers Because RUM agents never show CPU or memory usage, we don't want to always show the metric with N/A. If a metric is null, just hide the lines. Break up the display and fetching components and update the popover stories to show the list. Update some types. * Fix metric typings
) * Show blank lines instead of N/A on service map popovers Because RUM agents never show CPU or memory usage, we don't want to always show the metric with N/A. If a metric is null, just hide the lines. Break up the display and fetching components and update the popover stories to show the list. Update some types. * Fix metric typings
kibanamachine
removed
the
backport missing
Because RUM agents never show CPU or memory usage, we don't want to always show the metric with N/A. If a metric is null, just hide the lines.
Break up the display and fetching components and update the popover stories to show the list.
Update some types.
Fixes #54405