Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Settings management app to kibana platform plugin #56931

Merged
Merged
Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
be0e773
advanced settings component registry to new platform
mattkime Jan 25, 2020
9e7d525
change plugin name, fix some i18n
mattkime Jan 25, 2020
f3b467b
fix karma mocks
mattkime Jan 25, 2020
380838c
fix jest tests
mattkime Jan 25, 2020
b13abeb
fix jest tests
mattkime Jan 25, 2020
bc9d2c2
Merge branch 'adv_settings_componenet_reg_to_plugin' into adv_setting…
mattkime Jan 27, 2020
f152f37
Merge branch 'master' into adv_settings_mgmt_app_to_kibana_platform
mattkime Feb 5, 2020
6a05409
partial progress, mostly working
mattkime Feb 5, 2020
e3814e4
Merge branch 'master' into adv_settings_mgmt_app_to_kibana_platform
elasticmachine Feb 5, 2020
bbdab4d
eui related ts-ignore
mattkime Feb 6, 2020
9a1648c
Merge branch 'adv_settings_mgmt_app_to_kibana_platform' of github.com…
mattkime Feb 6, 2020
b56ef5a
i18n fixes
mattkime Feb 6, 2020
36ae481
updaatte snapshots
mattkime Feb 6, 2020
b2c7930
Merge branch 'master' into adv_settings_mgmt_app_to_kibana_platform
elasticmachine Feb 6, 2020
364fbf2
fix css
mattkime Feb 6, 2020
95ee227
Merge branch 'master' into adv_settings_mgmt_app_to_kibana_platform
elasticmachine Feb 7, 2020
2e4bb6f
Merge branch 'master' into adv_settings_mgmt_app_to_kibana_platform
mattkime Feb 7, 2020
244f77a
fix access
mattkime Feb 7, 2020
51ace74
Merge branch 'adv_settings_mgmt_app_to_kibana_platform' of github.com…
mattkime Feb 7, 2020
8aebfd8
update functional test
mattkime Feb 8, 2020
cbd8780
Merge branch 'master' into adv_settings_mgmt_app_to_kibana_platform
mattkime Feb 8, 2020
0161e64
hook up router, badge
mattkime Feb 9, 2020
40cf1b4
better snapshot
mattkime Feb 9, 2020
113c4bb
fix i18n and func test
mattkime Feb 9, 2020
95e2563
fix i18n and func test
mattkime Feb 9, 2020
a8328f1
remove comment, tiny refactor
mattkime Feb 9, 2020
3465f08
Merge branch 'master' into adv_settings_mgmt_app_to_kibana_platform
mattkime Feb 10, 2020
5da42c1
typefix
mattkime Feb 10, 2020
a941554
add index for scss, improve test mock
mattkime Feb 10, 2020
0f620d6
Merge branch 'master' into adv_settings_mgmt_app_to_kibana_platform
mattkime Feb 10, 2020
c6ef06e
fix scss path
mattkime Feb 10, 2020
25a1463
better snäpshöt
mattkime Feb 10, 2020
3854103
better AdvancedSetting component test
mattkime Feb 11, 2020
1329ac5
cleaner snäpshöt
mattkime Feb 11, 2020
3da1fbd
remove unused import
mattkime Feb 11, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/public/ui_settings/ui_settings_service.mock.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ const createSetupContractMock = () => {
setupContract.getUpdate$.mockReturnValue(new Rx.Subject<any>());
setupContract.getSaved$.mockReturnValue(new Rx.Subject<any>());
setupContract.getUpdateErrors$.mockReturnValue(new Rx.Subject<any>());
setupContract.getAll.mockReturnValue({});

return setupContract;
};
Expand Down
2 changes: 1 addition & 1 deletion src/legacy/core_plugins/kibana/public/management/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export function updateLandingPage(version) {
}

render(
<EuiPageContent horizontalPosition="center">
<EuiPageContent horizontalPosition="center" data-test-subj="managementHome">
<I18nContext>
<div>
<div className="eui-textCenter">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@

// Core
@import 'management_app';
@import 'sections/settings/advanced_settings';
@import '../../../../../plugins/advanced_settings/public';
mattkime marked this conversation as resolved.
Show resolved Hide resolved
@import 'sections/index_patterns/index';
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,5 @@
* under the License.
*/

import './settings';
import './objects';
import './index_patterns';

This file was deleted.

Loading