[SIEM] update url state between page if date is relative #56813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
bug
|
Pinging @elastic/siem (Team:SIEM) |
XavierM
changed the title
XavierM
force-pushed
the
siem-keep-relative-date-real
branch
from
49b858f
to
dbcb1b6
Compare
dhurley14
reviewed
Feb 5, 2020
| @@ -24,13 +24,12 @@ import { | |||
| UpdateUrlStateString, | |||
| } from './types'; | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| export const decodeRisonUrlState = (value: string | undefined): RisonValue | any | undefined => { | |||
| export const decodeRisonUrlState = <T>(value: string | undefined): T | null => { | |||
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
spong
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
Checked out locally and tested thoroughly. Relative datetimes are updating when navigating from Edit Rules -> Main Detection Engine (via main nav), and absolute datetimes do not update (as expected).
Note: As discussed, a lot of the Detection Engine links are not including the url state, so this won't work for those. Feel free to fix as part of this or a follow-up.
Great fix and improvements + tests too! Thanks @XavierM! 🎉 🙂
XavierM
force-pushed
the
siem-keep-relative-date-real
branch
from
544838a
to
b74f25e
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Feb 7, 2020
* update url state between page if needed it like time range * fix round up for to * simplify type * leftover cleanup * we forget to update relative date when loading the page by a refresh * pair with Garrett to make a minimal impact on the ux * fix detetections tabs
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Feb 7, 2020
* update url state between page if needed it like time range * fix round up for to * simplify type * leftover cleanup * we forget to update relative date when loading the page by a refresh * pair with Garrett to make a minimal impact on the ux * fix detetections tabs
XavierM
added a commit
that referenced
this pull request
Feb 7, 2020
…7074) * update url state between page if needed it like time range * fix round up for to * simplify type * leftover cleanup * we forget to update relative date when loading the page by a refresh * pair with Garrett to make a minimal impact on the ux * fix detetections tabs
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 7, 2020
…b.com:jloleysens/kibana into console/feature/text-objects-in-saved-objects * 'console/feature/text-objects-in-saved-objects' of github.com:jloleysens/kibana: (103 commits) fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998) TS of esKuery\node_types (elastic#56857) Kibana app migration: Move static code dependencies into kibana_legacy plugin, part 1 (elastic#56408) Retry ES API calls that fail with 410/Gone (elastic#56950) [APM] Show missing permissions message to the user on the Services overview (elastic#56374) Fixing flaky CI tests for custom appRoutes (elastic#55763) [State Management][Docs] State syncing utils docs (elastic#56479) [Index management] Remove index mapper setting in tests (elastic#57066) Exposed common EuiExpressions to separate components be able to reuse for building new for Alert Types (elastic#56466) [SIEM] update url state between page if date is relative (elastic#56813) fix for chart_types test (elastic#57056) chore(NA): remove compress from dll minimizer (elastic#57023) [File upload] Migrate routing to NP & add route validation (elastic#52313) Adding docs for grouped nav advanced setting (elastic#57013) Use i18n titles for field formatters, human names for numeral locales (elastic#56348) [Maps] Remove EMS catalogue url from docs (elastic#57020) [Endpoint] ERT-82 ERT-83 ERT-84: Alert list API with pagination (elastic#56538) [DOCS] Adds Apple notarization info to install doc (elastic#57042) [ML] New Platform server shim: update results service routes to use new platform router (elastic#56886) Fix typo on detection engine rule (elastic#56993) ...
XavierM
added a commit
that referenced
this pull request
Feb 7, 2020
…7072) * update url state between page if needed it like time range * fix round up for to * simplify type * leftover cleanup * we forget to update relative date when loading the page by a refresh * pair with Garrett to make a minimal impact on the ux * fix detetections tabs Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Feb 10, 2020
* update url state between page if needed it like time range * fix round up for to * simplify type * leftover cleanup * we forget to update relative date when loading the page by a refresh * pair with Garrett to make a minimal impact on the ux * fix detetections tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update date picker when switching page between the siem app if the date is relative.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately