Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Autocomplete for custom color palettes and custom icon palettes #56446

Merged
merged 17 commits into from
Feb 12, 2020
Merged

[Maps] Autocomplete for custom color palettes and custom icon palettes #56446

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
212b9b7
[Maps] type ahead for stop values for custom color maps and custom ic…
nreese Jan 29, 2020
0daf0a9
use Popover to show type ahead suggestions
nreese Jan 30, 2020
b3c8aaa
datalist version
nreese Jan 30, 2020
3bda35f
use EuiComboBox
nreese Jan 30, 2020
2bb25ec
clean up
nreese Jan 30, 2020
6e44f0c
wire ColorStopsCategorical to use StopInput component for autocomplete
nreese Jan 31, 2020
2f43e77
Merge branch 'master' into category_suggestions
elasticmachine Jan 31, 2020
cf8526e
clean up
nreese Jan 31, 2020
9ae2fa4
Merge branch 'category_suggestions' of github.com:nreese/kibana into …
nreese Jan 31, 2020
6154143
Merge branch 'master' into category_suggestions
elasticmachine Feb 3, 2020
fddacdb
cast suggestion values to string so boolean fields work
nreese Feb 3, 2020
c1096bf
Merge branch 'master' of github.com:elastic/kibana into category_sugg…
nreese Feb 9, 2020
c03cb7c
review feedback
nreese Feb 9, 2020
85b30b5
Merge branch 'master' into category_suggestions
elasticmachine Feb 12, 2020
fba491a
Merge branch 'master' of github.com:elastic/kibana into category_sugg…
nreese Feb 12, 2020
b02dbab
Merge branch 'category_suggestions' of github.com:nreese/kibana into …
nreese Feb 12, 2020
6bf86a3
fix problem with stall suggestions from previous field
nreese Feb 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...gacy/plugins/maps/public/layers/styles/vector/components/color/color_stops_categorical.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ export const ColorStopsCategorical = ({

return (
<StopInput
key={field.getName()} // force new component instance when field changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really clever

field={field}
getValueSuggestions={getValueSuggestions}
value={stopValue}
Expand Down
10 changes: 0 additions & 10 deletions x-pack/legacy/plugins/maps/public/layers/styles/vector/components/stop_input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ export class StopInput extends Component {

componentDidMount() {
this._isMounted = true;
this._prevFieldName = undefined;
this._loadFieldDataType();
}

componentDidUpdate() {
this._loadFieldDataType();
}

Expand All @@ -37,11 +32,6 @@ export class StopInput extends Component {
}

async _loadFieldDataType() {
if (this.props.field.getName() === this._prevFieldName) {
return;
}

this._prevFieldName = this.props.field.getName();
const fieldDataType = await this.props.field.getDataType();
if (this._isMounted) {
this.setState({ fieldDataType });
Expand Down
1 change: 1 addition & 0 deletions x-pack/legacy/plugins/maps/public/layers/styles/vector/components/symbol/icon_stops.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ export function IconStops({
/>
) : (
<StopInput
key={field.getName()} // force new component instance when field changes
field={field}
getValueSuggestions={getValueSuggestions}
value={stop}
Expand Down