Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken Handlebar documentation links #55866

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Fixes broken Handlebar documentation links #55866

merged 1 commit into from
Jan 24, 2020

Conversation

jamiesmith
Copy link
Contributor

@jamiesmith jamiesmith commented Jan 24, 2020

Summary

Just updated the URL for handlebar docs, page moved:

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@jamiesmith jamiesmith requested a review from a team as a code owner January 24, 2020 17:39
@jamiesmith
Copy link
Contributor Author

Note that I don't know how to backport this, just fixing the URL

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

$ curl -I https://handlebarsjs.com/guide/expressions.html                 ✔ HTTP/2 200
server: GitHub.com
content-type: text/html; charset=utf-8
last-modified: Mon, 13 Jan 2020 20:59:28 GMT
etag: "5e1cda30-19b34"
access-control-allow-origin: *
expires: Fri, 24 Jan 2020 17:50:36 GMT
cache-control: max-age=600
x-proxy-cache: MISS
x-github-request-id: 9376:605F:3DF852:45DC9D:5E2B2C12
accept-ranges: bytes
date: Fri, 24 Jan 2020 17:40:42 GMT
via: 1.1 varnish
age: 6
x-served-by: cache-sea4423-SEA
x-cache: HIT
x-cache-hits: 1
x-timer: S1579887642.433167,VS0,VE1
vary: Accept-Encoding
x-fastly-request-id: 9db809b7a1d9c10ff3dd7ca3325e2b102e1362f8
content-length: 105268

@tylersmalley tylersmalley changed the title fix URL for handlebar docs for markdown, and make sure they are https Fixes broken Handlebar documentation links Jan 24, 2020
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm I guess I can let this one slide

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor

@jamiesmith I came across this broken link while testing 7.6.0 bc2 on this pr: #54194. Can you please backport this fix to 7.6? The next bc will get it. Thanks!

@jamiesmith
Copy link
Contributor Author

@bhavyarm I ran the backport script and it shows that it was applied, above. Is there something else?

@crob611
Copy link
Contributor

crob611 commented Jan 27, 2020

@jamiesmith It was backported to 7.x, but the 7.6 branch had already been split off. You should be able to run the backport script again, but select the 7.6 branch instead of 7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants