Clear core loading indicator just before UI is rendered #55242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
joshdover
commented
Jan 17, 2020
| MockNotificationsService.start.mockImplementation(({ targetDomElement }): any => { | ||
| expect(targetDomElement.parentElement).not.toBeNull(); | ||
| targetDomElementParentInStart = targetDomElement.parentElement; |
There was a problem hiding this comment.
AFAIK it does not actually matter that the DOM element passed to Notifications is attached to the root element when NotificationsService#start is called, as long as it is attached at some point.
In the future, this pattern should probably be replaced by the single React-tree pattern provided by RenderingService that ChromeService and ApplicationService leverage.
mshustov
approved these changes
Jan 19, 2020
Do we know which changes actually did? EDIT: nevermind, #55241 |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Jan 21, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Jan 21, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This delays hiding the loading indicator until right before Core renders the basic UI (chrome, notifications, etc.)
This change should probably be backported to 7.6, where many of the changes that increased this load time were introduced.
This eliminates the problem where a blank screen is shown to the user while Core is running it's startup sequence. Note that I also found other opportunities to improve client-side startup performance here: #55241