Migrate session storage short url handling #55021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:NP Migration
Feature:SharingURLs
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
flash1293
added
the
release_note:skip
|
@elasticmachine merge upstream |
majagrubic
reviewed
Jan 21, 2020
| params: schema.object({ urlId: schema.string() }), | ||
| }, | ||
| }, | ||
| router.handleLegacyErrors(async function(context, request, response) { |
majagrubic
approved these changes
Jan 21, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Jan 21, 2020
flash1293
added a commit
that referenced
this pull request
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the rest of the short url service over to the new platform.
It uses a chromeless NP plugin app to fetch the short url via
fetch, put in the local storage and then redirect to the right app with hashed parameters.I decided against fixing #50107 in the same PR, this will happen after this change went in.
This PR had to touch the
newsfeedplugin because it was relying on injected meta data variables that are apparently not available for new platform apps (the returned config is not defined and produces a fatal error before the hashing and redirecting can take effect). Not sure whether that's a bug in the app rendering API fromcoreor a bug in thenewsfeedplugin. @joshdover What's the expected behavior in this case?