Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kibana tutorial for IBM MQ metrics #54900

Merged
merged 4 commits into from
Jan 16, 2020
Merged

Add Kibana tutorial for IBM MQ metrics #54900

merged 4 commits into from
Jan 16, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Jan 15, 2020

Summary

This PR adds a tutorial for freshly developed IBM MQ metricbeat.

Zrzut ekranu 2020-01-15 o 12 53 32

Master issue: elastic/beats#13508

Blocked by: elastic/beats#15301

@mtojek mtojek added the Team:Integrations Team Label for Observability Integrations team label Jan 15, 2020
@mtojek mtojek self-assigned this Jan 15, 2020
@mtojek mtojek added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Jan 15, 2020
@mtojek mtojek mentioned this pull request Jan 15, 2020
Merged
@exekias
Copy link
Contributor

exekias commented Jan 15, 2020

ey @mtojek about the logo, is there any logo specific to MQ? I guess IBM has many different projects so their logo could be misleading

@exekias
Copy link
Contributor

exekias commented Jan 15, 2020 •
edited
Loading

sorry I see this was already added for the logs past, still I wonder if we could improve that

@mtojek mtojek requested a review from a team January 15, 2020 12:34
@mtojek
Copy link
Contributor Author

mtojek commented Jan 15, 2020

sorry I see this was already added for the logs part, still I wonder if we could improve that

I've updated the IBM MQ logo. Thank you for the suggestion.

@mtojek mtojek requested a review from exekias January 16, 2020 08:51
flash1293
flash1293 approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from app perspective. Noticed some broken links, but they might be expected.

src/legacy/core_plugins/kibana/server/tutorials/ibmmq_metrics/index.js
'The `ibmmq` Metricbeat module fetches monitoring metrics from IBM MQ instances \
[Learn more]({learnMoreLink}).',
values: {
learnMoreLink: '{config.docs.beats.metricbeat}/metricbeat-module-ibmmq.html',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc links (this and the one about exported fields) don't work, but that might be expected (same for the IBM MQ logs tutorial).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IBM MQ Metricbeat has been just merged into master elastic/beats. That's why you couldn't see a valid doc link.

src/legacy/core_plugins/kibana/public/home/tutorial_resources/logos/ibmmq.svg Outdated
<svg id="Layer_1" data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 32 32"><defs><style>.cls-1,.cls-6{fill:none;}.cls-1{clip-rule:evenodd;}.cls-2{fill:#fff;}.cls-2,.cls-5,.cls-6{stroke:#7863ec;stroke-miterlimit:10;}.cls-3{clip-path:url(#clip-path);}.cls-4{fill:#e9e8ff;}.cls-5{fill:#e9e8fe;}</style><clipPath id="clip-path"><path class="cls-1" d="M10.55,16h13a1.5,1.5,0,0,1,0,3h-13a1.5,1.5,0,0,1,0-3Z"/></clipPath></defs><title>Artboard 1white</title><path class="cls-2" d="M10.59,8.51h11a1.5,1.5,0,1,1,0,3h-11a1.5,1.5,0,0,1,0-3Z"/><g class="cls-3"><rect class="cls-4" x="4.05" y="11" width="26" height="13"/></g><path class="cls-5" d="M9.51,14.52h13a1.5,1.5,0,1,1,0,3h-13a1.5,1.5,0,0,1,0-3Z"/><path class="cls-5" d="M10.6,20.51h11a1.5,1.5,0,0,1,0,3h-11a1.5,1.5,0,0,1,0-3Z"/><path class="cls-6" d="M2,4.55H3.73A1.73,1.73,0,0,1,5.45,6.29V24a3.52,3.52,0,0,0,3.5,3.53H23A3.52,3.52,0,0,0,26.51,24V6.31a1.75,1.75,0,0,1,1.74-1.76H30"/></svg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be simplified by stripping out debug information using an svg optimizer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, optimized.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mtojek mtojek merged commit 2c4d58b into elastic:master Jan 16, 2020
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
@mtojek @jkelastic
Add Kibana tutorial for IBM MQ metrics (elastic#54900)
1d5552a 
* Add Kibana tutorial for IBM MQ metrics

* Change IBM MQ logo

* Logo minified

* Add screenshot
@mtojek mtojek mentioned this pull request Jan 20, 2020
Merged
mtojek added a commit to mtojek/kibana that referenced this pull request Jan 20, 2020
@mtojek
Add Kibana tutorial for IBM MQ metrics (elastic#54900)
e9ce56e 
* Add Kibana tutorial for IBM MQ metrics

* Change IBM MQ logo

* Logo minified

* Add screenshot
mtojek added a commit that referenced this pull request Jan 20, 2020
@mtojek @elasticmachine
Add Kibana tutorial for IBM MQ metrics (#54900) (#55293)
493f60f 
* Add Kibana tutorial for IBM MQ metrics

* Change IBM MQ logo

* Logo minified

* Add screenshot

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees

@mtojek mtojek

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Integrations Team Label for Observability Integrations team v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtojek @exekias @kibanamachine @flash1293