Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up waitForToastMessageGone, handle error case #5489

Closed
wants to merge 12 commits into from

Conversation

w33ble
Copy link
Contributor

@w33ble w33ble commented Nov 24, 2015

Merge #5488 first

While working on the tryForTime change, I happened across another random functional test failure. Leadfoot's findAllByCssSelector apparently can either resolve with an empty array or reject, and there's seemingly no simple way to check for which will happen.

  • Adds a catch handler to waitForToastMessageGone
  • Speeds up the timeout in waitForToastMessageGone
  • Adds some additional debugging

@w33ble w33ble closed this Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant