Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix safari layout issue in Visualize, Graph and Lens #54694

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Fix safari layout issue in Visualize, Graph and Lens #54694

merged 2 commits into from
Jan 14, 2020

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Jan 14, 2020 •
edited
Loading

Fixes #54495

This PR fixes a layouting issue in Safari causing the Visualize, Lens and Graph apps not taking the full height of the page.

By switching from height: 100% to a flex based layouting, these apps render correctly again.

Tested in Chrome, Firefox and Safari.

@flash1293 flash1293 changed the title Fix safari layout issue in Visualize and Lens Fix safari layout issue in Visualize, Graph and Lens Jan 14, 2020
@flash1293 flash1293 added Feature:Graph Graph application feature release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0 Feature:Lens Feature:Vis Editor Visualization editor issues labels Jan 14, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review January 14, 2020 13:25
@flash1293 flash1293 requested a review from a team January 14, 2020 13:25
@flash1293 flash1293 requested a review from a team as a code owner January 14, 2020 13:25
wylieconlon
wylieconlon approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test locally, but the change LGTM

cchaos
cchaos approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through a couple of plugins in Chrome and Safari and they all seem to render correctly. I would highly suggest checking IE11 too since we still support it and nested flex boxes tend to be an issue in IE.

@flash1293
Copy link
Contributor Author

My last state was that IE11 is broken on master, but it seems like the issue was resolved recently: #53904 I will check the apps there as well.

@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jan 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 merged commit 97d460e into elastic:master Jan 14, 2020
flash1293 added a commit to flash1293/kibana that referenced this pull request Jan 15, 2020
@flash1293
Fix safari layout issue in Visualize, Graph and Lens (elastic#54694)
f37db44
@flash1293 flash1293 mentioned this pull request Jan 15, 2020
Merged
flash1293 added a commit that referenced this pull request Jan 15, 2020
@flash1293
Fix safari layout issue in Visualize, Graph and Lens (#54694) (#54883)
40dfc2b
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
@flash1293 @jkelastic
Fix safari layout issue in Visualize, Graph and Lens (elastic#54694)
149e5fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@wylieconlon wylieconlon wylieconlon approved these changes

Assignees
No one assigned
Labels
Feature:Graph Graph application feature Feature:Lens Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Safari rendering issue in apps with shimmed local angular
5 participants
@flash1293 @kibanamachine @elasticmachine @cchaos @wylieconlon