Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn/ui-shared-deps] include polyfills, required by some deps #54667

Merged
merged 6 commits into from
Jan 14, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jan 14, 2020

Some of our shared deps rely on the polyfills to work in IE, and the polyfills count as implicit universal deps, so move them to our shared deps package.

Fixes #53904

@tylersmalley
Copy link
Contributor

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor

Looks like abort-controller also needs added

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - confirmed this is the last issue to resolve for IE11

@spalger spalger marked this pull request as ready for review January 14, 2020 18:34
@spalger spalger requested a review from a team as a code owner January 14, 2020 18:34
@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.6.0 v8.0.0 labels Jan 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 4456d4d into elastic:master Jan 14, 2020
spalger pushed a commit to spalger/kibana that referenced this pull request Jan 14, 2020
…c#54667)

* [kbn/ui-shared-deps] include polyfills, required by some deps

* remove unnecessary dep

* replace abort-controller for server side use

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@spalger spalger deleted the implement/polyfills-in-shared-deps branch January 14, 2020 19:55
@spalger
Copy link
Contributor Author

spalger commented Jan 14, 2020

7.x/7.6: 4e52072

jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
…c#54667)

* [kbn/ui-shared-deps] include polyfills, required by some deps

* remove unnecessary dep

* replace abort-controller for server side use

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kibana not loading in IE11 (master)
4 participants