[Logs UI] Add expandable rows with category examples #54586

weltenwort · 2020-01-13T15:13:00Z

Summary

This makes the category rows expandable to show actual examples of log messages from the categories during the selected time frame.

closes #50456

Preview

With expanded examples and loading indicator

When fetching log entry samples failed

When underlying log entry samples are not available anymore

TODO

load and render examples
show loading indicator
show error message with retry (if fetching failed)
align columns
show empty message with retry (if fetching resulted in zero examples)
add "Analyze in ML" links for each category and dataset

elasticmachine · 2020-01-13T15:13:03Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

pheyos

Testing the GH review comment functionality...
Works.

weltenwort · 2020-03-05T18:14:38Z

@elasticmachine merge upstream

weltenwort · 2020-03-05T23:18:38Z

@elasticmachine merge upstream

Kerry350

Awesome work 👍 Couple of minor comments.

Not directly linked to this PR, but there seems to be some problems creating the ML jobs against our shared Observability cluster (on any space).

I got things working against a local setup though.

One final thing, is it expected to have so many unknowns under the dataset column?

...lic/pages/logs/log_entry_categories/sections/top_categories/analyze_dataset_in_ml_action.tsx

x-pack/plugins/infra/public/components/logging/log_text_stream/text_styles.tsx

weltenwort · 2020-03-10T14:31:00Z

Thanks a lot for the review!

there seems to be some problems creating the ML jobs against our shared Observability cluster

Looks like the Elasticsearch version on our dev cluster is not compatible with recent changes of the ML module API.

is it expected to have so many unknowns under the dataset column

Seeing that the category itself has a dataset, this doesn't look right. I'll look into it.

weltenwort · 2020-03-11T11:46:14Z

is it expected to have so many unknowns under the dataset column

@Kerry350, I indeed made a mistake reading the value from _source. Thanks for catching that!

I fixed it and migrated to the new link hook in case you want to take another look.

Kerry350 · 2020-03-11T12:03:47Z

@weltenwort All the latest changes look good. Thanks for entertaining the original renaming 👍

Yay 😄

weltenwort · 2020-03-11T13:45:43Z

@elasticmachine merge upstream

weltenwort · 2020-03-11T17:13:33Z

@elasticmachine merge upstream

kibanamachine · 2020-03-11T19:04:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 90cbc6f

History

💔 Build #32409 failed f52e407
💔 Build #32374 failed 1b0e3ee
💚 Build #31691 succeeded 0544202
💚 Build #31292 succeeded 38c6e42
💔 Build #31190 failed 6e23015

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Make the category rows expandable to show actual log messages samples from the categories during the selected time frame.

Backports the following commits to 7.x: - [Logs UI] Add expandable rows with category examples (#54586)

Make the category rows expandable to show actual log messages samples from the categories during the selected time frame.

This fixes the log rate table row expansion button, which broke in #54586 during a refactoring.

This fixes the log rate table row expansion button, which broke in elastic#54586 during a refactoring.

weltenwort added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.7.0 labels Jan 13, 2020

weltenwort self-assigned this Jan 13, 2020

pheyos reviewed Jan 15, 2020

View reviewed changes

pheyos requested review from pheyos and removed request for pheyos January 15, 2020 09:20

weltenwort added 2 commits February 3, 2020 13:02

Add category examples route

298d547

Show examples in category table row expansions

59b37bc

weltenwort force-pushed the logs-ui-categorization-add-examples branch from fce8a3b to 59b37bc Compare February 3, 2020 15:16

weltenwort added 18 commits February 3, 2020 20:14

Use transport.request fallback to query ml jobs

7d58cd2

Prepare log rows and columns for re-use

fc75abf

Render example message using log stream components

a751fd9

Introduce a stricter wrapping mode for the examples

ba2b552

Add example loading indicators

551df33

Add example loading failure message with retry option

2645faf

Remove mismatching log message background color

eaceb39

Merge branch 'master' into logs-ui-categorization-add-examples

687bdfb

Add dataset column to examples and align columns

75e4f4c

Merge branch 'master' into logs-ui-categorization-add-examples

e82cc54

Merge branch 'master' into logs-ui-categorization-add-examples

b668695

Remove unused translations via autofix

704e123

Merge branch 'master' into logs-ui-categorization-add-examples

3074c48

Merge branch 'master' into logs-ui-categorization-add-examples

40bbbac

Display per-dataset anomaly scores and ML links

422dfea

Adjust dataset column width in example rows

182098d

Add message for empty example response

55db708

Merge branch 'master' into logs-ui-categorization-add-examples

ff6521e

weltenwort requested a review from a team as a code owner March 3, 2020 15:58

weltenwort added the release_note:enhancement label Mar 5, 2020

Merge branch 'master' into logs-ui-categorization-add-examples

6e23015

elasticmachine and others added 2 commits March 5, 2020 18:18

Merge branch 'master' into logs-ui-categorization-add-examples

38c6e42

Merge branch 'master' into logs-ui-categorization-add-examples

0544202

Kerry350 self-requested a review March 9, 2020 10:38

Kerry350 approved these changes Mar 10, 2020

View reviewed changes

...lic/pages/logs/log_entry_categories/sections/top_categories/analyze_dataset_in_ml_action.tsx Outdated Show resolved Hide resolved

x-pack/plugins/infra/public/components/logging/log_text_stream/text_styles.tsx Outdated Show resolved Hide resolved

weltenwort added 3 commits March 11, 2020 12:01

Merge branch 'master' into logs-ui-categorization-add-examples

3e818cd

Use new link helper hook for dataset ml link

aea5ece

Correctly read dataset from sample message documents

e283dc8

Rename 'original' to 'pre-wrapped' wrap mode

1b0e3ee

Merge branch 'master' into logs-ui-categorization-add-examples

f52e407

Merge branch 'master' into logs-ui-categorization-add-examples

90cbc6f

weltenwort merged commit 07a7caa into elastic:master Mar 11, 2020

weltenwort deleted the logs-ui-categorization-add-examples branch March 11, 2020 19:07

weltenwort mentioned this pull request Mar 11, 2020

[7.x] [Logs UI] Add expandable rows with category examples (#54586) #59945

Merged

weltenwort added a commit to weltenwort/kibana that referenced this pull request Mar 11, 2020

[Logs UI] Add expandable rows with category examples (elastic#54586)

3ddb920

Make the category rows expandable to show actual log messages samples from the categories during the selected time frame.

weltenwort added a commit that referenced this pull request Mar 11, 2020

[7.x] [Logs UI] Add expandable rows with category examples (#5… (#59945)

b438a53

Backports the following commits to 7.x: - [Logs UI] Add expandable rows with category examples (#54586)

jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Mar 12, 2020

[Logs UI] Add expandable rows with category examples (elastic#54586)

3686783

Make the category rows expandable to show actual log messages samples from the categories during the selected time frame.

weltenwort mentioned this pull request Mar 13, 2020

[Logs UI] Fix log rate table row expansion #60096

Merged

weltenwort added a commit that referenced this pull request Mar 16, 2020

[Logs UI] Fix log rate table row expansion (#60096)

6cd888f

This fixes the log rate table row expansion button, which broke in #54586 during a refactoring.

weltenwort added a commit to weltenwort/kibana that referenced this pull request Mar 16, 2020

[Logs UI] Fix log rate table row expansion (elastic#60096)

ad06c81

This fixes the log rate table row expansion button, which broke in elastic#54586 during a refactoring.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Logs UI] Add expandable rows with category examples #54586

[Logs UI] Add expandable rows with category examples #54586

weltenwort commented Jan 13, 2020 •

edited

Loading

elasticmachine commented Jan 13, 2020

pheyos left a comment •

edited

Loading

weltenwort commented Mar 5, 2020

weltenwort commented Mar 5, 2020

Kerry350 left a comment

weltenwort commented Mar 10, 2020

weltenwort commented Mar 11, 2020 •

edited

Loading

Kerry350 commented Mar 11, 2020

weltenwort commented Mar 11, 2020

weltenwort commented Mar 11, 2020

kibanamachine commented Mar 11, 2020

[Logs UI] Add expandable rows with category examples #54586

[Logs UI] Add expandable rows with category examples #54586

Conversation

weltenwort commented Jan 13, 2020 • edited Loading

Summary

Preview

TODO

elasticmachine commented Jan 13, 2020

pheyos left a comment • edited Loading

Choose a reason for hiding this comment

weltenwort commented Mar 5, 2020

weltenwort commented Mar 5, 2020

Kerry350 left a comment

Choose a reason for hiding this comment

weltenwort commented Mar 10, 2020

weltenwort commented Mar 11, 2020 • edited Loading

Kerry350 commented Mar 11, 2020

weltenwort commented Mar 11, 2020

weltenwort commented Mar 11, 2020

kibanamachine commented Mar 11, 2020

💚 Build Succeeded

History

weltenwort commented Jan 13, 2020 •

edited

Loading

pheyos left a comment •

edited

Loading

weltenwort commented Mar 11, 2020 •

edited

Loading