Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph: Add sample data #54558

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Conversation

flash1293
Copy link
Contributor

This PR adds sample Graph workspaces to the existing sample data sets.

If the license level is sufficient, a Graph link also shows up in the sample data panel:
Screenshot 2020-01-13 at 11 21 56

Known limitations: As the current API of the home plugin does not allow de-registering a link from the sample dataset panel, the following (unlikely) scenario exists:

  • User goes platinum
  • User installs sample data
  • User changes license to something below platinum (e.g. Basic)
  • Kibana server is not restarted
  • Graph link in the sample data panel is still shown and leads to a "Get a platinum license to use Graph" error message if clicked

I think this is OK, as the user had platinum at one point and this can be seen as an additional way of advertising the feature.

Alternatively the home API can be extended to also be able to remove links from the sample data panels, but that felt like over-engineering.

cc @shaunmcgough

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review January 13, 2020 13:14
@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jan 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 requested a review from kertal January 13, 2020 13:22
Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Tested locally with no issues with and without trial license. 👍

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, great that there are now examples in Graph, this is very useful for demoing and new users 👍
I've noticed one more minor limitation, when you've got already installed demo data, the links to graph workspaces from home don't work, however, in that case it's easy to fix by the user by reinstalling the demo data

attributes: {
title: 'Kibana Sample Data - eCommerce',
description:
'This is a sample graph based on an eCommerce data set. It shows the gender, continent, and product category of purchases. The thicker the line is, there are more correlated documents between the vertices.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure, but "The thicker the line is, there are more correlated documents between the vertices." sounds a bit like german (also like austriakisch)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, ping @shaunmcgough - these are your German roots shining through.

@flash1293 flash1293 merged commit 8c878bc into elastic:master Jan 14, 2020
@flash1293 flash1293 deleted the graph/sample-data branch January 14, 2020 17:02
flash1293 added a commit to flash1293/kibana that referenced this pull request Jan 14, 2020
flash1293 added a commit that referenced this pull request Jan 14, 2020
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Graph Graph application feature release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants