Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Cleanup unnecessary use of enzyme-to-json #53980

Merged
merged 5 commits into from
Jan 8, 2020
Merged

[SIEM] Cleanup unnecessary use of enzyme-to-json #53980

merged 5 commits into from
Jan 8, 2020

Conversation

patrykkopycinski
Copy link
Contributor

Summary

enzyme-to-json is setup globally, so there is no need to use that on the test level. This PR cleans up all unnecessary imports

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@patrykkopycinski patrykkopycinski self-assigned this Jan 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@patrykkopycinski patrykkopycinski added the release_note:skip Skip the PR/issue when compiling release notes label Jan 4, 2020
@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

stephmilovic
stephmilovic approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thorough and straightforward cleanup. LGTM once conflicts are resolved.

patrykkopycinski and others added 2 commits January 7, 2020 21:51
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into chore/siem-en…
8a2aca4 
…zyme-to-json

# Conflicts:
#	x-pack/legacy/plugins/siem/public/components/arrows/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/drag_and_drop/drag_drop_context_wrapper.test.tsx
#	x-pack/legacy/plugins/siem/public/components/drag_and_drop/draggable_wrapper.test.tsx
#	x-pack/legacy/plugins/siem/public/components/drag_and_drop/droppable_wrapper.test.tsx
#	x-pack/legacy/plugins/siem/public/components/draggables/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/embeddables/embedded_map.test.tsx
#	x-pack/legacy/plugins/siem/public/components/embeddables/index_patterns_missing_prompt.test.tsx
#	x-pack/legacy/plugins/siem/public/components/embeddables/map_tool_tip/line_tool_tip_content.test.tsx
#	x-pack/legacy/plugins/siem/public/components/embeddables/map_tool_tip/map_tool_tip.test.tsx
#	x-pack/legacy/plugins/siem/public/components/embeddables/map_tool_tip/point_tool_tip_content.test.tsx
#	x-pack/legacy/plugins/siem/public/components/embeddables/map_tool_tip/tooltip_footer.test.tsx
#	x-pack/legacy/plugins/siem/public/components/error_toast_dispatcher/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/event_details/event_details.test.tsx
#	x-pack/legacy/plugins/siem/public/components/event_details/json_view.test.tsx
#	x-pack/legacy/plugins/siem/public/components/field_renderers/field_renderers.test.tsx
#	x-pack/legacy/plugins/siem/public/components/flow_controls/flow_direction_select.test.tsx
#	x-pack/legacy/plugins/siem/public/components/flyout/pane/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/formatted_bytes/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/ip/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/markdown/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/markdown/markdown_hint.test.tsx
#	x-pack/legacy/plugins/siem/public/components/ml/score/create_descriptions_list.test.tsx
#	x-pack/legacy/plugins/siem/public/components/ml_popover/jobs_table/filters/groups_filter_popover.test.tsx
#	x-pack/legacy/plugins/siem/public/components/ml_popover/jobs_table/filters/jobs_table_filters.test.tsx
#	x-pack/legacy/plugins/siem/public/components/ml_popover/jobs_table/job_switch.test.tsx
#	x-pack/legacy/plugins/siem/public/components/ml_popover/jobs_table/jobs_table.test.tsx
#	x-pack/legacy/plugins/siem/public/components/ml_popover/jobs_table/showing_count.test.tsx
#	x-pack/legacy/plugins/siem/public/components/ml_popover/popover_description.test.tsx
#	x-pack/legacy/plugins/siem/public/components/ml_popover/upgrade_contents.test.tsx
#	x-pack/legacy/plugins/siem/public/components/notes/add_note/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/notes/add_note/new_note.test.tsx
#	x-pack/legacy/plugins/siem/public/components/notes/note_card/note_card_body.test.tsx
#	x-pack/legacy/plugins/siem/public/components/page/add_filter_to_global_search_bar/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/page/hosts/host_overview/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/page/network/ip_overview/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/page/network/kpi_network/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/page/network/network_dns_table/is_ptr_included.test.tsx
#	x-pack/legacy/plugins/siem/public/components/page/overview/overview_host_stats/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/page/overview/overview_network_stats/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/paginated_table/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/port/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/resize_handle/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/selectable_text/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/stat_items/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/column_headers/filter/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/column_headers/header/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/column_headers/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/column_headers/text_filter/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/args.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/auditd/generic_details.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/auditd/generic_file_details.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/auditd/primary_secondary_user_info.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/auditd/session_user_host_working_dir.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/netflow/netflow_row_renderer.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/process_draggable.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/suricata/suricata_details.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/suricata/suricata_signature.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/system/auth_ssh.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/system/generic_details.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/system/generic_file_details.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/system/package.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/user_host_working_dir.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/zeek/zeek_details.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/body/sort/sort_indicator.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/data_providers/data_providers.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/data_providers/empty.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/data_providers/provider.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/data_providers/providers.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/header/index.test.tsx
#	x-pack/legacy/plugins/siem/public/components/timeline/timeline.test.tsx
#	x-pack/legacy/plugins/siem/public/components/truncatable_text/index.test.tsx
#	x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/components/import_rule_modal/index.test.tsx
#	x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/components/json_downloader/index.test.tsx
#	x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/components/rule_switch/index.test.tsx
@patrykkopycinski
Merge branch 'master' into chore/siem-enzyme-to-json
51d6f55
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 8eb000d into elastic:master Jan 8, 2020
@patrykkopycinski patrykkopycinski deleted the chore/siem-enzyme-to-json branch January 8, 2020 08:28
@patrykkopycinski patrykkopycinski mentioned this pull request Jan 8, 2020
Merged
patrykkopycinski added a commit that referenced this pull request Jan 8, 2020
@patrykkopycinski
[SIEM] Cleanup unnecessary use of enzyme-to-json (#53980) (#54226)
05abb47
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 8, 2020
@gmmorris
Merge branch 'master' into task-manager/schema-config
9e0c028 
* master: (55 commits)
  [ui/public/utils] Copy rarely used items to where they are consumed (elastic#53819)
  set AppArch team as an owner of the search endpoints (elastic#54131)
  Don't expose Elasticsearch client as Observable (elastic#53824)
  [SIEM] Cleanup unnecessary use of enzyme-to-json (elastic#53980)
  fix ui exports doc (elastic#54138)
  change markdown element title (elastic#54194)
  [Logs UI] Refactor log position to hooks (elastic#53540)
  [SIEM] Implement NP Plugin Setup (elastic#54030)
  [DOCS] Updates ML links (elastic#53613)
  sort renovate packages in config
  Spaces - fix flakey api tests (elastic#54154)
  Remove dependency that was causing effect to re-execute infinitely. (elastic#54160)
  [dev/run] expose unexpected flags as more than just names (elastic#54080)
  [DOCS] Moves index pattern doc to Discover (elastic#53347)
  [SIEM] Cleanup React imports (elastic#53981)
  Update eslint related packages (elastic#54107)
  [Uptime] Added date range filter into expanded list query (elastic#52609)
  [SIEM] Add react/display-name eslint rule (elastic#53107)
  [SIEM] Enable eslint prefer-template rule (elastic#53983)
  Elasticsearch snapshots automation (elastic#53706)
  ...
mbondyra added a commit to mbondyra/kibana that referenced this pull request Jan 8, 2020
@mbondyra
Merge branch 'IS-50036_show-sum-for-a-field-with-formatter' of github…
33515b0 
….com:mbondyra/kibana into IS-50036_show-sum-for-a-field-with-formatter

* 'IS-50036_show-sum-for-a-field-with-formatter' of github.com:mbondyra/kibana:
  [Telemetry] Fix license page crashing on telemetry.enabled: fa… (elastic#54174)
  [ui/public/utils] Copy rarely used items to where they are consumed (elastic#53819)
  set AppArch team as an owner of the search endpoints (elastic#54131)
  Don't expose Elasticsearch client as Observable (elastic#53824)
  [SIEM] Cleanup unnecessary use of enzyme-to-json (elastic#53980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

@XavierM XavierM Awaiting requested review from XavierM

@FrankHassanabad FrankHassanabad Awaiting requested review from FrankHassanabad

@spong spong Awaiting requested review from spong

@angorayc angorayc Awaiting requested review from angorayc

@andrew-goldstein andrew-goldstein Awaiting requested review from andrew-goldstein

@rylnd rylnd Awaiting requested review from rylnd

Assignees

@patrykkopycinski patrykkopycinski

Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrykkopycinski @elasticmachine @kibanamachine @stephmilovic