[Maps] Fix cross origin error for icon spritesheets when Kibana secured via OAuth proxy #53896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpeihl
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
jportner
suggested changes
Jan 2, 2020
x-pack/legacy/plugins/maps/public/connected_components/map/mb/utils.js
Outdated
Show resolved
Hide resolved
…utils.js Co-Authored-By: Joe Portner <5295965+jportner@users.noreply.github.com>
|
@elasticmachine merge upstream |
jportner
approved these changes
Jan 6, 2020
|
This is blocked by #53904 as we want to test this in IE11 so we can comfortably backport. |
|
@elasticmachine merge upstream |
thomasneirynck
approved these changes
Jan 22, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
nickpeihl
added a commit
that referenced
this pull request
Mar 24, 2020
…ed via OAuth proxy (#53896) (#61171) * Set crossOrigin to anonymous only on requests from external hosts * Update x-pack/legacy/plugins/maps/public/connected_components/map/mb/utils.js Co-Authored-By: Joe Portner <5295965+jportner@users.noreply.github.com> * 🙇♂️ Lint Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #53730.
When Kibana is secured via an oauth proxy (as demonstrated in this blog post), the icon spritesheet in Maps fails to load in Safari. Safari redirects the request for the spritesheet through the oauth which returns a cross origin error.
This PR only applies the
crossOrigin='Anonymous'parameter if the requested spritesheet is on another host (for example, when loading a basemap).Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers