Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Corrects URL of the create job tips docs page #53576

Merged
merged 5 commits into from
Dec 19, 2019

Conversation

peteharverson
Copy link
Contributor

Summary

Fixes the URL used in the links from the 'Validate job' component to the Create anomaly detection job tips page.

For example, up to 7.2 it used to be:

https://www.elastic.co/guide/en/kibana/master/job-tips.html#influencers

but from 7.3 is:

https://www.elastic.co/guide/en/elastic-stack-overview/master/create-jobs.html#influencers

Note from 7.3 onwards, the following page was displayed with the out of date link. rather than a 404 message:

image

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@peteharverson
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes LGTM 👍

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@peteharverson peteharverson merged commit 99fde9e into elastic:master Dec 19, 2019
@peteharverson peteharverson deleted the ml-job-tips-doc-url branch December 19, 2019 21:24
peteharverson added a commit to peteharverson/kibana that referenced this pull request Dec 19, 2019
* [ML] Corrects URL of the create job tips docs page

* [ML] Update validate_job_view snapshot

* [ML] Update links for influencers to new ML book
peteharverson added a commit that referenced this pull request Dec 20, 2019
* [ML] Corrects URL of the create job tips docs page

* [ML] Update validate_job_view snapshot

* [ML] Update links for influencers to new ML book
peteharverson added a commit to peteharverson/kibana that referenced this pull request Dec 20, 2019
@peteharverson peteharverson mentioned this pull request Dec 20, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants