Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[File upload] Add file upload to telemetry integration tests #53539

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

kindsun
Copy link
Contributor

@kindsun kindsun commented Dec 18, 2019

While working on #52834 I noticed the File Upload plugin wasn't included in the telemetry integration tests. Adding it here!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kindsun kindsun requested a review from Bamieh December 19, 2019 00:11
@kindsun kindsun marked this pull request as ready for review December 19, 2019 00:11
@kindsun kindsun added the release_note:skip Skip the PR/issue when compiling release notes label Dec 19, 2019
@Bamieh
Copy link
Member

Bamieh commented Jan 8, 2020

@elasticmachine merge upstream

Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just had a chance to look at this after the holidays

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kindsun kindsun merged commit 683c138 into elastic:master Jan 8, 2020
kindsun pushed a commit to kindsun/kibana that referenced this pull request Jan 8, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 8, 2020
* master:
  Reorganize structure of component render to avoid errors. (elastic#54251)
  [DOCS] consolidate telemetry settings to core (elastic#52634)
  Add file upload to telemetry integration tests (elastic#53539)
  filters are back (elastic#54218)
  Add explanation of path.data to contribution guide (elastic#54235)
  fix ecommerce percentages in sample data (elastic#54200)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants