Move CSP options to new platform #52698
Merged
+601
−246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperelman
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
eliperelman
force-pushed
the
feature/np-csp
branch
from
c1b20ce
to
02d335a
Compare
pgayvallet
reviewed
Dec 10, 2019
x-pack/legacy/plugins/security/server/routes/api/v1/authenticate.js
Outdated
Show resolved
Hide resolved
eliperelman
force-pushed
the
feature/np-csp
branch
3 times, most recently
from
002df22
to
255a723
Compare
eliperelman
force-pushed
the
feature/np-csp
branch
from
08c6fb6
to
7ab6d99
Compare
mshustov
reviewed
Dec 11, 2019
joshdover
reviewed
Dec 11, 2019
mshustov
reviewed
Dec 11, 2019
mshustov
reviewed
Dec 12, 2019
eliperelman
force-pushed
the
feature/np-csp
branch
2 times, most recently
from
fe8af81
to
2d3d745
Compare
joshdover
previously requested changes
Dec 12, 2019
eliperelman
force-pushed
the
feature/np-csp
branch
from
b78c450
to
b81a6f8
Compare
kobelb
reviewed
Dec 13, 2019
src/legacy/core_plugins/kibana/server/lib/csp_usage_collector/csp_collector.ts
Show resolved
Hide resolved
| `style-src 'unsafe-inline' 'self'`, | ||
| ], | ||
| }), | ||
| strict: schema.boolean({ defaultValue: true }), |
There was a problem hiding this comment.
We'll have to be careful when backporting this, as the default in 7.x is false
joshdover
approved these changes
Dec 13, 2019
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jportner
approved these changes
Dec 13, 2019
Comment on lines
+28
to
+30
| // TODO: Move this to server.csp using config deprecations | ||
| // ? https://github.com/elastic/kibana/pull/52251 | ||
| path: 'csp', |
There was a problem hiding this comment.
Regarding renaming the csp config key, I will handle this in another PR and make sure we reach consensus between the Platform and Security teams =)
|
Thanks for all the great reviews! |
eliperelman
added a commit
to eliperelman/kibana
that referenced
this pull request
Dec 16, 2019
* Move CSP options to new platform * Expose SharedGlobalConfig from root * Derive CSP options from config * Consolidate CSP configuration with HTTP config * Fix outstanding config renames * Remove legacy CSP configuration calls, migrate to platform properties * Revise docs * Fix test from type change * Expose ICspConfig, consolidate and simplify CSP defaults access * Rebase and update docs * Remove legacy API from route definition params, review nits * Clean up config path usages for consistency * Regenerate docs
eliperelman
added a commit
that referenced
this pull request
Dec 16, 2019
* Move CSP options to new platform (#52698) * Move CSP options to new platform * Expose SharedGlobalConfig from root * Derive CSP options from config * Consolidate CSP configuration with HTTP config * Fix outstanding config renames * Remove legacy CSP configuration calls, migrate to platform properties * Revise docs * Fix test from type change * Expose ICspConfig, consolidate and simplify CSP defaults access * Rebase and update docs * Remove legacy API from route definition params, review nits * Clean up config path usages for consistency * Regenerate docs * Test correct default value of csp.strict in 7.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move CSP options from legacy into the new platform. This blocks being able to add the new rendering service in #52161.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportThis was checked for keyboard-only and screenreader accessibilityFor maintainers
Dev Docs
The default options used for managing Kibana's Content Security Policy have been moved into core for the new platform. Relevant items exposed from
src/core/serverinclude:CspConfig: TypeScript class for generating CSP configuration. Will generate default configuration for any properties not specified in initialization.CspConfig.DEFAULT: Default CSP configuration.ICspConfig: Interface representing CSP configuration.