Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] max-old-space-size #52310

Merged
merged 14 commits into from
Dec 11, 2019
Merged

[docs] max-old-space-size #52310

merged 14 commits into from
Dec 11, 2019

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Dec 5, 2019 •
edited by spalger
Loading

Adds a memory configuration section to production docs.

Closes #9006

[skip ci]

@jbudz jbudz added review Team:Docs Team:Operations Team label for Operations Team labels Dec 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

gchaps
gchaps reviewed Dec 5, 2019
View reviewed changes
docs/setup/production.asciidoc Outdated Show resolved Hide resolved
docs/setup/production.asciidoc Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💔 Build Failed

jbudz and others added 2 commits December 5, 2019 12:35
@jbudz @gchaps
Update docs/setup/production.asciidoc
0bb7782 
Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
@jbudz @gchaps
Update docs/setup/production.asciidoc
eafa6fb 
Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
gchaps
gchaps approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger
Copy link
Contributor

spalger commented Dec 5, 2019

@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented Dec 5, 2019

(added [skip ci] to the pr description and merged master to get rid of the CI errors)

tylersmalley
tylersmalley reviewed Dec 6, 2019
View reviewed changes
docs/setup/production.asciidoc Outdated
[[memory]]
=== Memory
Kibana has a default memory limit of 1.4 GB, and in most cases, we recommend leaving this unconfigured. In some scenarios, such as running on containers with limited
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the max old space is generally 1.4GB, it is based on system information, like memory available. @mistic did a deep dive into this a while back and can comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right, good catch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tylersmalley exactly. Nodejs calculates the default allocated heap according multiple variables, processor architecture, total available physical memory etc (the logic can be found here https://github.com/v8/v8/blob/master/src/heap/heap.cc#L227)

So in order to be able to specify what is our minimum required memory we need to proceed what we have been discussing of distribute kibana with an override NODE_OPTIONS for heap. So, at least for now, we should not specify that information on the docs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a clarifier, `default maximum memory limit. it's not very specific but I'm hoping it's good enough

tylersmalley
tylersmalley suggested changes Dec 9, 2019
View reviewed changes
docs/setup/production.asciidoc Outdated Show resolved Hide resolved
@tylersmalley
Copy link
Contributor

Also worth mentioning that in addition to the docs being built by CI, they also make a preview available which helps with reviewing http://kibana_52310.docs-preview.app.elstc.co/guide/en/kibana/master/production.html#memory

tylersmalley
tylersmalley reviewed Dec 10, 2019
View reviewed changes
docs/setup/production.asciidoc Outdated
=== Memory
Kibana has a default maximum memory limit of 1.4 GB, and in most cases, we recommend leaving this unconfigured. In some scenarios, such large reporting jobs
, it may make sense to tweak limits to meet more specific requirements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could move the comment to the previous line it will remove the space before the comma.

tylersmalley
tylersmalley approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, then LGTM

@jbudz jbudz merged commit 6187643 into elastic:master Dec 11, 2019
jbudz added a commit that referenced this pull request Dec 11, 2019
@jbudz
[docs] max-old-space-size (#52310)
2d12bb3 
* [docs] max-old-space-size

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* _max_

* Update docs/setup/production.asciidoc

Co-Authored-By: Tyler Smalley <tylersmalley@me.com>

* max example

* move comma

* Update production.asciidoc
jbudz added a commit that referenced this pull request Dec 11, 2019
@jbudz
[docs] max-old-space-size (#52310)
c29d660 
* [docs] max-old-space-size

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* _max_

* Update docs/setup/production.asciidoc

Co-Authored-By: Tyler Smalley <tylersmalley@me.com>

* max example

* move comma

* Update production.asciidoc
jbudz added a commit that referenced this pull request Dec 11, 2019
@jbudz
[docs] max-old-space-size (#52310)
44a4cee 
* [docs] max-old-space-size

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* _max_

* Update docs/setup/production.asciidoc

Co-Authored-By: Tyler Smalley <tylersmalley@me.com>

* max example

* move comma

* Update production.asciidoc
jbudz added a commit that referenced this pull request Dec 11, 2019
@jbudz
[docs] max-old-space-size (#52310)
2484ca1 
* [docs] max-old-space-size

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* _max_

* Update docs/setup/production.asciidoc

Co-Authored-By: Tyler Smalley <tylersmalley@me.com>

* max example

* move comma

* Update production.asciidoc
jbudz added a commit that referenced this pull request Dec 11, 2019
@jbudz
[docs] max-old-space-size (#52310)
98c68f7 
* [docs] max-old-space-size

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* _max_

* Update docs/setup/production.asciidoc

Co-Authored-By: Tyler Smalley <tylersmalley@me.com>

* max example

* move comma

* Update production.asciidoc
jbudz added a commit that referenced this pull request Dec 11, 2019
@jbudz
[docs] max-old-space-size (#52310)
6f5662a 
* [docs] max-old-space-size

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* _max_

* Update docs/setup/production.asciidoc

Co-Authored-By: Tyler Smalley <tylersmalley@me.com>

* max example

* move comma

* Update production.asciidoc
jbudz added a commit that referenced this pull request Dec 11, 2019
@jbudz
[docs] max-old-space-size (#52310)
6bb5d45 
* [docs] max-old-space-size

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* _max_

* Update docs/setup/production.asciidoc

Co-Authored-By: Tyler Smalley <tylersmalley@me.com>

* max example

* move comma

* Update production.asciidoc
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 30, 2019
@jloleysens
Merge remote-tracking branch 'upstream/master' into feature/console-s…
02e53f0 
…aved-objects

* upstream/master: (134 commits)
  [Dashboard] Add visualization from dasbhoard empty screen (elastic#52670)
  Print out agent debugging links during CI (elastic#52812)
  Add babel-plugin-styled-components to webpack config (elastic#52862)
  [Console] Fix load from remote (elastic#52814)
  Ensure APM agent config file path respects CWD (elastic#52880)
  [Watcher] Removed overwritten property (elastic#49998)
  [Data Plugin]: Remove `export *` for common code from public/server index files (elastic#52821)
  Hide stderr git output during APM agent configuration (elastic#52878)
  Polish migration.md (elastic#52764)
  Change ajax_stream to use new-line delimited JSON (elastic#52797)
  Stabilize dashboard save modal functional test (elastic#52761)
  [Discover] Place tooltip at bottom of filter button (elastic#52720)
  Disable/enable filter with click+shift on a filter badge (elastic#52751)
  [APM] Make client-side routes static (elastic#52574)
  [Maps] Get basic structure of NP client shim in place (elastic#52551)
  update chromedriver to 79 (elastic#52784)
  [DOCS] Adds example of assigning roles in Reporting (elastic#52757)
  Add instructions for setting up remote clusters needed for CCS and CCR (elastic#52796)
  [docs] max-old-space-size (elastic#52310)
  [Monitoring] Fix 7.5 cloud test issues (elastic#51781)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic left review comments

@tylersmalley tylersmalley tylersmalley approved these changes

@gchaps gchaps gchaps approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Docs Team:Operations Team label for Operations Team v7.0.2 v7.1.2 v7.2.2 v7.3.3 v7.4.3 v7.5.1 v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for configuring --max-old-space-size
6 participants
@jbudz @elasticmachine @spalger @tylersmalley @mistic @gchaps