-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vis: Default editor] EUIficate and Reactify the sidebar #49864
Merged
Merged
Changes from all commits
Commits
Show all changes
83 commits
Select commit
Hold shift + click to select a range
3a39ece
EUIficate the sidebar
sulemanof abb59f0
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof fcd0c40
Create a state reducer and a state context
sulemanof c1bd92c
Create an editor context and actions
sulemanof d50871e
Improve types
sulemanof c8c4a85
Apply aggs reordering
sulemanof a691bd6
Fix functionality
sulemanof cb76cf0
Improve types
sulemanof 62b7eb6
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof a46ec08
Fix sub_agg changes
sulemanof 78b88bd
Remove legacy dependencies
sulemanof 8041626
Watch dirty state
sulemanof 4609e9c
Fix dirty state changes
sulemanof 0afe33e
Update actions and reducers
sulemanof 0b9ddc0
Handle keyboard submit
sulemanof 78ccb5e
Apply editor form validation
sulemanof d6729ab
Remove fancy forms
sulemanof 920374d
Update validation
sulemanof ad30aa8
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof a2adf55
Use embeddable instead of visualize loader
sulemanof 39db9e6
Add auto apply behavior
sulemanof df6cd61
Remove legacy styles
sulemanof 883a315
Remove the sidebar
sulemanof 66400b4
Restrict responsive to the bottom_bar
sulemanof 2cd86c5
Upgrade @elastic/eui to v14.10.0
sulemanof e586b2e
Replace EuiBottomBar with EuiControlBar
sulemanof e90f153
Get rid of mutations in control vis
sulemanof b1ec097
Revert "Upgrade @elastic/eui to v14.10.0"
sulemanof d743353
Replace bottom bar with a control panel for sidebar
sulemanof 6a36ad9
Replace selectors
sulemanof 6762f8b
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof b7909cd
Use editor resizer
sulemanof 7dbf84e
Apply selectors
sulemanof 8bc5ad1
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof 989e80b
Change selectors
sulemanof 48eb626
Fix sub agg change values
sulemanof b13b76c
Add collapse button
sulemanof c833615
Fix tests
sulemanof 9f471bc
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof 2ecca75
Get rid of editor editor_state_context, simplify the code
sulemanof 32c49e1
Fix jest tests, update snapshots
sulemanof 993d457
Fix types
sulemanof db4ad8c
Moving collapse button to right of index pattern
4aeff08
Tweaks bottom buttons
fd950d7
Moved Vega buttons so they don’t scroll away
c201f31
Fix responsiveness
46f71a0
Resolve UI comments
sulemanof 262ac9a
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof 06c5ab3
Fix console resizer
sulemanof 9c1f2da
Update state handling
sulemanof d77c05a
Small fixes
sulemanof e30e2c0
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof c1a78d6
Update imports
sulemanof c3798a6
Minor fixes
sulemanof 4e73c47
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof ebe0607
Revert changes
sulemanof ae7aa2a
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof b00a939
Fix infinite render in rollup
sulemanof 0090f96
Merge branch 'master' into EUIfication/sidebar
sulemanof 9af7f93
Fix merge conflicts
sulemanof 3fc4959
Fix styles
sulemanof 3bfbaae
Minor fixes
sulemanof e01ec51
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof 3701228
Update input_control_vis_type due to merge conflicts
sulemanof 239ab81
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof 2f6449d
Fix merge conflicts
sulemanof e965ad8
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof 8a82137
Fix types after shimming
sulemanof c0b0db9
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof 3f003a8
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof d4e8eec
Fix merge conflicts in tests
sulemanof d695c1b
Fix tests
sulemanof 67ab891
Update dev docs
sulemanof 1b19809
Merge branch 'master' into EUIfication/sidebar
elasticmachine de027f5
Apply some memoizations
sulemanof 590c967
Bail out of additional render in metrics and axes
sulemanof 2d52c0d
Apply performance optimizations for metrics and axis panel
sulemanof 84e874b
Fix comments
sulemanof b3c3422
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof 6ba4465
Remove unused translations
sulemanof 9c895d1
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof f9345c3
Use debounce when autoapply enabled
sulemanof f4a60ae
Merge remote-tracking branch 'upstream/master' into EUIfication/sidebar
sulemanof File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 30 additions & 6 deletions
36
...ublic/np_ready/application/components/split_panel/__snapshots__/split_panel.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 2 additions & 4 deletions
6
...ugins/input_control_vis/public/components/editor/__snapshots__/controls_tab.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super confusing - there is
panel.width
which relates to the last set width and there ispanel.getWidth
which returns the actual width of the dom element. Why do we need both?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added
panel.width
to handle the panel resizing with keyboard (simply increase or decrease on1%
). But resizing with the mouse has more calculations which need the actual size of panel in pixels.