Removing the lens feature, using visualize instead #48041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobelb
added
release_note:skip
wylieconlon
approved these changes
Oct 11, 2019
💔 Build Failed |
💔 Build Failed |
eliperelman
approved these changes
Oct 14, 2019
|
@elasticmachine merge upstream |
💔 Build Failed |
💚 Build Succeeded |
legrego
reviewed
Oct 15, 2019
| @@ -46,7 +46,7 @@ export const buildOSSFeatures = ({ savedObjectTypes, includeTimelion }: BuildOSS | |||
| }), | |||
| icon: 'visualizeApp', | |||
| navLinkId: 'kibana:visualize', | |||
| app: ['kibana'], | |||
| app: ['kibana', 'lens'], | |||
There was a problem hiding this comment.
Technically unrelated to your changeset, but should the dashboard feature privileges also grant read access to the lens saved object type, like we do for timelion-sheet today?
There was a problem hiding this comment.
@wylieconlon can Lens visualizations currently be "embedded" in Dashboards?
There was a problem hiding this comment.
Even if Lens can be "embedded" in Dashboards, I'd prefer this separate bug be addressed in another PR.
legrego
approved these changes
Oct 15, 2019
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Oct 15, 2019
* Removing the lens feature, using visualize instead * Updating /api/features test because lens isn't a feature anymore * Updating capability from lens to visualize in test * Fixing api integration test
kobelb
added a commit
that referenced
this pull request
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a dedicated Lens feature breaks from the convention which we established with Timelion being considered part of the Visualize feature. Once Feature privileges besides
allandreadis complete, there will be support for "sub-feature privileges", so that end-users can grant access to a subset of Visualizations.In the meantime, this removes the Lens feature and relies upon the Visualize feature. As such, we're no longer checking the lens ui capabilities, and instead using the visualize ui capabilities. I didn't move over the api or catalogue components of the privilege definitions for Lens, as those were unused. Also, the old Lens feature privileges used to grant all access to the
searchsaved-objects, which I'm pretty sure was a mistake, so this has been removed also.