Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Use new platform for toast notifications #47276

Merged
merged 4 commits into from
Oct 7, 2019
Merged

[APM] Use new platform for toast notifications #47276

merged 4 commits into from
Oct 7, 2019

Conversation

smith
Copy link
Contributor

@smith smith commented Oct 3, 2019 •
edited by sorenlouv
Loading

Fixes #46550.
Fixes #46454

@smith smith requested a review from a team as a code owner October 3, 2019 20:42
@smith smith added release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Oct 3, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

cauemarcondes
cauemarcondes reviewed Oct 4, 2019
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small comment about commented lines

.../plugins/apm/public/components/app/TransactionOverview/__jest__/TransactionOverview.test.tsx Outdated
Comment on lines 34 to 38
// http: {
// basePath: {
// prepend: (path: string) => `/basepath${path}`
// }
// },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can delete these commented lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in b9d014d.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@smith
Copy link
Contributor Author

smith commented Oct 7, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@smith smith merged commit b4110b3 into elastic:master Oct 7, 2019
@smith smith deleted the nls/46550/toast branch October 7, 2019 14:56
@smith smith mentioned this pull request Oct 7, 2019
Closed
@sorenlouv sorenlouv mentioned this pull request Oct 10, 2019
Merged
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

sorenlouv added a commit that referenced this pull request Oct 10, 2019
@sorenlouv
[7.x] [APM] Use new platform for toast notifications (#47276) | [APM]…
0d77169 
… Agent configuration phase 2 (#46995) (#47806)

* [APM] Use new platform for toast notifications (#47276)

* [APM] Use new platform for toast notifications

* fix more tests

* remove comment

* [APM] Agent configuration phase 2 (#46995)

* [APM] Agent Config Management Phase 2

* Add status indicator

* Extract TimestampTooltip component

* Remove unused StickyTransactionProperties component

* Fix snapshot and minor cleanup

* Minor cleanup

* Display settings conditionally by agent name

* Fix client

* Format timestamp

* Minor design feedback

* Clear cache when clicking refresh

* Fix test

* Revert t() short hand

* Fix translations

* Add support for “all” option

* Fix API tests

* Move delete button to footer

* Fix snapshots

* Add API tests

* Fix toasts

* Address feedback and ensure order when searching for configs

* Fix snapshots

* Remove timeout
@ogupte ogupte self-assigned this Oct 21, 2019
@ogupte ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes left review comments

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@ogupte ogupte

Labels
apm:test-plan-done Pull request that was successfully tested during the test plan release_note:skip Skip the PR/issue when compiling release notes v7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] New platform migration update toast notifications [APM] Error thrown when creating watcher
5 participants
@smith @elasticmachine @sorenlouv @cauemarcondes @ogupte