[Graph] App state management saga tests #46914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
release_note:skip
31 tasks
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
…anagement-saga-tests
💔 Build Failed |
|
Jenkins, test this. |
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
kertal
approved these changes
Oct 7, 2019
There was a problem hiding this comment.
Code LGTM
Apart from the console.error that should go away when we hopefully upgrade to the next react version, there's one thing I've noticed, when I start the test (node scripts/jest legacy/plugins/graph ), I got several The corejs option only has an effect when the useBuiltIns option is not false. However I don't know I this is related to this PR, and it's just a observation, just wanted to mention it.
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Oct 8, 2019
flash1293
added a commit
that referenced
this pull request
Oct 8, 2019
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #46133
Adds tests to sagas and critical parts of state management