-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Graph] Reactify visualization #46799
Conversation
Pinging @elastic/kibana-app |
💚 Build Succeeded |
@elasticmachine merge upstream |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, this was caused by the ace editor in the inspect panel (this will go away shortly and be replaced by the standard inspect panel). I fixed it temporarily by doing what the warning says :) |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.gphNode__text { | ||
fill: $euiColorDarkestShade; | ||
|
||
&--lowOpacity { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this class completely. The icons should be fully opaque when on top of the node colors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. This class was still used in other places because the styling of icons in menus was entangled with the node styles. I separated them and removed some unused classes.
} | ||
|
||
.gphNode__text { | ||
fill: $euiColorDarkestShade; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, fixed. As the visualization now supports dark colors, I removed the light color filter from the default palette.
} | ||
|
||
&--inverse { | ||
fill: $euiColorLightestShade; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fill: $euiColorLightestShade; | |
fill: $euiColorGhost; |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more suggestions but then it LGTM
opacity: .7; | ||
} | ||
|
||
&--pickable:hover, &--pickable:focus, &--selected { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate selectors to their own lines.
} | ||
|
||
.gphNode__text { | ||
fill: $euiColorInk; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cursor: pointer
as @kertal suggested
💚 Build Succeeded |
This PR migrates the visualization itself to React and adds some tests. This is an interim solution, it will eventually be implemented with cytoscape.js: #46784
The resulting DOM should stay exactly the same, with a few renamed classes to match BEM and light icon colors for dark node colors.
@miukimiu @cchaos If you have some quick win ideas to improve the appearance they would be appreciated - it's not required for this PR though.