Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Creates developer folder #45280

Merged
merged 1 commit into from
Sep 11, 2019
Merged

[DOCS] Creates developer folder #45280

merged 1 commit into from
Sep 11, 2019

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 10, 2019

Summary

Related to #44907

This PR creates the docs/developer folder and migrates content into it from the "development" folder.

[skip ci]

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

@gchaps gchaps mentioned this pull request Sep 10, 2019
13 tasks
@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Sep 10, 2019
@lcawl
Copy link
Contributor Author

lcawl commented Sep 10, 2019

Please note: I didn't move the contents from https://github.com/elastic/kibana/tree/master/docs/development/core/public or https://github.com/elastic/kibana/tree/master/docs/development/core/server since I'm not sure what their purpose is.

@lcawl lcawl requested a review from epixa September 10, 2019 18:36
Copy link
Contributor

@epixa epixa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit baee239 into elastic:master Sep 11, 2019
@lcawl lcawl deleted the dev-folder branch September 11, 2019 00:13
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 11, 2019
lcawl added a commit that referenced this pull request Sep 11, 2019
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 11, 2019
lcawl added a commit that referenced this pull request Sep 11, 2019
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 11, 2019
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 11, 2019
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 11, 2019
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 11, 2019
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 11, 2019
lcawl added a commit that referenced this pull request Sep 11, 2019
lcawl added a commit that referenced this pull request Sep 11, 2019
lcawl added a commit that referenced this pull request Sep 11, 2019
lcawl added a commit that referenced this pull request Sep 11, 2019
lcawl added a commit that referenced this pull request Sep 11, 2019
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 11, 2019
…ation_behaviour

* 'master' of github.com:elastic/kibana: (24 commits)
  [Console] SQL template with triple quote in completion (elastic#45248)
  [ML] Data Frames: Cards as links (elastic#45254)
  fix(code/frontend): should show updating instead of cloning when updating (elastic#45238)
  fix(code/frontend): fix document search result from (elastic#45236)
  disable another flaky suite (elastic#45323) (elastic#45330)
  disable flaky suite (elastic#45105)
  skip flaky suite (elastic#43069)
  skip flaky suite (elastic#45089)
  disable jest suite that has no enabled tests (elastic#44250)
  disable flaky test (elastic#45317)
  disable flaky test (elastic#45315)
  [DOCS] Creates developer folder (elastic#45280)
  [SIEM] Changes ML conditional links to use tabs, fixes a small bug with null filterQuery   (elastic#45218)
  [skip-ci][Maps] Update search docs (elastic#45307)
  Revert "[skip ci][Maps] Update search document section with ne… (elastic#45301)
  Prep visualizations plugin for NP migration. (elastic#44839)
  Replace Discover chart with elastic-charts (elastic#43788)
  [skip ci][Maps] Update search document section with new features (elastic#44819)
  Revert "Revert "[ci] compress jobs for CI stability" (elastic#44584)"
  add src/plugins to the list of plugin dirs to watch (elastic#45033)
  ...

# Conflicts:
#	src/legacy/core_plugins/console/public/src/utils.js
#	src/legacy/core_plugins/console/public/tests/src/utils_string_expanding.txt
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 11, 2019
…-to-np-ready

* 'master' of github.com:elastic/kibana: (25 commits)
  [ML] Fixes display of matching modules in index data visualizer (elastic#45261)
  [Console] Update indentation behaviour (elastic#45249)
  Convert value provided to PhraseValueInput to string to catch Exception (elastic#45259)
  [Region Map] Fix loading default vector map and base layer setting (elastic#43858)
  [ML] Fixing empty time range when cloning jobs (elastic#45286)
  [ML] Fixing wizard validation delay (elastic#45265)
  [Logs UI] Interpret finished analysis jobs as healthy (elastic#45268)
  [Console] SQL template with triple quote in completion (elastic#45248)
  [ML] Data Frames: Cards as links (elastic#45254)
  fix(code/frontend): should show updating instead of cloning when updating (elastic#45238)
  fix(code/frontend): fix document search result from (elastic#45236)
  disable another flaky suite (elastic#45323) (elastic#45330)
  disable flaky suite (elastic#45105)
  skip flaky suite (elastic#43069)
  skip flaky suite (elastic#45089)
  disable jest suite that has no enabled tests (elastic#44250)
  disable flaky test (elastic#45317)
  disable flaky test (elastic#45315)
  [DOCS] Creates developer folder (elastic#45280)
  [SIEM] Changes ML conditional links to use tabs, fixes a small bug with null filterQuery   (elastic#45218)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants