[ML] Add multi metric job wizard test #45279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyos
added
test_ui_functional
v8.0.0
release_note:skip
pheyos
requested review from
walterra,
spalger,
darnautov,
alvarezmelissa87,
peteharverson and
jgowdyelastic
|
Tested locally. LGTM |
jgowdyelastic
approved these changes
Sep 10, 2019
💚 Build Succeeded |
spalger
approved these changes
Sep 10, 2019
| @@ -43,7 +43,7 @@ export const AnomalyChart: FC<Props> = ({ | |||
| const data = chartType === CHART_TYPE.SCATTER ? flattenData(chartData) : chartData; | |||
| const xDomain = getXRange(data); | |||
| return ( | |||
| <div style={{ width, height }} data-test-subj="mlAnomalyChart"> | |||
| <div style={{ width, height }} data-test-subj={`mlAnomalyChart ${CHART_TYPE[chartType]}`}> | |||
There was a problem hiding this comment.
I know that @dmlemeshko is changing the way that test subjects with spaces work, so I want to make sure that this and that PR don't collide for disaster. Can you two coordinate to make sure that your PRs get merged in the right order?
This was referenced Sep 11, 2019
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Sep 11, 2019
This PR adds functional UI tests to create a machine learning job using the multi metric wizard.
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Sep 11, 2019
This PR adds functional UI tests to create a machine learning job using the multi metric wizard.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 11, 2019
…-to-np-ready * 'master' of github.com:elastic/kibana: Upgrade EUI to 13.8.1 (elastic#45052) [ML] Add multi metric job wizard test (elastic#45279) [SIEM] Inject/apply KQL changed in refresh button (elastic#45065) [Graph] Type persistence (elastic#44985) Functional tests: convert more test/services to TS (elastic#45176)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 11, 2019
…ditor * 'master' of github.com:elastic/kibana: (76 commits) Upgrade EUI to 13.8.1 (elastic#45052) [ML] Add multi metric job wizard test (elastic#45279) [SIEM] Inject/apply KQL changed in refresh button (elastic#45065) [Graph] Type persistence (elastic#44985) Functional tests: convert more test/services to TS (elastic#45176) [ML] Fixes display of matching modules in index data visualizer (elastic#45261) [Console] Update indentation behaviour (elastic#45249) Convert value provided to PhraseValueInput to string to catch Exception (elastic#45259) [Region Map] Fix loading default vector map and base layer setting (elastic#43858) [ML] Fixing empty time range when cloning jobs (elastic#45286) [ML] Fixing wizard validation delay (elastic#45265) [Logs UI] Interpret finished analysis jobs as healthy (elastic#45268) [Console] SQL template with triple quote in completion (elastic#45248) [ML] Data Frames: Cards as links (elastic#45254) fix(code/frontend): should show updating instead of cloning when updating (elastic#45238) fix(code/frontend): fix document search result from (elastic#45236) disable another flaky suite (elastic#45323) (elastic#45330) disable flaky suite (elastic#45105) skip flaky suite (elastic#43069) skip flaky suite (elastic#45089) ...
pheyos
added a commit
that referenced
this pull request
Sep 11, 2019
pheyos
added a commit
that referenced
this pull request
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds functional UI tests to create a machine learning job using the multi metric wizard.
Test steps / validations