Sort by score #4466
Merged
Sort by score #4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigFunger
added
bug
BigFunger
removed
the
bug
| * @param {number} | ||
| */ | ||
| SegmentedReq.prototype.setMaxSegments = function (maxSegments) { | ||
| this._maxSegments = _.parseInt(maxSegments); |
There was a problem hiding this comment.
I thought we had a rule in jshint about adding base 10 to parseInt. In any event, you should do it.
Also, what happens when we set _maxSegments to 0?
|
I take issue with this closing #4111....
|
BigFunger
force-pushed
the
sort-by-score
branch
from
8896f61 to
589de06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3973
This fixes #4111
This fixes #4538
Replaces PR #4012
When using segmented indexes, no score is returned. When sorting by _score, need to force the courier to only request a single segment for all data.