You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a listing page to Graph to make it consistent with other apps like Maps, Visualize or Dashboards. It uses the table_list_view component that is also used for Dashboard and Visualize.
Within the workspace view, the Open and Delete menu actions are gone (because those are handled on the listing page)
This PR also separates the legacy angular components into a separate folder angular, to move them over into their respective folders once they are converted over to typescript and react.
Platform team: I added the onClick property to the types of breadcrumbs, this is supported by the underlying EUI component but wasn't exposed through the core types yet.
Checklist
Use strikethroughs to remove checklist items you don't feel are applicable to this PR.
When navigating back via breadcrumb I always get the 'Discard changes to workspace?' modal. Even when I saved just before, or didn't change anything
That was intentional, currently the message is only shown when navigating away from the current workspace via the New button, but data loss can also occur in other circumstances (like navigating via breadcrumb). The new implementation is actually doing the right thin and making sure that nothing is lost, but does not check whether the saved workspace is identical to the current state. Because of that it can get quite annoying. I removed the check there and left a todo for now till there is a way to check whether something actually changed (it's on my list)
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, deleting items from graph workspace works now. Think it would be nice to have a functional test for deleting, however since it's all part of a big refactoring, there's no priority here,
@restrry Good catch, I looked into the EUI code and the property is passed to EuiLink which types it with MouseEventHandler<HTMLButtonElement> - updated it here.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flash1293
added
release_note:enhancement
Feature:Graph
Summary
This PR adds a listing page to Graph to make it consistent with other apps like Maps, Visualize or Dashboards. It uses the
table_list_viewcomponent that is also used for Dashboard and Visualize.Within the workspace view, the
OpenandDeletemenu actions are gone (because those are handled on the listing page)This PR also separates the legacy angular components into a separate folder
angular, to move them over into their respective folders once they are converted over to typescript and react.Platform team: I added the
onClickproperty to the types of breadcrumbs, this is supported by the underlying EUI component but wasn't exposed through the core types yet.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers